Merge pull request #949 from lukaszstolarczuk/fix-ghcr-login

Fix GH Container Registry log-in

Author: lukaszstolarczuk

.github/workflows/gha.yml

@@ -4,13 +4,13 @@ on: [push, pull_request]
 env:
   REPO:           libpmemobj-cpp
   GITHUB_REPO:    pmem/libpmemobj-cpp
+  CONTAINER_REG:  ghcr.io/pmem/libpmemobj-cpp
 
 jobs:
   linux:
     name: Linux
     runs-on: ubuntu-latest
     env:
-      CONTAINER_REG:  ghcr.io/pmem/libpmemobj-cpp
       # use org's Private Access Token to log in to GitHub Container Registry
       CONTAINER_REG_USER:   ${{ secrets.GH_CR_USER }}
       CONTAINER_REG_PASS:   ${{ secrets.GH_CR_PAT }}
@@ -33,6 +33,9 @@ jobs:
         with:
           fetch-depth: 50
 
+      - name: Log in to the container registry
+        run: echo "${CONTAINER_REG_PASS}" | docker login ghcr.io -u="${CONTAINER_REG_USER}" --password-stdin
+
       - name: Pull or rebuild the image
         run: cd $WORKDIR && ${{ matrix.CONFIG }} ./pull-or-rebuild-image.sh
 

utils/docker/images/push-image.sh

@@ -43,8 +43,5 @@ then
 	exit 1
 fi
 
-echo "Log in to the container registry"
-echo "${CONTAINER_REG_PASS}" | docker login ghcr.io -u="${CONTAINER_REG_USER}" --password-stdin
-
 echo "Push the image to the container registry"
 docker push ${CONTAINER_REG}:${TAG}