Skip to content

Commit be05517

Browse files
committed
Fixed RTAnalysis attribute names in tests.
1 parent e878872 commit be05517

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ The data to be analyzed should be stored in two pandas Series of the same size,
2828
rta.fit(rt, accuracy)
2929
```
3030

31-
The resulting estimates are printed to the screen (assuming that the `verbose` flag is not set to false) and also stored to internal variables `rta.meanrt_` and `rta.meanacc_`.
31+
The resulting estimates are printed to the screen (assuming that the `verbose` flag is not set to false) and also stored to internal variables `rta.mean_rt_` and `rta.mean_accuracy_`.
3232

3333
## Test 1: A simple smoke test
3434

@@ -95,8 +95,8 @@ def test_rtanalysis_fit():
9595
rta = RTAnalysis()
9696
rta.fit(test_df.rt, test_df.accuracy)
9797

98-
assert np.allclose(meanRT, rta.meanrt_)
99-
assert np.allclose(meanAcc, rta.meanacc_)
98+
assert np.allclose(meanRT, rta.mean_rt_)
99+
assert np.allclose(meanAcc, rta.mean_accuracy_)
100100
```
101101

102102
We generate the data with known mean and accuracy values, fit the model using our function, and then confirm that our estimates are basically equal to the actual values. We use `np.allclose()` rather than a test for equality because sometimes the values will be off by a very small amount due to the numerical precision of the computer; an equality test would treat those as different, but `np.allclose` allows some tolerance in its test.
@@ -174,8 +174,8 @@ def simulated_data(params):
174174
def test_rtanalysis_fit(simulated_data, params):
175175
rta = RTAnalysis()
176176
rta.fit(simulated_data.rt, simulated_data.accuracy)
177-
assert np.allclose(params['meanRT'], rta.meanrt_)
178-
assert np.allclose(params['meanAcc'], rta.meanacc_)
177+
assert np.allclose(params['meanRT'], rta.mean_rt_)
178+
assert np.allclose(params['meanAcc'], rta.mean_accuracy_)
179179

180180

181181
def test_rtanalysis_checkfail(simulated_data, params):
@@ -199,8 +199,8 @@ def test_rtanalysis_parameteric(meanRT, sdRT, meanAcc):
199199
rta = RTAnalysis()
200200
if meanAcc > 0:
201201
rta.fit(test_df.rt, test_df.accuracy)
202-
assert np.allclose(meanRT, rta.meanrt_)
203-
assert np.allclose(meanAcc, rta.meanacc_)
202+
assert np.allclose(meanRT, rta.mean_rt_)
203+
assert np.allclose(meanAcc, rta.mean_accuracy_)
204204
else:
205205
with pytest.raises(ValueError):
206206
rta.fit(test_df.rt, test_df.accuracy)

tests/test_2_fit.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ def test_rtanalysis_fit():
1515
meanAcc = 0.8
1616
test_df = generate_test_df(meanRT, sdRT, meanAcc)
1717
rta.fit(test_df.rt, test_df.accuracy)
18-
assert np.allclose(meanRT, rta.meanrt_)
19-
assert np.allclose(meanAcc, rta.meanacc_)
18+
assert np.allclose(meanRT, rta.mean_rt_)
19+
assert np.allclose(meanAcc, rta.mean_accuracy_)

tests/test_4_fixture.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ def simulated_data(params):
2323
def test_rtanalysis_fit(simulated_data, params):
2424
rta = RTAnalysis()
2525
rta.fit(simulated_data.rt, simulated_data.accuracy)
26-
assert np.allclose(params["meanRT"], rta.meanrt_)
27-
assert np.allclose(params["meanAcc"], rta.meanacc_)
26+
assert np.allclose(params["meanRT"], rta.mean_rt_)
27+
assert np.allclose(params["meanAcc"], rta.mean_accuracy_)
2828

2929

3030
def test_rtanalysis_checkfail(simulated_data, params):

tests/test_5_parametric.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ def test_rtanalysis_parameteric(meanRT, sdRT, meanAcc):
1818
rta = RTAnalysis()
1919
if meanAcc > 0:
2020
rta.fit(test_df.rt, test_df.accuracy)
21-
assert np.allclose(meanRT, rta.meanrt_)
22-
assert np.allclose(meanAcc, rta.meanacc_)
21+
assert np.allclose(meanRT, rta.mean_rt_)
22+
assert np.allclose(meanAcc, rta.mean_accuracy_)
2323
else:
2424
with pytest.raises(ValueError):
2525
rta.fit(test_df.rt, test_df.accuracy)

0 commit comments

Comments
 (0)