Vector of strings need quotes

zeerekahmad · zeerekahmad · commit f01afef986d6 · 2025-08-30T05:42:07.000Z
diff --git a/socketcan_adapter_ros/src/socketcan_bridge_node.cpp b/socketcan_adapter_ros/src/socketcan_bridge_node.cpp
@@ -32,7 +32,7 @@ SocketcanBridgeNode::SocketcanBridgeNode(const rclcpp::NodeOptions & options)
 {
   declare_parameter("can_interface", std::string("can0"));
   declare_parameter("can_error_mask", static_cast<int32_t>(CAN_ERR_MASK));
-  declare_parameter("can_filter_list", std::vector<std::string>{'0:0'});  // vector of strings
+  declare_parameter("can_filter_list", std::vector<std::string>{"0:0"});  // vector of strings
   declare_parameter("join_filters", false);
   declare_parameter("receive_timeout_s", SOCKET_RECEIVE_TIMEOUT_S.count());
 }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ SocketcanBridgeNode::SocketcanBridgeNode(const rclcpp::NodeOptions & options)`
`32`	`32`	`{`
`33`	`33`	`declare_parameter("can_interface", std::string("can0"));`
`34`	`34`	`declare_parameter("can_error_mask", static_cast<int32_t>(CAN_ERR_MASK));`
`35`		`- declare_parameter("can_filter_list", std::vector<std::string>{'0:0'}); // vector of strings`
	`35`	`+ declare_parameter("can_filter_list", std::vector<std::string>{"0:0"}); // vector of strings`
`36`	`36`	`declare_parameter("join_filters", false);`
`37`	`37`	`declare_parameter("receive_timeout_s", SOCKET_RECEIVE_TIMEOUT_S.count());`
`38`	`38`	`}`