Changed data provider methods to static

Author: shudd3r

tests/CompoundFixerTest.php

@@ -27,19 +27,14 @@ protected function setUp(): void
         $this->runner = FixerTestRunner::withConfig($config);
     }
 
-    /**
-     * @dataProvider fileList
-     *
-     * @param string $fileExpected
-     * @param string $fileGiven
-     */
+    /** @dataProvider fileList */
     public function test_FixedFiles_MatchExpectations(string $fileExpected, string $fileGiven)
     {
         $sourceCode = file_get_contents($fileGiven);
         $this->assertSame(file_get_contents($fileExpected), $this->runner->fix($sourceCode));
     }
 
-    public function fileList(): array
+    public static function fileList(): iterable
     {
         $files = [];
         foreach (array_diff(scandir(__DIR__ . '/Fixtures/code-samples/Fixer'), ['..', '.']) as $file) {

tests/Sniffer/Sniffs/PhpDoc/CallableDefinitionSniffTest.php

@@ -17,19 +17,14 @@
 
 class CallableDefinitionSniffTest extends SnifferTest
 {
-    /**
-     * @dataProvider properties
-     *
-     * @param array $properties
-     * @param int[] $expectedWarningLines
-     */
+    /** @dataProvider properties */
     public function test_CallableParamDoc_WithoutDefinition_GivesWarning(array $properties, array $expectedWarningLines)
     {
         $this->setProperties($properties);
         $this->assertWarningLines('./tests/Fixtures/code-samples/Sniffs/PhpDocCallableDefinitions.php', $expectedWarningLines);
     }
 
-    public function properties(): array
+    public static function properties(): iterable
     {
         return [
             [['syntax' => 'both', 'includeClosure' => false], range(15, 18)],

tests/Sniffer/Sniffs/PhpDoc/RequiredForPublicApiSniffTest.php

@@ -17,24 +17,19 @@
 
 class RequiredForPublicApiSniffTest extends SnifferTest
 {
-    /**
-     * @dataProvider classFileWarnings
-     *
-     * @param string $filename
-     * @param array  $warningLines
-     */
+    /** @dataProvider classFileWarnings */
     public function test_Interface_Warnings(string $filename, array $warningLines)
     {
-        $this->assertWarningLines($filename, $warningLines);
+        $this->assertWarningLines('./tests/Fixtures/code-samples/Sniffs/' . $filename, $warningLines);
     }
 
-    public function classFileWarnings(): array
+    public static function classFileWarnings(): iterable
     {
         return [
-            'interface' => ['./tests/Fixtures/code-samples/Sniffs/PhpDocRequiredForInterfaceApi.php', [12]],
-            'class'     => ['./tests/Fixtures/code-samples/Sniffs/PhpDocRequiredForClassApi.php', [14]],
-            'parent'    => ['./tests/Fixtures/code-samples/Sniffs/PhpDocRequiredForParentApi.php', [8]],
-            'invalid'   => ['./tests/Fixtures/code-samples/Sniffs/PhpDocRequiredForInvalidClass.php', [8]]
+            'interface' => ['PhpDocRequiredForInterfaceApi.php', [12]],
+            'class'     => ['PhpDocRequiredForClassApi.php', [14]],
+            'parent'    => ['PhpDocRequiredForParentApi.php', [8]],
+            'invalid'   => ['PhpDocRequiredForInvalidClass.php', [8]]
         ];
     }