Skip to content

Commit 5fb4994

Browse files
cpsievertclaude
andcommitted
ci: simplify back to single test job now that sccache caches C++ on Windows
Remove the build/test split since sccache should make Windows builds fast enough (~5 min) that compiling per Python version is acceptable. The diff from main is now minimal: remove path filters, add MSVC setup + CC/CXX env vars for sccache C++ caching on Windows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent d6b9638 commit 5fb4994

1 file changed

Lines changed: 4 additions & 30 deletions

File tree

.github/workflows/python.yml

Lines changed: 4 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,19 @@ on:
55
pull_request:
66

77
jobs:
8-
build:
8+
test:
99
strategy:
1010
fail-fast: false
1111
matrix:
1212
os: [ubuntu-latest, macos-latest, windows-latest]
13+
python: ['3.10', '3.11', '3.12', '3.13']
1314
runs-on: ${{ matrix.os }}
1415
steps:
1516
- uses: actions/checkout@v4
1617

1718
- uses: actions/setup-python@v5
1819
with:
19-
python-version: '3.10'
20+
python-version: ${{ matrix.python }}
2021

2122
- uses: actions/setup-node@v4
2223
with:
@@ -54,37 +55,10 @@ jobs:
5455
CC: ${{ runner.os == 'Windows' && 'sccache cl' || '' }}
5556
CXX: ${{ runner.os == 'Windows' && 'sccache cl' || '' }}
5657

57-
- name: Upload wheel
58-
uses: actions/upload-artifact@v4
59-
with:
60-
name: wheel-${{ matrix.os }}
61-
path: target/wheels/ggsql-*.whl
62-
63-
test:
64-
needs: build
65-
strategy:
66-
fail-fast: false
67-
matrix:
68-
os: [ubuntu-latest, macos-latest, windows-latest]
69-
python: ['3.10', '3.11', '3.12', '3.13']
70-
runs-on: ${{ matrix.os }}
71-
steps:
72-
- uses: actions/checkout@v4
73-
74-
- uses: actions/setup-python@v5
75-
with:
76-
python-version: ${{ matrix.python }}
77-
78-
- name: Download wheel
79-
uses: actions/download-artifact@v4
80-
with:
81-
name: wheel-${{ matrix.os }}
82-
path: dist
83-
8458
- name: Install wheel and test dependencies
8559
shell: bash
8660
run: |
87-
WHEEL=$(ls dist/ggsql-*.whl)
61+
WHEEL=$(ls target/wheels/ggsql-*.whl)
8862
pip install "${WHEEL}[test]"
8963
9064
- name: Run tests

0 commit comments

Comments
 (0)