Skip to content

Commit f25ec4e

Browse files
cpsievertclaude
andcommitted
fix(python): pass replace as keyword in PyReaderBridge for protocol consistency
The Reader protocol defines replace as a keyword parameter. Make the bridge path match so custom readers aren't required to accept it positionally. Update test custom readers accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent f71dbc2 commit f25ec4e

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

ggsql-python/src/lib.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,13 @@ impl Reader for PyReaderBridge {
166166
Python::attach(|py| {
167167
let py_df =
168168
polars_to_py(py, &df).map_err(|e| GgsqlError::ReaderError(e.to_string()))?;
169+
let kwargs = PyDict::new(py);
170+
kwargs
171+
.set_item("replace", replace)
172+
.map_err(|e| GgsqlError::ReaderError(e.to_string()))?;
169173
self.obj
170174
.bind(py)
171-
.call_method1("register", (name, py_df, replace))
175+
.call_method("register", (name, py_df), Some(&kwargs))
172176
.map_err(|e| GgsqlError::ReaderError(format!("Reader.register() failed: {}", e)))?;
173177
Ok(())
174178
})

ggsql-python/tests/test_ggsql.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ def __init__(self):
402402
def execute_sql(self, sql: str) -> pl.DataFrame:
403403
return self.conn.execute(sql).pl()
404404

405-
def register(self, name: str, df: pl.DataFrame, _replace: bool) -> None:
405+
def register(self, name: str, df: pl.DataFrame, replace: bool = False) -> None:
406406
self.conn.register(name, df)
407407

408408
reader = RegisterReader()
@@ -453,7 +453,7 @@ def __init__(self):
453453
def execute_sql(self, sql: str) -> pl.DataFrame:
454454
return self.conn.execute(sql).pl()
455455

456-
def register(self, name: str, df: pl.DataFrame, _replace: bool) -> None:
456+
def register(self, name: str, df: pl.DataFrame, replace: bool = False) -> None:
457457
self.conn.register(name, df)
458458

459459
reader = DuckDBBackedReader()
@@ -484,7 +484,7 @@ def execute_sql(self, sql: str) -> pl.DataFrame:
484484
self.execute_calls.append(sql)
485485
return self.conn.execute(sql).pl()
486486

487-
def register(self, name: str, df: pl.DataFrame, _replace: bool) -> None:
487+
def register(self, name: str, df: pl.DataFrame, replace: bool = False) -> None:
488488
self.conn.register(name, df)
489489

490490
reader = RecordingReader()

0 commit comments

Comments
 (0)