Skip to content

Update remaining Posit-owned repos for htmltools 0.7.0 Tagified contract #114

@schloerke

Description

@schloerke

Context

PR #106 (issue #105) tightens Tagifiable.tagify()'s return type to Tagified. Four downstream PRs cover the bulk of Posit-owned consumers:

A fresh GitHub code search for def tagify(self) in Posit-owned Python repos surfaced one additional consumer that was missed, plus three latent API-level consumers worth monitoring.

Needs work — has custom .tagify() implementations

posit-dev/shinyreact

9 source files define tagify():

  • pkg-py/src/shinyui/_accordion.py
  • pkg-py/src/shinyui/_accordion_panel.py
  • pkg-py/src/shinyui/_base.py
  • pkg-py/src/shinyui/_card.py
  • pkg-py/src/shinyui/_input_action_button.py
  • pkg-py/src/shinyui/_input_select.py
  • pkg-py/src/shinyui/_input_slider.py
  • pkg-py/src/shinyui/_output_code.py
  • pkg-py/src/shinyui/_output_plot.py

Plus 5 test files exercising the same pattern (pkg-py/tests/shinyui/test_*.py).

Action: add -> Tagified to each .tagify() method (mirroring shinychat / chatlas / brand-yml / py-shiny). Import Tagified under TYPE_CHECKING if htmltools is currently behind a deferred import.

No .tagify(), but consume the htmltools API — monitor only

These three import htmltools symbols but don't implement Tagifiable. They were flagged in .github/workflows/downstream.yaml but kept out of the matrix because the runtime risk is low. No update needed for 0.7.0, but worth a quick smoke check after release:

  • posit-dev/great-tables — imports Tag, div, HTML
  • posit-dev/py-faicons — imports Tag, css, html_escape, tags
  • posit-dev/querychat — imports HTMLDependency, tags

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions