WIP: cascade-order + bslib PR #1308 vendor on top of #2246#2255
Closed
elnelson575 wants to merge 1 commit into
Closed
WIP: cascade-order + bslib PR #1308 vendor on top of #2246#2255elnelson575 wants to merge 1 commit into
elnelson575 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparison-only PR, not for merge. Opened to surface the diff between #2246's vendor and a vendor produced with:
rstudio/bslib@fix/bs5-radio-button-spacing(the doubled-class compound from fix: elevate CSS specificity for BS5 radio/checkbox group label margin rstudio/bslib#1308)scripts/_functions_sass.Rreordered soshiny.scssemits beforethemein the bundle (the change in fix(scripts): Reorder bundle so bslib wins cascade ties against shiny.scss #2254)make upgrade-html-depsre-runThe diff isolates:
_04_rules.scssshiny.scss import position (top of file vs after bslib components)bootstrap.min.cssbyte order of competing rulesbritetheme absence (PR fork point predates the brite upstream add)Once rstudio/bslib#1308 is rebased onto bslib main and #2254 has merged, re-running
make upgrade-html-depsonchore/upgrade-bslib-bootstrap-5.3.8would produce the union of fixes without these gaps. Close after review.