Skip to content

Commit 11d2ada

Browse files
dura0oksnppg
andauthored
Fix trial PGPRO version parse (#379)
* Fix trial PGPRO version parse * export func and bump version --------- Co-authored-by: snppg <s.neretin@postgrespro.ru>
1 parent 6180646 commit 11d2ada

4 files changed

Lines changed: 10 additions & 5 deletions

File tree

src/__init__.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@
4444
bound_ports, \
4545
get_bin_path, \
4646
get_pg_config, \
47-
get_pg_version
47+
get_pg_version, \
48+
parse_pg_version
4849

4950
from .standby import \
5051
First, \
@@ -56,7 +57,7 @@
5657
from testgres.operations.local_ops import LocalOperations
5758
from testgres.operations.remote_ops import RemoteOperations
5859

59-
__version__ = "1.14.3"
60+
__version__ = "1.14.4"
6061

6162
__all__ = [
6263
"get_new_node",
@@ -71,7 +72,7 @@
7172
"NodeApp",
7273
"PostgresNode",
7374
"PortManager",
74-
"reserve_port", "release_port", "bound_ports", "get_bin_path", "get_pg_config", "get_pg_version",
75+
"reserve_port", "release_port", "bound_ports", "get_bin_path", "get_pg_config", "get_pg_version", "parse_pg_version",
7576
"First", "Any",
7677
"OsOperations", "LocalOperations", "RemoteOperations", "ConnectionParams"
7778
]

src/utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,8 @@ def parse_pg_version(version_out):
304304
version = raw_ver.split(' ')[-1] \
305305
.partition('devel')[0] \
306306
.partition('beta')[0] \
307-
.partition('rc')[0]
307+
.partition('rc')[0] \
308+
.partition('-')[0]
308309
return version
309310

310311

tests/test_testgres_common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def test_testgres_version(self):
9696
# Author: Mark G.
9797
assert v.major == 1
9898
assert v.minor == 14
99-
assert v.micro == 3
99+
assert v.micro == 4
100100

101101
assert str(v) == testgres_version
102102
return

tests/test_utils.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ def test_parse_pg_version(self):
3434
assert parse_pg_version("postgres (PostgreSQL) 11.4") == "11.4"
3535
# Macos
3636
assert parse_pg_version("postgres (PostgreSQL) 14.9 (Homebrew)") == "14.9"
37+
# Postgres Pro trial
38+
assert parse_pg_version("postgres (PostgreSQL) 18.4-TRIAL") == "18.4"
39+
assert parse_pg_version("PostgreSQL 18.4-TRIAL") == "18.4"
3740

3841
def test_get_pg_config2(self, os_ops: OsOperations):
3942
assert isinstance(os_ops, OsOperations)

0 commit comments

Comments
 (0)