Use unchanged <img> srcset as <source> srcset

andreyvolokitin · andreyvolokitin · commit cf0ff28d016d · 2020-08-26T23:53:53.000+04:00
To prevent unexpected behaviors transfer `srcset` from &lt;img&gt; to &lt;source&gt; exactly as-is
diff --git a/lib/index.js b/lib/index.js
@@ -76,11 +76,9 @@ function getAmpPicture (imgNode, options) {
 
 function getPicture (imgNode, options) {
   imgNode.skip = true
-
-  var src = imgNode.attrs.src
-  var srcset = (imgNode.attrs.srcset || '')
+  // set <source> `srcset` to <img> `srcset`, if present; otherwise — use <img> `src`
+  var srcset = (imgNode.attrs.srcset || imgNode.attrs.src)
     .split(',')
-    .concat(src)
     .filter(Boolean)
     .map(value => {
       value = value.trim().split(/\s/)
diff --git a/test/fixtures/multisrcset.expected.html b/test/fixtures/multisrcset.expected.html
@@ -1,6 +1,6 @@
 <!doctype html>
 <html>
     <body>
-        <picture><source type="image/webp" srcset="photo-lg.webp 1000w, photo-md.webp 500w, photo-sm.webp 250w, photo.webp"><img srcset="photo-lg.jpg 1000w, photo-md.jpg 500w, photo-sm.jpg 250w" src="photo.png"></picture>
+        <picture><source type="image/webp" srcset="photo-lg.webp 1000w, photo-md.webp 500w, photo-sm.webp 250w, photo.webp"><img srcset="photo-lg.jpg 1000w, photo-md.jpg 500w, photo-sm.jpg 250w, photo.jpg" src="photo.png"></picture>
     </body>
 </html>
diff --git a/test/fixtures/multisrcset.html b/test/fixtures/multisrcset.html
@@ -1,6 +1,6 @@
 <!doctype html>
 <html>
     <body>
-        <img srcset="photo-lg.jpg 1000w, photo-md.jpg 500w, photo-sm.jpg 250w" src="photo.png">
+        <img srcset="photo-lg.jpg 1000w, photo-md.jpg 500w, photo-sm.jpg 250w, photo.jpg" src="photo.png">
     </body>
 </html>
