Commit 0991945
committed
fix: skip bloom filtering when filter_data is empty
The bloom filter POC sends empty filter_data during BloomFilterPush,
intending for data nodes to build filters locally. But get_bloom_filter()
was returning BloomFilter(1) - a filter with 64 bits all set to 0.
Since might_contain() returns false when any bit is 0, this caused ALL
rows to be filtered out during Phase 2 shuffle.
Fix has_bloom_filter() to return false when filter_data is empty,
effectively disabling bloom filtering for the POC. This allows E2E JOIN
tests to pass.1 parent e3ec112 commit 0991945
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| 233 | + | |
233 | 234 | | |
234 | 235 | | |
235 | 236 | | |
236 | | - | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
237 | 243 | | |
238 | 244 | | |
239 | 245 | | |
| |||
0 commit comments