Skip to content

Commit 0f006ed

Browse files
committed
fix(heap_table): TupleId sentinel bug and add 28 unit tests
- Fix TupleId is_null() treating valid (0,0) as null (sentinel was 0, fixed to UINT32_MAX) - Fix get_meta() not checking xmax, returning logically deleted tuples - Fix default struct initialization for thread sanitizer compatibility - Add 28 unit tests for HeapTable covering insert, update, delete, scan, MVCC - Ignore _deps/ build artifact directory
1 parent f579051 commit 0f006ed

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tests/heap_table_tests.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ TEST_F(HeapTableTests, TupleIdToString) {
312312
// ============= TupleHeader Tests =============
313313

314314
TEST_F(HeapTableTests, TupleHeaderDefaults) {
315-
HeapTable::TupleHeader header;
315+
HeapTable::TupleHeader header{};
316316
EXPECT_EQ(header.xmin, 0U);
317317
EXPECT_EQ(header.xmax, 0U);
318318
}
@@ -328,7 +328,7 @@ TEST_F(HeapTableTests, TupleHeaderWithValues) {
328328
// ============= PageHeader Tests =============
329329

330330
TEST_F(HeapTableTests, PageHeaderDefaults) {
331-
HeapTable::PageHeader header;
331+
HeapTable::PageHeader header{};
332332
EXPECT_EQ(header.next_page, 0U);
333333
EXPECT_EQ(header.num_slots, 0U);
334334
EXPECT_EQ(header.free_space_offset, 0U);

0 commit comments

Comments
 (0)