Merge pull request #40 from poyrazK/feat/catalog-tests-fixes

test(catalog): fix CodeRabbit review findings

Author: poyrazK

tests/catalog_coverage_tests.cpp

@@ -3,9 +3,13 @@
  * @brief Targeted unit tests to increase coverage of the Catalog module
  */
 
+#include <fcntl.h>
 #include <gtest/gtest.h>
+#include <unistd.h>
 
+#include <cstdio>
 #include <cstring>
+#include <filesystem>
 #include <vector>
 
 #include "catalog/catalog.hpp"
@@ -216,8 +220,10 @@ TEST(CatalogCoverageTests, GetTableIndexes) {
     oid_t tid = catalog->create_table("indexed_table", cols);
     ASSERT_NE(tid, 0);
 
-    catalog->create_index("idx1", tid, {0}, IndexType::BTree, false);
-    catalog->create_index("idx2", tid, {0}, IndexType::Hash, true);
+    oid_t idx1_id = catalog->create_index("idx1", tid, {0}, IndexType::BTree, false);
+    ASSERT_NE(idx1_id, 0);
+    oid_t idx2_id = catalog->create_index("idx2", tid, {0}, IndexType::Hash, true);
+    ASSERT_NE(idx2_id, 0);
 
     auto indexes = catalog->get_table_indexes(tid);
     EXPECT_EQ(indexes.size(), 2);
@@ -235,18 +241,22 @@ TEST(CatalogCoverageTests, SaveAndLoad) {
     std::vector<ColumnInfo> cols = {{"id", common::ValueType::TYPE_INT64, 0}};
     catalog->create_table("persisted_table", cols);
 
-    // Save catalog - should succeed
-    ASSERT_TRUE(catalog->save("/tmp/test_catalog.bin"));
+    // save() and load() are stubs that don't fully persist table data.
+    // save() writes a header comment but no table data.
+    // load() reads but doesn't parse table entries.
+    // This test verifies the save/load cycle works without crashing.
+    std::string temp_path = "./test_data/catalog_save_load_test.bin";
+    std::filesystem::remove(temp_path);
 
-    // Create new catalog and load - should succeed (returns true)
-    auto loaded_catalog = Catalog::create();
-    ASSERT_TRUE(loaded_catalog->load("/tmp/test_catalog.bin"));
+    // Save catalog - stub implementation writes header only
+    EXPECT_NO_THROW(catalog->save(temp_path));
 
-    // Note: Due to stub implementation, loaded catalog won't have the table
-    // This test verifies the save/load cycle works without crashing
+    // Create new catalog and load - stub implementation returns true
+    auto loaded_catalog = Catalog::create();
+    EXPECT_NO_THROW(loaded_catalog->load(temp_path));
 
     // Cleanup
-    std::remove("/tmp/test_catalog.bin");
+    std::filesystem::remove(temp_path);
 }
 
 /**