ci: fix PR checks to run per-service instead of checking for root pom.xml

All jobs were no-ops because they checked `if [ -f "pom.xml" ]` which
doesn't exist (no root aggregator pom). Now loop through each service.
Removed unused detect-changes job. Added proper job dependencies.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: premtsd-code

.github/workflows/pr-checks.yml

@@ -6,45 +6,9 @@ on:
 
 jobs:
 
-  detect-changes:
-    name: Detect Changed Services
-    runs-on: ubuntu-latest
-    outputs:
-      api-gateway: ${{ steps.changes.outputs.api-gateway }}
-      user-service: ${{ steps.changes.outputs.user-service }}
-      post-service: ${{ steps.changes.outputs.post-service }}
-      connections-service: ${{ steps.changes.outputs.connections-service }}
-      notification-service: ${{ steps.changes.outputs.notification-service }}
-      uploader-service: ${{ steps.changes.outputs.uploader-service }}
-      config-server: ${{ steps.changes.outputs.config-server }}
-      discovery-server: ${{ steps.changes.outputs.discovery-server }}
-    steps:
-      - uses: actions/checkout@v4
-      - uses: dorny/paths-filter@v3
-        id: changes
-        with:
-          filters: |
-            api-gateway:
-              - 'api-gateway/**'
-            user-service:
-              - 'user-service/**'
-            post-service:
-              - 'post-service/**'
-            connections-service:
-              - 'connections-service/**'
-            notification-service:
-              - 'notification-service/**'
-            uploader-service:
-              - 'uploader-service/**'
-            config-server:
-              - 'config-server/**'
-            discovery-server:
-              - 'discovery-server/**'
-
   unit-tests:
     name: Unit Tests
     runs-on: ubuntu-latest
-    continue-on-error: true
     steps:
       - uses: actions/checkout@v4
       - name: Set up JDK 17
@@ -55,23 +19,21 @@ jobs:
           cache: maven
       - name: Run unit tests
         run: |
-          if [ -f "pom.xml" ]; then
-            mvn test -DskipIntegrationTests=true || true
-          else
-            echo "No root pom.xml found — skipping tests"
-          fi
+          for svc in user-service post-service connections-service notification-service uploader-service; do
+            echo "=== Testing $svc ==="
+            cd $svc && mvn test -q && cd ..
+          done
       - name: Upload test results
         uses: actions/upload-artifact@v4
         if: always()
-        continue-on-error: true
         with:
           name: unit-test-results
           path: '**/target/surefire-reports/*.xml'
 
   code-coverage:
     name: Code Coverage
     runs-on: ubuntu-latest
-    continue-on-error: true
+    needs: unit-tests
     steps:
       - uses: actions/checkout@v4
       - name: Set up JDK 17
@@ -82,14 +44,12 @@ jobs:
           cache: maven
       - name: Run tests with coverage
         run: |
-          if [ -f "pom.xml" ]; then
-            mvn verify jacoco:report -DskipIntegrationTests=true || true
-          else
-            echo "No root pom.xml — skipping coverage"
-          fi
+          for svc in user-service post-service connections-service notification-service uploader-service; do
+            echo "=== Coverage for $svc ==="
+            cd $svc && mvn test jacoco:report -q && cd ..
+          done
       - name: Upload coverage report
         uses: actions/upload-artifact@v4
-        continue-on-error: true
         with:
           name: coverage-report
           path: '**/target/site/jacoco/'
@@ -108,18 +68,14 @@ jobs:
           cache: maven
       - name: OWASP Dependency Check
         run: |
-          if [ -f "pom.xml" ]; then
-            mvn dependency-check:check \
-              -DfailBuildOnCVSS=7 \
-              -DskipTestScope=true || true
-          else
-            echo "No root pom.xml — skipping OWASP"
-          fi
-        continue-on-error: true
+          for svc in user-service post-service connections-service notification-service uploader-service; do
+            echo "=== OWASP scan for $svc ==="
+            cd $svc && mvn dependency-check:check -DfailBuildOnCVSS=7 -DskipTestScope=true || true
+            cd ..
+          done
       - name: Upload OWASP report
         uses: actions/upload-artifact@v4
         if: always()
-        continue-on-error: true
         with:
           name: owasp-report
           path: '**/target/dependency-check-report.html'
@@ -130,8 +86,6 @@ jobs:
     continue-on-error: true
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
       - name: Set up JDK 17
         uses: actions/setup-java@v4
         with:
@@ -140,24 +94,23 @@ jobs:
           cache: maven
       - name: Checkstyle
         run: |
-          if [ -f "pom.xml" ]; then
-            mvn checkstyle:check || true
-          else
-            echo "No root pom.xml — skipping checkstyle"
-          fi
-        continue-on-error: true
+          for svc in user-service post-service connections-service notification-service uploader-service; do
+            echo "=== Checkstyle for $svc ==="
+            cd $svc && mvn checkstyle:check -q || true
+            cd ..
+          done
       - name: SpotBugs
         run: |
-          if [ -f "pom.xml" ]; then
-            mvn spotbugs:check || true
-          else
-            echo "No root pom.xml — skipping spotbugs"
-          fi
-        continue-on-error: true
+          for svc in user-service post-service connections-service notification-service uploader-service; do
+            echo "=== SpotBugs for $svc ==="
+            cd $svc && mvn compile spotbugs:check -q || true
+            cd ..
+          done
 
   sonarcloud:
     name: SonarCloud Analysis
     runs-on: ubuntu-latest
+    needs: unit-tests
     continue-on-error: true
     steps:
       - uses: actions/checkout@v4