Update build (GO 1.24)

Author: rstefan1

.golangci.yml

@@ -6,7 +6,7 @@ linters-settings:
   cyclop:
     max-complexity: 10
   govet:
-    check-shadowing: true
+    shadow: true
   lll:
     line-length: 170
     tab-width: 4
@@ -23,10 +23,8 @@ linters:
   # we should re-enable them and make lint pass
   disable:
     - goimports
-    - maligned
     - gochecknoglobals
     - exhaustruct
-    - exhaustivestruct
     - wrapcheck
     - gomoddirectives
     - godox

build/images/build/Dockerfile

@@ -93,8 +93,8 @@ RUN git config --global user.email "bot@presslabs.com" \
 
 # ------------------------------------------------------------------------------------------------
 # Go support
-RUN GO_VERSION=1.22.2 && \
-    GO_HASH=5901c52b7a78002aeff14a21f93e0f064f74ce1360fce51c6ee68cd471216a17 && \
+RUN GO_VERSION=1.24.0 && \
+    GO_HASH=dea9ca38a0b852a74e81c26134671af7c0fbe65d81b0dc1c5bfe22cf7d4c8858 && \
     curl -fsSL https://golang.org/dl/go${GO_VERSION}.linux-amd64.tar.gz -o golang.tar.gz && \
     echo "${GO_HASH}  golang.tar.gz" | sha256sum -c - && \
     tar -C /usr/local -xzf golang.tar.gz && \

build/makelib/golang.mk

@@ -58,7 +58,7 @@ GO_LDFLAGS += -s -w
 endif
 
 # supported go versions
-GO_SUPPORTED_VERSIONS ?= 1.21|1.22
+GO_SUPPORTED_VERSIONS ?= 1.23|1.24
 
 # set GOOS and GOARCH
 GOOS := $(OS)
@@ -72,7 +72,7 @@ GOHOSTARCH := $(HOSTARCH)
 
 GO_PACKAGES := $(foreach t,$(GO_SUBDIRS),$(GO_PROJECT)/$(t)/...)
 GO_TEST_PACKAGES ?= $(shell go list -f '{{ if or .TestGoFiles .XTestGoFiles }}{{ .ImportPath }}{{ end }}' $(foreach t,$(GO_SUBDIRS),$(GO_PROJECT)/$(t)/...))
-GO_INTEGRATION_TEST_PACKAGES ?= $(foreach t,$(GO_INTEGRATION_TESTS_SUBDIRS),$(GO_PROJECT)/$(t)/integration)
+GO_INTEGRATION_TEST_PACKAGES ?= $(foreach t,$(GO_INTEGRATION_TESTS_SUBDIRS),$(GO_PROJECT)/$(t))
 
 ifneq ($(GO_TEST_PARALLEL),)
 GO_TEST_FLAGS += -p $(GO_TEST_PARALLEL)
@@ -200,7 +200,7 @@ DEP_DOWNLOAD_URL ?= https://github.com/golang/dep/releases/download/v$(DEP_VERSI
 $(eval $(call tool.download,dep,$(DEP_VERSION),$(DEP_DOWNLOAD_URL)))
 endif
 
-GOLANGCI_LINT_VERSION ?= 1.55.2
+GOLANGCI_LINT_VERSION ?= 1.64.6
 GOLANGCI_LINT_DOWNLOAD_URL ?= https://github.com/golangci/golangci-lint/releases/download/v$(GOLANGCI_LINT_VERSION)/golangci-lint-$(GOLANGCI_LINT_VERSION)-$(HOSTOS)-$(HOSTARCH).tar.gz
 $(eval $(call tool.download.tar.gz,golangci-lint,$(GOLANGCI_LINT_VERSION),$(GOLANGCI_LINT_DOWNLOAD_URL)))
 
@@ -212,20 +212,20 @@ endif
 
 # we use a consistent version of gofmt even while running different go compilers.
 # see https://github.com/golang/go/issues/26397 for more details
-GOFMT_VERSION ?= 1.22
+GOFMT_VERSION ?= 1.24
 GOFMT_DOWNLOAD_URL ?= https://dl.google.com/go/go$(GOFMT_VERSION).$(HOSTOS)-$(HOSTARCH).tar.gz
 ifneq ($(findstring $(GOFMT_VERSION),$(GO_VERSION)),)
 GOFMT := $(shell which gofmt)
 else
 $(eval $(call tool.download.tar.gz,gofmt,$(GOFMT_VERSION),$(GOFMT_DOWNLOAD_URL),bin/gofmt))
 endif
 
-GOIMPORTS_VERSION ?= v0.20.0
+GOIMPORTS_VERSION ?= v0.30.0
 GOIMPORTS_URL ?= golang.org/x/tools/cmd/goimports
 $(eval $(call tool.go.install,goimports,$(GOIMPORTS_VERSION),$(GOIMPORTS_URL)))
 
 ifeq ($(GO_TEST_TOOL),ginkgo)
-GINKGO_VERSION ?= v2.18.0
+GINKGO_VERSION ?= v2.22.2
 GINKGO_URL ?= github.com/onsi/ginkgo/v2/ginkgo
 $(eval $(call tool.go.install,ginkgo,$(GINKGO_VERSION),$(GINKGO_URL)))
 else # GO_TEST_TOOL != ginkgo

build/makelib/kubebuilder.mk

@@ -49,7 +49,7 @@ KUBEBUILDER_DOWNLOAD_URL ?= https://github.com/kubernetes-sigs/kubebuilder/relea
 $(eval $(call tool.download,kubebuilder,$(KUBEBUILDER_VERSION),$(KUBEBUILDER_DOWNLOAD_URL)))
 
 # controller-gen download and install
-CONTROLLER_GEN_VERSION ?= 0.15.0
+CONTROLLER_GEN_VERSION ?= 0.17.1
 CONTROLLER_GEN_DOWNLOAD_URL ?= sigs.k8s.io/controller-tools/cmd/controller-gen
 $(eval $(call tool.go.install,controller-gen,v$(CONTROLLER_GEN_VERSION),$(CONTROLLER_GEN_DOWNLOAD_URL)))
 

pkg/mergo/transformers/transformers.go

@@ -27,7 +27,7 @@ import (
 )
 
 // TransformerMap is a mergo.Transformers implementation.
-type TransformerMap map[reflect.Type]func(dst, src reflect.Value) error
+type TransformerMap map[reflect.Type]func(dst, src reflect.Value) error //nolint: recvcheck
 
 // PodSpec mergo transformers for corev1.PodSpec.
 var PodSpec TransformerMap
@@ -87,7 +87,7 @@ func (s TransformerMap) Transformer(t reflect.Type) func(dst, src reflect.Value)
 func (s *TransformerMap) mergeByKey(key string, dst, elem reflect.Value, opts ...func(*mergo.Config)) error {
 	elemKey := elem.FieldByName(key)
 
-	for i := 0; i < dst.Len(); i++ {
+	for i := range dst.Len() {
 		dstKey := dst.Index(i).FieldByName(key)
 
 		if elemKey.Kind() != dstKey.Kind() {
@@ -141,7 +141,7 @@ func eq(key string, a, b reflect.Value) bool {
 }
 
 func indexByKey(key string, v reflect.Value, list reflect.Value) (int, bool) {
-	for i := 0; i < list.Len(); i++ {
+	for i := range list.Len() {
 		if eq(key, v, list.Index(i)) {
 			return i, true
 		}
@@ -164,7 +164,7 @@ func (s *TransformerMap) MergeListByKey(key string, opts ...func(*mergo.Config))
 	return func(dst, src reflect.Value) error {
 		entries := reflect.MakeSlice(src.Type(), src.Len(), src.Len())
 
-		for i := 0; i < src.Len(); i++ {
+		for i := range src.Len() {
 			elem := src.Index(i)
 
 			if err := s.mergeByKey(key, dst, elem, opts...); err != nil {
@@ -190,7 +190,7 @@ func (s *TransformerMap) MergeListByKey(key string, opts ...func(*mergo.Config))
 // NilOtherFields nils all fields not defined in src.
 func (s *TransformerMap) NilOtherFields(opts ...func(*mergo.Config)) func(_, _ reflect.Value) error {
 	return func(dst, src reflect.Value) error {
-		for i := 0; i < dst.NumField(); i++ {
+		for i := range dst.NumField() {
 			dstField := dst.Type().Field(i)
 			srcValue := src.FieldByName(dstField.Name)
 			dstValue := dst.FieldByName(dstField.Name)

pkg/syncer/syncer.go

@@ -18,6 +18,7 @@ package syncer
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/iancoleman/strcase"
@@ -36,11 +37,11 @@ const (
 
 var (
 	// ErrOwnerDeleted is returned when the object owner is marked for deletion.
-	ErrOwnerDeleted = fmt.Errorf("owner is deleted")
+	ErrOwnerDeleted = errors.New("owner is deleted")
 
 	// ErrIgnore is returned for ignored errors.
 	// Ignored errors are treated by the syncer as successful syncs.
-	ErrIgnore = fmt.Errorf("ignored error")
+	ErrIgnore = errors.New("ignored error")
 )
 
 // IgnoredError wraps and marks errors as being ignored.
@@ -50,10 +51,10 @@ func IgnoredError(err error) error {
 
 func basicEventReason(objKindName string, err error) string {
 	if err != nil {
-		return fmt.Sprintf("%sSyncFailed", strcase.ToCamel(objKindName))
+		return strcase.ToCamel(objKindName) + "SyncFailed"
 	}
 
-	return fmt.Sprintf("%sSyncSuccessfull", strcase.ToCamel(objKindName))
+	return strcase.ToCamel(objKindName) + "SyncSuccessfull"
 }
 
 // Redacts sensitive data from runtime.Object making them suitable for logging.