Fix linting issues

Author: rstefan1

.golangci.yml

@@ -6,7 +6,7 @@ linters-settings:
   cyclop:
     max-complexity: 10
   govet:
-    check-shadowing: true
+    shadow: true
   lll:
     line-length: 170
     tab-width: 4
@@ -23,10 +23,8 @@ linters:
   # we should re-enable them and make lint pass
   disable:
     - goimports
-    - maligned
     - gochecknoglobals
     - exhaustruct
-    - exhaustivestruct
     - wrapcheck
     - gomoddirectives
     - godox

pkg/mergo/transformers/transformers.go

@@ -27,7 +27,7 @@ import (
 )
 
 // TransformerMap is a mergo.Transformers implementation.
-type TransformerMap map[reflect.Type]func(dst, src reflect.Value) error
+type TransformerMap map[reflect.Type]func(dst, src reflect.Value) error //nolint: recvcheck
 
 // PodSpec mergo transformers for corev1.PodSpec.
 var PodSpec TransformerMap
@@ -87,7 +87,7 @@ func (s TransformerMap) Transformer(t reflect.Type) func(dst, src reflect.Value)
 func (s *TransformerMap) mergeByKey(key string, dst, elem reflect.Value, opts ...func(*mergo.Config)) error {
 	elemKey := elem.FieldByName(key)
 
-	for i := 0; i < dst.Len(); i++ {
+	for i := range dst.Len() {
 		dstKey := dst.Index(i).FieldByName(key)
 
 		if elemKey.Kind() != dstKey.Kind() {
@@ -141,7 +141,7 @@ func eq(key string, a, b reflect.Value) bool {
 }
 
 func indexByKey(key string, v reflect.Value, list reflect.Value) (int, bool) {
-	for i := 0; i < list.Len(); i++ {
+	for i := range list.Len() {
 		if eq(key, v, list.Index(i)) {
 			return i, true
 		}
@@ -164,7 +164,7 @@ func (s *TransformerMap) MergeListByKey(key string, opts ...func(*mergo.Config))
 	return func(dst, src reflect.Value) error {
 		entries := reflect.MakeSlice(src.Type(), src.Len(), src.Len())
 
-		for i := 0; i < src.Len(); i++ {
+		for i := range src.Len() {
 			elem := src.Index(i)
 
 			if err := s.mergeByKey(key, dst, elem, opts...); err != nil {
@@ -190,7 +190,7 @@ func (s *TransformerMap) MergeListByKey(key string, opts ...func(*mergo.Config))
 // NilOtherFields nils all fields not defined in src.
 func (s *TransformerMap) NilOtherFields(opts ...func(*mergo.Config)) func(_, _ reflect.Value) error {
 	return func(dst, src reflect.Value) error {
-		for i := 0; i < dst.NumField(); i++ {
+		for i := range dst.NumField() {
 			dstField := dst.Type().Field(i)
 			srcValue := src.FieldByName(dstField.Name)
 			dstValue := dst.FieldByName(dstField.Name)

pkg/syncer/syncer.go

@@ -18,6 +18,7 @@ package syncer
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/iancoleman/strcase"
@@ -36,11 +37,11 @@ const (
 
 var (
 	// ErrOwnerDeleted is returned when the object owner is marked for deletion.
-	ErrOwnerDeleted = fmt.Errorf("owner is deleted")
+	ErrOwnerDeleted = errors.New("owner is deleted")
 
 	// ErrIgnore is returned for ignored errors.
 	// Ignored errors are treated by the syncer as successful syncs.
-	ErrIgnore = fmt.Errorf("ignored error")
+	ErrIgnore = errors.New("ignored error")
 )
 
 // IgnoredError wraps and marks errors as being ignored.
@@ -50,10 +51,10 @@ func IgnoredError(err error) error {
 
 func basicEventReason(objKindName string, err error) string {
 	if err != nil {
-		return fmt.Sprintf("%sSyncFailed", strcase.ToCamel(objKindName))
+		return strcase.ToCamel(objKindName) + "SyncFailed"
 	}
 
-	return fmt.Sprintf("%sSyncSuccessfull", strcase.ToCamel(objKindName))
+	return strcase.ToCamel(objKindName) + "SyncSuccessfull"
 }
 
 // Redacts sensitive data from runtime.Object making them suitable for logging.