feat: smart contract updates (#279)

* chore: added transfer in case 2 spend

* feat: added waiting for 24 to withdraw for provider

* chore: send funds directly to bidder instead of map

* fix: added check for storing commitment

* chore: added tests for edge cases

* chore: generated abi

* docs(infra): update README.md (#281)

* fix: fixed pr comments

* fix: fixed abi

* fix: changed compare

* fix: fixed order

* chore: added protocol fee amount

* fix: added comma

* fix: updated abi

* fix: fixed withdrawal delay

* fix: returned comment

* fix: returned back the comment

* fix: updated comment

* fix: updated comment

* fix: optimized require

* fix: changed comment

* fix: comment

* fix: fixed another comment

* fix: fixed seconds to milliseconds

* fix: fixed test

Author: Mikelle

contracts-abi/abi/ProviderRegistry.abi

@@ -58,51 +58,6 @@
     "outputs": [],
     "stateMutability": "nonpayable"
   },
-  {
-    "type": "function",
-    "name": "bidderAmount",
-    "inputs": [
-      {
-        "name": "",
-        "type": "address",
-        "internalType": "address"
-      }
-    ],
-    "outputs": [
-      {
-        "name": "",
-        "type": "uint256",
-        "internalType": "uint256"
-      }
-    ],
-    "stateMutability": "view"
-  },
-  {
-    "type": "function",
-    "name": "checkStake",
-    "inputs": [
-      {
-        "name": "provider",
-        "type": "address",
-        "internalType": "address"
-      }
-    ],
-    "outputs": [
-      {
-        "name": "",
-        "type": "uint256",
-        "internalType": "uint256"
-      }
-    ],
-    "stateMutability": "view"
-  },
-  {
-    "type": "function",
-    "name": "depositFunds",
-    "inputs": [],
-    "outputs": [],
-    "stateMutability": "payable"
-  },
   {
     "type": "function",
     "name": "eoaToBlsPubkey",
@@ -180,6 +135,25 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "getProviderStake",
+    "inputs": [
+      {
+        "name": "provider",
+        "type": "address",
+        "internalType": "address"
+      }
+    ],
+    "outputs": [
+      {
+        "name": "",
+        "type": "uint256",
+        "internalType": "uint256"
+      }
+    ],
+    "stateMutability": "view"
+  },
   {
     "type": "function",
     "name": "initialize",
@@ -203,11 +177,29 @@
         "name": "_owner",
         "type": "address",
         "internalType": "address"
+      },
+      {
+        "name": "_withdrawalDelay",
+        "type": "uint256",
+        "internalType": "uint256"
       }
     ],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
+  {
+    "type": "function",
+    "name": "isProviderValid",
+    "inputs": [
+      {
+        "name": "provider",
+        "type": "address",
+        "internalType": "address"
+      }
+    ],
+    "outputs": [],
+    "stateMutability": "view"
+  },
   {
     "type": "function",
     "name": "minStake",
@@ -260,6 +252,19 @@
     ],
     "stateMutability": "view"
   },
+  {
+    "type": "function",
+    "name": "protocolFeeAmount",
+    "inputs": [],
+    "outputs": [
+      {
+        "name": "",
+        "type": "uint256",
+        "internalType": "uint256"
+      }
+    ],
+    "stateMutability": "view"
+  },
   {
     "type": "function",
     "name": "providerRegistered",
@@ -370,6 +375,19 @@
     "outputs": [],
     "stateMutability": "nonpayable"
   },
+  {
+    "type": "function",
+    "name": "setWithdrawalDelay",
+    "inputs": [
+      {
+        "name": "_withdrawalDelay",
+        "type": "uint256",
+        "internalType": "uint256"
+      }
+    ],
+    "outputs": [],
+    "stateMutability": "nonpayable"
+  },
   {
     "type": "function",
     "name": "slash",
@@ -398,6 +416,13 @@
     "outputs": [],
     "stateMutability": "nonpayable"
   },
+  {
+    "type": "function",
+    "name": "stake",
+    "inputs": [],
+    "outputs": [],
+    "stateMutability": "payable"
+  },
   {
     "type": "function",
     "name": "transferOwnership",
@@ -411,6 +436,13 @@
     "outputs": [],
     "stateMutability": "nonpayable"
   },
+  {
+    "type": "function",
+    "name": "unstake",
+    "inputs": [],
+    "outputs": [],
+    "stateMutability": "nonpayable"
+  },
   {
     "type": "function",
     "name": "upgradeToAndCall",
@@ -431,14 +463,8 @@
   },
   {
     "type": "function",
-    "name": "withdrawBidderAmount",
-    "inputs": [
-      {
-        "name": "bidder",
-        "type": "address",
-        "internalType": "address"
-      }
-    ],
+    "name": "withdraw",
+    "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
@@ -451,17 +477,49 @@
   },
   {
     "type": "function",
-    "name": "withdrawStakedAmount",
+    "name": "withdrawProtocolFee",
     "inputs": [
       {
-        "name": "provider",
+        "name": "treasuryAddress",
         "type": "address",
         "internalType": "address payable"
       }
     ],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
+  {
+    "type": "function",
+    "name": "withdrawalDelay",
+    "inputs": [],
+    "outputs": [
+      {
+        "name": "",
+        "type": "uint256",
+        "internalType": "uint256"
+      }
+    ],
+    "stateMutability": "view"
+  },
+  {
+    "type": "function",
+    "name": "withdrawalRequests",
+    "inputs": [
+      {
+        "name": "",
+        "type": "address",
+        "internalType": "address"
+      }
+    ],
+    "outputs": [
+      {
+        "name": "",
+        "type": "uint256",
+        "internalType": "uint256"
+      }
+    ],
+    "stateMutability": "view"
+  },
   {
     "type": "event",
     "name": "FundsDeposited",
@@ -576,6 +634,25 @@
     ],
     "anonymous": false
   },
+  {
+    "type": "event",
+    "name": "Unstake",
+    "inputs": [
+      {
+        "name": "provider",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      },
+      {
+        "name": "timestamp",
+        "type": "uint256",
+        "indexed": false,
+        "internalType": "uint256"
+      }
+    ],
+    "anonymous": false
+  },
   {
     "type": "event",
     "name": "Upgraded",
@@ -589,6 +666,38 @@
     ],
     "anonymous": false
   },
+  {
+    "type": "event",
+    "name": "Withdraw",
+    "inputs": [
+      {
+        "name": "provider",
+        "type": "address",
+        "indexed": true,
+        "internalType": "address"
+      },
+      {
+        "name": "amount",
+        "type": "uint256",
+        "indexed": false,
+        "internalType": "uint256"
+      }
+    ],
+    "anonymous": false
+  },
+  {
+    "type": "event",
+    "name": "WithdrawalDelayUpdated",
+    "inputs": [
+      {
+        "name": "newWithdrawalDelay",
+        "type": "uint256",
+        "indexed": false,
+        "internalType": "uint256"
+      }
+    ],
+    "anonymous": false
+  },
   {
     "type": "error",
     "name": "AddressEmptyCode",

contracts-abi/clients/ProviderRegistry/ProviderRegistry.go

@@ -356,7 +356,9 @@ contract BidderRegistry is
 
         // Check if bid exceeds the available amount for the block
         if (availableAmount < bid) {
-            // todo: burn it, until oracle will do the calculation and transfers
+            (bool success, ) = payable(bidder).call{value: bid - availableAmount}("");
+            require(success, "couldn't transfer to bidder");
+
             bid = uint64(availableAmount);
         }
 

contracts/contracts/BidderRegistry.sol

@@ -326,6 +326,9 @@ contract PreConfCommitmentStore is IPreConfCommitmentStore, Ownable2StepUpgradea
             "sender is not commiter"
         );
 
+        // Ensure the provider's balance is greater than minStake and no pending withdrawal
+        providerRegistry.isProviderValid(commiterAddress);
+        
         EncrPreConfCommitment memory newCommitment = EncrPreConfCommitment(
             false,
             commiterAddress,