Skip to content

Commit 50b3fe8

Browse files
committed
fix: remove MSI target and simplify CI env vars for packaging
1 parent 9cb172e commit 50b3fe8

2 files changed

Lines changed: 3 additions & 14 deletions

File tree

.github/workflows/desktop-release.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -114,13 +114,6 @@ jobs:
114114
run: npx electron-builder --${{ matrix.platform }} --${{ matrix.arch }} --publish never
115115
env:
116116
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
117-
# macOS signing
118-
APPLE_ID: ${{ secrets.APPLE_ID }}
119-
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
120-
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
121-
# Windows signing
122-
CSC_LINK: ${{ secrets.WINDOWS_CERTIFICATE }}
123-
CSC_KEY_PASSWORD: ${{ secrets.WINDOWS_CERTIFICATE_PASSWORD }}
124117

125118
- name: Upload artifacts
126119
uses: actions/upload-artifact@v4
@@ -129,7 +122,6 @@ jobs:
129122
path: |
130123
apps/desktop/out/*.dmg
131124
apps/desktop/out/*.zip
132-
apps/desktop/out/*.msi
133125
apps/desktop/out/*.exe
134126
apps/desktop/out/*.AppImage
135127
apps/desktop/out/*.deb

apps/desktop/electron-builder.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ directories:
99
files:
1010
- dist/**/*
1111
- resources/**/*
12-
- "!**/*.map"
13-
- "!**/node_modules/**/{CHANGELOG.md,README.md,LICENSE*}"
12+
- '!**/*.map'
13+
- '!**/node_modules/**/{CHANGELOG.md,README.md,LICENSE*}'
1414

1515
asar: true
1616
asarUnpack:
17-
- "**/*.node"
17+
- '**/*.node'
1818

1919
mac:
2020
category: public.app-category.productivity
@@ -38,9 +38,6 @@ win:
3838
arch:
3939
- x64
4040
- arm64
41-
- target: msi
42-
arch:
43-
- x64
4441
signingHashAlgorithms:
4542
- sha256
4643

0 commit comments

Comments
 (0)