note gcc bug 118291 at pass-self lambda sites; drop obsolete #define filter in grep check

Author: Cameron Custer

library/trees/hld.hpp

@@ -14,6 +14,7 @@ template<bool VALS_EDGES> struct HLD {
   int n;
   vi p, siz, rt, tin;
   HLD(auto& g): n(sz(g)), p(n), siz(n, 1), rt(n), tin(n) {
+    // pass-self, not deducing this: gcc bug 118291
     auto dfs1 = [&](auto dfs1, int u) -> void {
       for (int& v : g[u]) {
         erase(g[v], p[v] = u);

library/trees/lca_rmq.hpp

@@ -16,6 +16,7 @@ struct LCA {
   LCA(const auto& g):
     n(sz(g)), tin(n), siz(n, 1), d(n), p(n) {
     vi order;
+    // pass-self, not deducing this: gcc bug 118291
     auto dfs = [&](auto&& dfs, int u) -> void {
       tin[u] = sz(order), order.push_back(u);
       for (int v : g[u])

library/trees/linear_lca.hpp

@@ -13,6 +13,7 @@ struct linear_lca {
   linear_lca(const auto& g):
     n(sz(g)), d(n), in(n), asc(n), head(n + 1) {
     vector<pii> order;
+    // pass-self, not deducing this: gcc bug 118291
     auto dfs = [&](auto&& dfs, int u, int p) -> void {
       order.emplace_back(u, p), in[u] = sz(order);
       for (int v : g[u])

library/trees/tree_lift.hpp

@@ -11,6 +11,7 @@
 struct tree_lift {
   vi d, p, j;
   tree_lift(const auto& g): d(sz(g)), p(d), j(d) {
+    // pass-self, not deducing this: gcc bug 118291
     auto dfs = [&](auto&& dfs, int u) -> void {
       int up = d[u] + d[j[j[u]]] == 2 * d[j[u]] ? j[j[u]]
                                                 : u;

library/trees/uncommon/hagerup_kth_par.hpp

@@ -21,6 +21,7 @@ template<int K = 2> struct hagerup {
       jmp[t] = st[max(0, s - K * (t & -t))];
       t++;
     };
+    // pass-self, not deducing this: gcc bug 118291
     auto dfs = [&](auto&& dfs, int u, int p) -> void {
       int& l = leaf[u] = st[d[u]] = u;
       pos[u] = t;

library/trees/uncommon/ladder_decomposition.hpp

@@ -20,6 +20,7 @@ struct ladder {
     n(sz(g)), d(n), p(n), idx(n), lad(2 * n) {
     int i = 0;
     vi st(n);
+    // pass-self, not deducing this: gcc bug 118291
     auto dfs = [&](auto&& dfs, int u) -> vi {
       vi path;
       st[d[u]] = u;

library/trees/uncommon/linear_kth_par.hpp

@@ -23,6 +23,7 @@ struct linear_kth_par {
         jmp[t] += st[du - k];
       d_tour[t++] = du;
     };
+    // pass-self, not deducing this: gcc bug 118291
     auto dfs = [&](auto&& dfs, int u, int p) -> vi {
       vi path;
       tin[st[d[u]] = u] = t;

tests/scripts/grep_clangformat_cppcheck.sh

@@ -27,9 +27,7 @@ echo "check vi instead of vector<int>"
 grep "vector<int>" --recursive ../library/**/*.hpp && exit 1
 
 echo "check begin(arr) instead of arr.begin(), similarly for end, rbegin, rend, empty, size:"
-# TODO: remove this define filter if/when we move to -std=c++20
-grep --invert-match --fixed-strings "#define" --recursive ../library/ library_checker_aizu_tests/ |
-	grep --fixed-strings --regexp=".begin()" --regexp=".rbegin()" --regexp=".end()" --regexp=".rend()" --regexp=".empty()" --regexp=".size()" && exit 1
+grep --recursive ../library/ library_checker_aizu_tests/ --fixed-strings --regexp=".begin()" --regexp=".rbegin()" --regexp=".end()" --regexp=".rend()" --regexp=".empty()" --regexp=".size()" && exit 1
 
 echo "check that there are no empty lines"
 grep "^$" ../library/**/*.hpp && exit 1