revert subrange-returning ranges algos (unique/remove_if/partition) to iterator form; drop cppcheck suppression

Author: Cameron Custer

library/data_structures_[l,r)/uncommon/priority_queue_of_updates.hpp

@@ -38,10 +38,9 @@ template<class DS, class... ARGS> struct pq_updates {
       extra.push_back(upd_st[idx_sk]);
       idx = min(idx, idx_sk), lowest_pri = pri;
     }
-    auto it = begin(ranges::remove_if(
-      upd_st | views::drop(idx), [&](auto& cur) {
-        return cur.second->first >= lowest_pri;
-      }));
+    auto it = remove_if(idx + all(upd_st), [&](auto& cur) {
+      return cur.second->first >= lowest_pri;
+    });
     ranges::reverse_copy(extra, it);
     rep(i, idx, sz(upd_st)) ds.undo();
     upd_st.pop_back();

library/graphs/strongly_connected_components/offline_incremental_scc.hpp

@@ -33,10 +33,9 @@ vi offline_incremental_scc(vector<array<int, 2>> eds,
     }
     rep(i, 0, sz(g)) ids[vs[i]] = -1;
     scc_id = scc(g).second;
-    auto split = begin(ranges::partition(
-      ranges::subrange(el, er), [&](int i) {
-        return scc_id[eds[i][0]] == scc_id[eds[i][1]];
-      }));
+    auto split = partition(el, er, [&](int i) {
+      return scc_id[eds[i][0]] == scc_id[eds[i][1]];
+    });
     for (auto it = el; it != split; it++) joins[*it] = mid;
     if (tr - tl == 1) return;
     for (auto it = split; it != er; it++) {

library/trees/edge_cd.hpp

@@ -28,10 +28,10 @@ template<class G> void edge_cd(vector<G>& g, auto f) {
     if (m < 2) return;
     u = ctd(ctd, u, u, m);
     int sum = 0;
-    auto it = begin(ranges::partition(g[u], [&](int v) {
+    auto it = partition(all(g[u]), [&](int v) {
       ll x = sum + s[v];
       return x * x < m * (m - x) ? sum = x : 0;
-    }));
+    });
     f(u, it - begin(g[u]));
     G oth(it, end(g[u]));
     g[u].erase(it, end(g[u]));

library/trees/extra_members/virtual_tree.hpp

@@ -16,7 +16,7 @@ array<vi, 2> compress_tree(vi subset) {
   rep(i, 1, len)
     subset.push_back(lca(subset[i - 1], subset[i]));
   ranges::sort(subset, {}, proj);
-  subset.erase(begin(ranges::unique(subset)), end(subset));
+  subset.erase(unique(all(subset)), end(subset));
   return {
     mono_st(subset,
       [&](int u, int v) { return in_subtree(u, v); }),

tests/.config/.cppcheck_suppression_list

@@ -60,6 +60,5 @@ unusedFunction:../kactl/content/data-structures/UnionFind.h:14
 unusedFunction:../kactl/content/number-theory/ModPow.h:13
 unusedFunction:../kactl/stress-tests/utilities/genTree.h:49
 containerOutOfBounds:../library/data_structures_[l,r)/uncommon/permutation_tree.hpp:85
-mismatchingContainerExpression:../library/trees/extra_members/virtual_tree.hpp:19
 ctuOneDefinitionRuleViolation:../library/data_structures_[l,r)/bit.hpp:15
 ctuOneDefinitionRuleViolation:../library/data_structures_[l,r)/lazy_seg_tree.hpp:4