Skip to content

Commit 6030b97

Browse files
committed
Upgrade Helm to v4
Import changes: - Removed "helm.sh/helm/v3/pkg/release" and "helm.sh/helm/v4/pkg/chart/v2/util" - Added chartbase "helm.sh/helm/v4/pkg/chart", "helm.sh/helm/v4/pkg/kube", releasecommon "helm.sh/helm/v4/pkg/release/common", releasev1 "helm.sh/helm/v4/pkg/release/v1" API changes fixed: 1. util.CoalesceValues — removed (unused placeholder) 2. *release.Release → *releasev1.Release everywhere 3. Releaser interface returns → added (*releasev1.Release) type assertions in installRelease, upgradeRelease, getCurrentRelease, recoverRelease, and two statusObject.Run() call sites 4. action.CheckDependencies — converted []*chart.Dependency to []chartbase.Dependency slice at both call sites 5. chart.File → common.File in upgradeCRDsInFile 6. chart.CRD.Data → chart.CRD.File (with the file carrying the data) 7. actionConfig.Init(...) — removed the 4th debugLog argument; removed the now-unused debugLog function 8. release.Status* → releasecommon.Status*, release.Hook* → releasev1.Hook* 9. lastDeployed.Time → lastDeployed (v4 Info.LastDeployed is already time.Time) 10. installClient.Wait/Atomic/DryRun/ClientOnly/InsecureSkipTLSverify → WaitStrategy/RollbackOnFailure/DryRunStrategy/InsecureSkipTLSVerify 11. upgradeClient.Wait/Atomic/Force/Recreate/InsecureSkipTLSverify → WaitStrategy/RollbackOnFailure/ForceReplace/[removed]/InsecureSkipTLSVerify 12. uninstallClient.Wait → WaitStrategy 13. repo.Entry.InsecureSkipTLSverify → InsecureSkipTLSVerify
1 parent 29ce199 commit 6030b97

11 files changed

Lines changed: 456 additions & 370 deletions

api/v1beta1/spec.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,9 @@ type HelmUpgradeOptions struct {
290290

291291
// Recreate will (if true) recreate pods after a rollback.
292292
// +kubebuilder:default:=false
293+
//
294+
// Deprecated: This field is no longer supported
295+
//
293296
// +optional
294297
Recreate bool `json:"recreate,omitempty"`
295298

api/v1beta1/zz_generated.deepcopy.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/config.projectsveltos.io_clusterprofiles.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -412,8 +412,10 @@ spec:
412412
type: integer
413413
recreate:
414414
default: false
415-
description: Recreate will (if true) recreate pods after
416-
a rollback.
415+
description: |-
416+
Recreate will (if true) recreate pods after a rollback.
417+
418+
Deprecated: This field is no longer supported
417419
type: boolean
418420
resetThenReuseValues:
419421
default: false

config/crd/bases/config.projectsveltos.io_clusterpromotions.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,8 +312,10 @@ spec:
312312
type: integer
313313
recreate:
314314
default: false
315-
description: Recreate will (if true) recreate pods
316-
after a rollback.
315+
description: |-
316+
Recreate will (if true) recreate pods after a rollback.
317+
318+
Deprecated: This field is no longer supported
317319
type: boolean
318320
resetThenReuseValues:
319321
default: false

config/crd/bases/config.projectsveltos.io_clustersummaries.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,8 +449,10 @@ spec:
449449
type: integer
450450
recreate:
451451
default: false
452-
description: Recreate will (if true) recreate pods
453-
after a rollback.
452+
description: |-
453+
Recreate will (if true) recreate pods after a rollback.
454+
455+
Deprecated: This field is no longer supported
454456
type: boolean
455457
resetThenReuseValues:
456458
default: false

config/crd/bases/config.projectsveltos.io_profiles.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -412,8 +412,10 @@ spec:
412412
type: integer
413413
recreate:
414414
default: false
415-
description: Recreate will (if true) recreate pods after
416-
a rollback.
415+
description: |-
416+
Recreate will (if true) recreate pods after a rollback.
417+
418+
Deprecated: This field is no longer supported
417419
type: boolean
418420
resetThenReuseValues:
419421
default: false

0 commit comments

Comments
 (0)