Remove @SuppressFBWarnings annotations and fix typo in package name

Author: rubengees

build.gradle

@@ -11,7 +11,7 @@ buildscript {
         freefairPluginsVersion = '1.0.0'
 
         lombokVersion = '1.16.18'
-        findbugsVersion = '3.0.1'
+        jsr305Version = '3.0.2'
 
         retrofitVersion = '2.3.0'
         okHttpVersion = '3.8.1'
@@ -24,7 +24,7 @@ buildscript {
         deps = [
                 errorprone        : "com.google.errorprone:error_prone_core:$errorproneVersion",
                 lombok            : "org.projectlombok:lombok:$lombokVersion",
-                findbugs          : "com.google.code.findbugs:annotations:$findbugsVersion",
+                jsr305            : "com.google.code.findbugs:jsr305:$jsr305Version",
 
                 retrofit          : "com.squareup.retrofit2:retrofit:$retrofitVersion",
                 retrofitMoshi     : "com.squareup.retrofit2:converter-moshi:$retrofitVersion",

library/build.gradle

@@ -26,15 +26,15 @@ dependencies {
     errorprone deps.errorprone
 
     compileOnly deps.lombok
-    compileOnly deps.findbugs
+    compileOnly deps.jsr305
 
     api deps.retrofit
     api deps.retrofitMoshi
     api deps.okHttp
     api deps.moshi
 
     testCompileOnly deps.lombok
-    testCompileOnly deps.findbugs
+    testCompileOnly deps.jsr305
 
     testImplementation deps.junit
     testImplementation deps.assertj
@@ -120,9 +120,9 @@ task javadocJar(type: Jar, dependsOn: javadoc) {
     from javadoc.destinationDir
 }
 
-//compileJava {
-//    options.compilerArgs << "-Werror"
-//}
+compileJava {
+    options.compilerArgs << "-Werror"
+}
 
 buildConfig {
     packageName = 'me.proxer.library'
@@ -147,6 +147,7 @@ jacocoTestReport {
 
 findbugs {
     sourceSets = [sourceSets.main]
+    excludeFilter = file('config/findbugs/findbugs-filter.xml')
 }
 
 tasks.withType(FindBugs) {

library/config/findbugs/findbugs-filter.xml

@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<FindBugsFilter>
+
+    <!-- Suppress internal exposal of Lombok constructors. -->
+    <Match>
+        <Package name="~me\.proxer\.library\.entity.*"/>
+        <Method name="&lt;init&gt;"/>
+        <Bug pattern="EI_EXPOSE_REP2"/>
+    </Match>
+
+    <!-- Suppress internal exposal of Lombok getters returning Date. -->
+    <Match>
+        <Package name="~me\.proxer\.library\.entity.*"/>
+        <Method returns="java.util.Date"/>
+        <Bug pattern="EI_EXPOSE_REP"/>
+    </Match>
+
+    <!-- Suppress Lombok generated equals and hashcode methods. -->
+    <Match>
+        <Or>
+            <Package name="~me\.proxer\.library\.entity.*"/>
+            <Class name="me.proxer.library.api.ProxerResponse"/>
+        </Or>
+        <Or>
+            <Method name="equals" returns="boolean" params="java.lang.Object"/>
+            <Method name="hashCode" returns="int" params=""/>
+        </Or>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
+    </Match>
+
+</FindBugsFilter>

library/lombok.config

@@ -1,3 +1,2 @@
 lombok.anyConstructor.suppressConstructorProperties = true
-lombok.extern.findbugs.addSuppressFBWarnings = true
 lombok.addGeneratedAnnotation = false

library/src/main/java/me/proxer/library/api/ConferenceAdapter.java

@@ -4,7 +4,7 @@
 import com.squareup.moshi.Json;
 import lombok.AccessLevel;
 import lombok.Getter;
-import me.proxer.library.entitiy.messenger.Conference;
+import me.proxer.library.entity.messenger.Conference;
 
 import java.util.Date;
 

library/src/main/java/me/proxer/library/api/ConferenceInfoAdapter.java

@@ -2,8 +2,8 @@
 
 import com.squareup.moshi.FromJson;
 import com.squareup.moshi.Json;
-import me.proxer.library.entitiy.messenger.ConferenceInfo;
-import me.proxer.library.entitiy.messenger.ConferenceParticipant;
+import me.proxer.library.entity.messenger.ConferenceInfo;
+import me.proxer.library.entity.messenger.ConferenceParticipant;
 
 import java.util.Date;
 import java.util.List;

library/src/main/java/me/proxer/library/api/EpisodeInfoAdapter.java

@@ -4,10 +4,10 @@
 import com.squareup.moshi.Json;
 import com.squareup.moshi.ToJson;
 import me.proxer.library.api.EpisodeInfoAdapter.IntermediateEpisodeInfo.IntermediateEpisode;
-import me.proxer.library.entitiy.info.AnimeEpisode;
-import me.proxer.library.entitiy.info.Episode;
-import me.proxer.library.entitiy.info.EpisodeInfo;
-import me.proxer.library.entitiy.info.MangaEpisode;
+import me.proxer.library.entity.info.AnimeEpisode;
+import me.proxer.library.entity.info.Episode;
+import me.proxer.library.entity.info.EpisodeInfo;
+import me.proxer.library.entity.info.MangaEpisode;
 import me.proxer.library.enums.Category;
 import me.proxer.library.enums.MediaLanguage;
 

library/src/main/java/me/proxer/library/api/FixRatingDetailsAdapter.java

@@ -3,7 +3,7 @@
 import com.squareup.moshi.FromJson;
 import com.squareup.moshi.JsonAdapter;
 import com.squareup.moshi.Moshi;
-import me.proxer.library.entitiy.info.RatingDetails;
+import me.proxer.library.entity.info.RatingDetails;
 
 import javax.annotation.Nullable;
 import java.io.IOException;

library/src/main/java/me/proxer/library/api/NotificationAdapter.java

@@ -2,7 +2,7 @@
 
 import com.squareup.moshi.FromJson;
 import com.squareup.moshi.Json;
-import me.proxer.library.entitiy.notifications.Notification;
+import me.proxer.library.entity.notifications.Notification;
 import me.proxer.library.enums.NotificationType;
 import me.proxer.library.util.ProxerUrls;
 import okhttp3.HttpUrl;

library/src/main/java/me/proxer/library/api/NotificationInfoAdapter.java

@@ -2,7 +2,7 @@
 
 import com.squareup.moshi.FromJson;
 import com.squareup.moshi.JsonDataException;
-import me.proxer.library.entitiy.notifications.NotificationInfo;
+import me.proxer.library.entity.notifications.NotificationInfo;
 
 /**
  * @author Ruben Gees