Skip to content

Commit 5638868

Browse files
committed
Remove unneeded constructors and getters; Return VoidResult directly
1 parent f186a8f commit 5638868

7 files changed

Lines changed: 7 additions & 118 deletions

File tree

library/src/main/java/com/proxerme/library/connection/messenger/request/SetBlockRequest.java

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,6 @@ public class SetBlockRequest extends ProxerRequest<VoidResult> {
2222

2323
private String conferenceId;
2424

25-
26-
/**
27-
* Package constructor.
28-
*/
29-
SetBlockRequest() {
30-
}
31-
3225
/**
3326
* The constructor.
3427
*
@@ -38,24 +31,14 @@ public SetBlockRequest(@NonNull String conferenceId) {
3831
this.conferenceId = conferenceId;
3932
}
4033

41-
/**
42-
* Returns the id of the conference.
43-
*
44-
* @return The conference id.
45-
*/
46-
@NonNull
47-
public String getConferenceId() {
48-
return conferenceId;
49-
}
50-
5134
@Override
5235
protected int getTag() {
5336
return ProxerTag.MESSENGER_SET_BLOCK;
5437
}
5538

5639
@Override
5740
protected VoidResult parse(@NonNull Response response) throws Exception {
58-
return response.asClass(VoidResult.class);
41+
return new VoidResult();
5942
}
6043

6144
@NonNull

library/src/main/java/com/proxerme/library/connection/messenger/request/SetFavourRequest.java

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,6 @@ public class SetFavourRequest extends ProxerRequest<VoidResult> {
2222

2323
private String conferenceId;
2424

25-
26-
/**
27-
* Package constructor.
28-
*/
29-
SetFavourRequest() {
30-
}
31-
3225
/**
3326
* The constructor.
3427
*
@@ -38,27 +31,16 @@ public SetFavourRequest(@NonNull String conferenceId) {
3831
this.conferenceId = conferenceId;
3932
}
4033

41-
/**
42-
* Returns the id of the conference.
43-
*
44-
* @return The conference id.
45-
*/
46-
@NonNull
47-
public String getConferenceId() {
48-
return conferenceId;
49-
}
50-
5134
@Override
5235
protected int getTag() {
5336
return ProxerTag.MESSENGER_SET_UNFAVOUR;
5437
}
5538

5639
@Override
5740
protected VoidResult parse(@NonNull Response response) throws Exception {
58-
return null;
41+
return new VoidResult();
5942
}
6043

61-
6244
@NonNull
6345
@Override
6446
protected String getURL() {

library/src/main/java/com/proxerme/library/connection/messenger/request/SetReportRequest.java

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,6 @@ public class SetReportRequest extends ProxerRequest<VoidResult> {
2424
private String conferenceId;
2525
private String reason;
2626

27-
/**
28-
* Package constructor.
29-
*/
30-
SetReportRequest() {
31-
}
32-
3327
/**
3428
* The constructor.
3529
*
@@ -41,34 +35,14 @@ public SetReportRequest(@NonNull String conferenceId, @NonNull String reason) {
4135
this.reason = reason;
4236
}
4337

44-
/**
45-
* Returns the id of the conference.
46-
*
47-
* @return The conference id.
48-
*/
49-
@NonNull
50-
public String getConferenceId() {
51-
return conferenceId;
52-
}
53-
54-
/**
55-
* Returns the Reason.
56-
*
57-
* @return The Reason.
58-
**/
59-
@NonNull
60-
public String getReason() {
61-
return reason;
62-
}
63-
6438
@Override
6539
protected int getTag() {
6640
return ProxerTag.MESSENGER_SET_REPORT;
6741
}
6842

6943
@Override
7044
protected VoidResult parse(@NonNull Response response) throws Exception {
71-
return response.asClass(VoidResult.class);
45+
return new VoidResult();
7246
}
7347

7448
@NonNull

library/src/main/java/com/proxerme/library/connection/messenger/request/SetUnblockRequest.java

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,6 @@ public class SetUnblockRequest extends ProxerRequest<VoidResult> {
2222

2323
private String conferenceId;
2424

25-
26-
/**
27-
* Package constructor.
28-
*/
29-
SetUnblockRequest() {
30-
}
31-
3225
/**
3326
* The constructor.
3427
*
@@ -38,24 +31,14 @@ public SetUnblockRequest(@NonNull String conferenceId) {
3831
this.conferenceId = conferenceId;
3932
}
4033

41-
/**
42-
* Returns the id of the conference.
43-
*
44-
* @return The conference id.
45-
*/
46-
@NonNull
47-
public String getConferenceId() {
48-
return conferenceId;
49-
}
50-
5134
@Override
5235
protected int getTag() {
5336
return ProxerTag.MESSENGER_SET_UNBLOCK;
5437
}
5538

5639
@Override
5740
protected VoidResult parse(@NonNull Response response) throws Exception {
58-
return response.asClass(VoidResult.class);
41+
return new VoidResult();
5942
}
6043

6144
@NonNull

library/src/main/java/com/proxerme/library/connection/messenger/request/SetUnfavourRequest.java

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,6 @@ public class SetUnfavourRequest extends ProxerRequest<VoidResult> {
2323

2424
private String conferenceId;
2525

26-
/**
27-
* Package constructor.
28-
*/
29-
SetUnfavourRequest() {
30-
}
31-
3226
/**
3327
* The constructor.
3428
*
@@ -38,24 +32,14 @@ public SetUnfavourRequest(@NonNull String conferenceId) {
3832
this.conferenceId = conferenceId;
3933
}
4034

41-
/**
42-
* Returns the id of the conference.
43-
*
44-
* @return The conference id.
45-
*/
46-
@NonNull
47-
public String getConferenceId() {
48-
return conferenceId;
49-
}
50-
5135
@Override
5236
protected int getTag() {
5337
return ProxerTag.MESSENGER_SET_UNFAVOUR;
5438
}
5539

5640
@Override
5741
protected VoidResult parse(@NonNull Response response) throws Exception {
58-
return response.asClass(VoidResult.class);
42+
return new VoidResult();
5943
}
6044

6145
@NonNull

library/src/main/java/com/proxerme/library/connection/messenger/request/SetUnreadRequest.java

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,6 @@ public class SetUnreadRequest extends ProxerRequest<VoidResult> {
2222

2323
private String conferenceId;
2424

25-
26-
/**
27-
* Package constructor.
28-
*/
29-
SetUnreadRequest() {
30-
}
31-
3225
/**
3326
* The constructor.
3427
*
@@ -38,24 +31,14 @@ public SetUnreadRequest(@NonNull String conferenceId) {
3831
this.conferenceId = conferenceId;
3932
}
4033

41-
/**
42-
* Returns the id of the conference.
43-
*
44-
* @return The conference id.
45-
*/
46-
@NonNull
47-
public String getConferenceId() {
48-
return conferenceId;
49-
}
50-
5134
@Override
5235
protected int getTag() {
5336
return ProxerTag.MESSENGER_SET_UNREAD;
5437
}
5538

5639
@Override
5740
protected VoidResult parse(@NonNull Response response) throws Exception {
58-
return response.asClass(VoidResult.class);
41+
return new VoidResult();
5942
}
6043

6144
@NonNull

library/src/main/java/com/proxerme/library/connection/messenger/result/VoidResult.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
*/
1515
public class VoidResult implements ProxerResult<Void> {
1616

17-
VoidResult() {
17+
public VoidResult() {
1818
}
1919

2020
@Override

0 commit comments

Comments
 (0)