Skip to content

Commit 7d92dc2

Browse files
committed
Get rid of all wildcard imports and add a checkstyle rule for it
1 parent 1b10a54 commit 7d92dc2

6 files changed

Lines changed: 49 additions & 7 deletions

File tree

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ buildscript {
22
apply from: 'gradle/versions.gradle'
33

44
repositories {
5-
maven { url 'https://plugins.gradle.org/m2/' }
5+
maven { url = 'https://plugins.gradle.org/m2/' }
66
}
77

88
dependencies {
@@ -20,7 +20,7 @@ allprojects {
2020

2121
repositories {
2222
jcenter()
23-
maven {url 'https://oss.sonatype.org/content/repositories/snapshots'}
23+
maven { url = 'https://oss.sonatype.org/content/repositories/snapshots' }
2424
}
2525
}
2626

library/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ buildConfig {
135135

136136
javadoc {
137137
dependsOn delombok
138-
failOnError false
139138

139+
failOnError = false
140140
source = delombok.outputDir
141141

142142
options.memberLevel = JavadocMemberLevel.PUBLIC

library/config/checkstyle/checkstyle.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,11 @@
6666
<module name="UnusedImports">
6767
<property name="processJavadoc" value="true"/>
6868
</module>
69+
<!-- Added specifically for this project -->
70+
<module name="AvoidStarImport">
71+
<property name="allowClassImports" value="false"/>
72+
<property name="allowStaticMemberImports" value="false"/>
73+
</module>
6974

7075
<!-- Checks for Size Violations. -->
7176
<!-- See http://checkstyle.sf.net/config_sizes.html -->

library/src/main/java/me/proxer/library/api/list/InternalApi.java

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,28 @@
11
package me.proxer.library.api.list;
22

33
import me.proxer.library.api.ProxerCall;
4-
import me.proxer.library.entity.list.*;
5-
import me.proxer.library.enums.*;
4+
import me.proxer.library.entity.list.IndustryCore;
5+
import me.proxer.library.entity.list.IndustryProject;
6+
import me.proxer.library.entity.list.MediaListEntry;
7+
import me.proxer.library.entity.list.Tag;
8+
import me.proxer.library.entity.list.TranslatorGroupCore;
9+
import me.proxer.library.entity.list.TranslatorGroupProject;
10+
import me.proxer.library.enums.Category;
11+
import me.proxer.library.enums.Country;
12+
import me.proxer.library.enums.IndustryType;
13+
import me.proxer.library.enums.Language;
14+
import me.proxer.library.enums.LengthBound;
15+
import me.proxer.library.enums.MediaListSortCriteria;
16+
import me.proxer.library.enums.MediaSearchSortCriteria;
17+
import me.proxer.library.enums.MediaType;
18+
import me.proxer.library.enums.Medium;
19+
import me.proxer.library.enums.ProjectState;
20+
import me.proxer.library.enums.SortType;
21+
import me.proxer.library.enums.TagRateFilter;
22+
import me.proxer.library.enums.TagSortCriteria;
23+
import me.proxer.library.enums.TagSpoilerFilter;
24+
import me.proxer.library.enums.TagSubType;
25+
import me.proxer.library.enums.TagType;
626
import retrofit2.http.GET;
727
import retrofit2.http.Query;
828

library/src/main/java/me/proxer/library/api/list/MediaSearchEndpoint.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,14 @@
55
import me.proxer.library.api.PagingLimitEndpoint;
66
import me.proxer.library.api.ProxerCall;
77
import me.proxer.library.entity.list.MediaListEntry;
8-
import me.proxer.library.enums.*;
8+
import me.proxer.library.enums.FskConstraint;
9+
import me.proxer.library.enums.Genre;
10+
import me.proxer.library.enums.Language;
11+
import me.proxer.library.enums.LengthBound;
12+
import me.proxer.library.enums.MediaSearchSortCriteria;
13+
import me.proxer.library.enums.MediaType;
14+
import me.proxer.library.enums.TagRateFilter;
15+
import me.proxer.library.enums.TagSpoilerFilter;
916
import me.proxer.library.util.ProxerUtils;
1017

1118
import javax.annotation.Nullable;

library/src/test/java/me/proxer/library/api/list/MediaSearchEndpointTest.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,17 @@
33
import me.proxer.library.ProxerTest;
44
import me.proxer.library.api.ProxerException;
55
import me.proxer.library.entity.list.MediaListEntry;
6-
import me.proxer.library.enums.*;
6+
import me.proxer.library.enums.FskConstraint;
7+
import me.proxer.library.enums.Genre;
8+
import me.proxer.library.enums.Language;
9+
import me.proxer.library.enums.LengthBound;
10+
import me.proxer.library.enums.MediaLanguage;
11+
import me.proxer.library.enums.MediaSearchSortCriteria;
12+
import me.proxer.library.enums.MediaState;
13+
import me.proxer.library.enums.MediaType;
14+
import me.proxer.library.enums.Medium;
15+
import me.proxer.library.enums.TagRateFilter;
16+
import me.proxer.library.enums.TagSpoilerFilter;
717
import okhttp3.mockwebserver.MockResponse;
818
import org.junit.Test;
919

0 commit comments

Comments
 (0)