Fix all split methods to return empty results if input is empty

Author: rubengees

library/src/main/java/com/proxerme/library/connection/info/entity/Entry.java

@@ -187,23 +187,31 @@ public String getName() {
      *
      * @return The genres.
      */
+    @SuppressWarnings("WrongConstant")
     @NonNull
     @GenreParameter.Genre
     public String[] getGenres() {
-        //noinspection ResourceType
-        return genres.split(DELIMITER);
+        if (genres.isEmpty()) {
+            return new String[0];
+        } else {
+            return genres.split(DELIMITER);
+        }
     }
 
     /**
      * Returns an array of fsk names of this entry.
      *
      * @return An array of fsk names.
      */
+    @SuppressWarnings("WrongConstant")
     @NonNull
     @FskParameter.FskConstraint
     public String[] getFsk() {
-        //noinspection WrongConstant
-        return fsk.split(DELIMITER);
+        if (fsk.isEmpty()) {
+            return new String[0];
+        } else {
+            return fsk.split(DELIMITER);
+        }
     }
 
     /**

library/src/main/java/com/proxerme/library/connection/info/entity/EntryCore.java

@@ -8,7 +8,7 @@
 
 import com.proxerme.library.interfaces.IdItem;
 import com.proxerme.library.parameters.CategoryParameter.Category;
-import com.proxerme.library.parameters.FskParameter;
+import com.proxerme.library.parameters.FskParameter.FskConstraint;
 import com.proxerme.library.parameters.GenreParameter.Genre;
 import com.proxerme.library.parameters.LicenseParameter.License;
 import com.proxerme.library.parameters.MediumParameter.Medium;
@@ -145,23 +145,31 @@ public String getName() {
      *
      * @return The genres.
      */
+    @SuppressWarnings("WrongConstant")
     @NonNull
     @Genre
     public String[] getGenres() {
-        //noinspection ResourceType
-        return genres.split(DELIMITER);
+        if (genres.isEmpty()) {
+            return new String[0];
+        } else {
+            return genres.split(DELIMITER);
+        }
     }
 
     /**
      * Returns an array of fsk names of this entry.
      *
      * @return An array of fsk names.
      */
+    @SuppressWarnings("WrongConstant")
     @NonNull
-    @FskParameter.FskConstraint
+    @FskConstraint
     public String[] getFsk() {
-        //noinspection WrongConstant
-        return fsk.split(DELIMITER);
+        if (fsk.isEmpty()) {
+            return new String[0];
+        } else {
+            return fsk.split(DELIMITER);
+        }
     }
 
     /**

library/src/main/java/com/proxerme/library/connection/list/entity/MediaListEntry.java

@@ -7,8 +7,10 @@
 import android.support.annotation.NonNull;
 
 import com.proxerme.library.interfaces.IdItem;
+import com.proxerme.library.parameters.GenreParameter.Genre;
 import com.proxerme.library.parameters.MediumParameter.Medium;
 import com.proxerme.library.parameters.StateParameter.State;
+import com.proxerme.library.parameters.SubDubLanguageParameter.SubDubLanguage;
 import com.squareup.moshi.Json;
 
 /**
@@ -119,9 +121,15 @@ public String getName() {
      *
      * @return The array of genres.
      */
+    @SuppressWarnings("WrongConstant")
     @NonNull
+    @Genre
     public String[] getGenres() {
-        return genres.split(" ");
+        if (genres.isEmpty()) {
+            return new String[0];
+        } else {
+            return genres.split(" ");
+        }
     }
 
     /**
@@ -194,9 +202,15 @@ public float getRating() {
      *
      * @return An array with the languages.
      */
+    @SuppressWarnings("WrongConstant")
     @NonNull
+    @SubDubLanguage
     public String[] getLanguages() {
-        return languages.split(",");
+        if (languages.isEmpty()) {
+            return new String[0];
+        } else {
+            return languages.split(",");
+        }
     }
 
     @SuppressWarnings("SimplifiableIfStatement")

library/src/main/java/com/proxerme/library/connection/messenger/entity/Conference.java

@@ -32,6 +32,7 @@ public Conference[] newArray(int size) {
     };
 
     private static final String IMAGE_DELIMITER = ":";
+    private static final String EMPTY_RESULT = "";
 
     @Json(name = "id")
     private String id;
@@ -88,7 +89,7 @@ public Conference(@NonNull String id, @NonNull String topic, @NonNull String cus
         this.lastReadMessageId = lastReadMessageId;
 
         if (imageType == null || imageType.isEmpty() || imageId == null || imageType.isEmpty()) {
-            this.image = "";
+            this.image = EMPTY_RESULT;
         } else {
             this.image = imageType + IMAGE_DELIMITER + imageId;
         }
@@ -124,12 +125,16 @@ public String getLastReadMessageId() {
      */
     @NonNull
     public String getImageType() {
-        String[] split = image.split(IMAGE_DELIMITER);
-
-        if (split.length == 2) {
-            return split[0];
+        if (image.isEmpty()) {
+            return EMPTY_RESULT;
         } else {
-            return "";
+            String[] split = image.split(IMAGE_DELIMITER);
+
+            if (split.length == 2) {
+                return split[0];
+            } else {
+                return EMPTY_RESULT;
+            }
         }
     }
 
@@ -141,12 +146,16 @@ public String getImageType() {
     @Override
     @NonNull
     public String getImageId() {
-        String[] split = image.split(IMAGE_DELIMITER);
-
-        if (split.length == 2) {
-            return split[1];
+        if (image.isEmpty()) {
+            return EMPTY_RESULT;
         } else {
-            return "";
+            String[] split = image.split(IMAGE_DELIMITER);
+
+            if (split.length == 2) {
+                return split[1];
+            } else {
+                return EMPTY_RESULT;
+            }
         }
     }