Fixed build issues

Author: Prozilla

.github/workflows/deploy.yml

@@ -20,10 +20,11 @@ jobs:
       - name: Fetch latest tag
         id: get_tag
         run: |
-          git fetch --tags
-          LATEST_TAG=$(git tag -l "v*" --sort=-v:refname | head -n 1)
+          LATEST_TAG=$(gh release view --json tagName --template '{{.tagName}}' || git tag -l "v*" --sort=-v:refname | head -n 1)
           echo "tag=$LATEST_TAG" >> $GITHUB_OUTPUT
           echo "Found tag: $LATEST_TAG"
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Checkout latest release
         uses: actions/checkout@v4
@@ -43,6 +44,9 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
 
+      - name: Link node_modules
+        run: ln -s ${{ github.workspace }}/node_modules ${{ github.workspace }}/latest-release/node_modules
+
       - name: Build packages
         run: pnpm run build
         env:

demo/scripts/fetchRepository.ts

@@ -1,6 +1,6 @@
 import fs from "node:fs";
 import { REPO } from "../src/config/deploy.config";
-import { name } from "../package.json";
+import { name } from "../package.json" with { type: "json" };
 import { Logger } from "@prozilla-os/shared";
 
 const API_URL = "https://api.github.com/";

demo/src/types/style.d.ts

@@ -0,0 +1,7 @@
+import "react";
+
+declare module "react" {
+	interface CSSProperties {
+		[key: `--${string}`]: string | number | undefined;
+	}
+}

demo/tsconfig.build.json

@@ -1,9 +1,13 @@
 {
-	"extends": "./tsconfig.json",
-	"compilerOptions": {
-		"paths": {
-			"prozilla-os": ["packages/prozilla-os/dist/main",],
-			"@prozilla-os/*": ["packages/*/dist/main", "packages/apps/*/dist/main"],
-		},
-	},
+    "extends": "./tsconfig.json",
+    "compilerOptions": {
+        "paths": {
+            "prozilla-os": ["packages/prozilla-os/dist/main.d.ts"],
+            "@prozilla-os/core": ["packages/core/dist/main.d.ts"],
+            "@prozilla-os/shared": ["packages/shared/dist/main.d.ts"],
+            "@prozilla-os/skins": ["packages/skins/dist/main.d.ts"],
+            "@prozilla-os/dev-tools": ["packages/dev-tools/dist/main.d.ts"],
+            "@prozilla-os/*": ["packages/apps/*/dist/main.d.ts"]
+        }
+    }
 }

demo/tsconfig.json

@@ -11,7 +11,6 @@
 		"src",
 		"vite.config.ts",
 		"scripts",
-		"../packages/core/src/**/*"
 	],
-	"exclude": ["**/node_modules/**/*"]
+	"exclude": ["node_modules", "**/dist/**"]
 }

docs/scripts/typedoc.ts

@@ -39,18 +39,20 @@ const SOURCE_BASE = RELEASE_PATH
 	? resolve(RELEASE_PATH, "packages") 
 	: resolve(__dirname, PACKAGES_DIR);
 
+const COMPILER_BASE = RELEASE_PATH ? resolve(RELEASE_PATH) : resolve(__dirname, "../../");
+
 const COMPILER_PATHS: Record<string, string[]> = {
-	"*": ["node_modules/*"],
+	"*": [resolve(COMPILER_BASE, "node_modules/*").replaceAll("\\", "/")],
 };
 
 PACKAGE_PATHS.forEach((path) => {
 	const name = packagePathToName(path);
-	COMPILER_PATHS[name] = [`packages/${path}`];
-	COMPILER_PATHS[`${name}/*`] = [`packages/${path}/*`];
+	// Point to the source files in the release directory
+	const absolutePkgPath = resolve(SOURCE_BASE, path, "src/main.ts").replaceAll("\\", "/");
+	COMPILER_PATHS[name] = [absolutePkgPath];
+	COMPILER_PATHS[`${name}/*`] = [resolve(SOURCE_BASE, path, "src/*").replaceAll("\\", "/")];
 });
 
-const WORKSPACE_ROOT = resolve(__dirname, "../../").replaceAll("\\", "/");
-
 const logger = new Logger();
 
 program.name("typedoc-helper")
@@ -104,25 +106,28 @@ program.command("run", { isDefault: true })
 async function generateDocs(path: string, dryRun: boolean) {
 	const packageDir = resolve(SOURCE_BASE, path);
 	const entryPoint = resolve(packageDir, "src/main.ts").replaceAll("\\", "/");
-    
-	const tsConfig = resolve(SOURCE_BASE, path, "tsconfig.json");
-
+	const tsConfig = resolve(packageDir, "tsconfig.json"); // Use the local tsconfig
 	const outDir = OUT_DIR + path;
-	const navigationJson = `${outDir}/nav.json`;
 
-	const options: TypeDocOptions & PluginOptions & { path: string } = {
+	const options = {
 		...DEFAULT_OPTIONS,
 		path,
 		entryPoints: [entryPoint],
 		tsconfig: tsConfig,
 		out: outDir,
-		navigationJson,
+		navigationJson: `${outDir}/nav.json`,
+		// We minimize overrides to let the package's own config do the work
 		compilerOptions: {
-			moduleResolution: "node",
-			baseUrl: WORKSPACE_ROOT,
+			baseUrl: SOURCE_BASE.replaceAll("\\", "/"),
 			paths: COMPILER_PATHS,
+			// Tell TS to look for types in the root node_modules specifically
+			typeRoots: [
+				resolve(process.cwd(), "node_modules/@types").replaceAll("\\", "/"),
+				resolve(process.cwd(), "node_modules").replaceAll("\\", "/"),
+			],
+			// Crucial for pnpm symlinks in CI
+			preserveSymlinks: true,
 			skipLibCheck: true,
-			jsx: "react-jsx",
 		},
 	};
 

package.json

@@ -68,7 +68,7 @@
 		"stylelint": "^16.26.1",
 		"typescript": "^5.9.3",
 		"typescript-eslint": "^8.54.0",
-		"vite-node": "^2.1.9",
+		"vite-node": "^6.0.0",
 		"vite-plugin-checker": "^0.7.2"
 	},
 	"browserslist": {

packages/apps/terminal/tsconfig.build.json

@@ -1,10 +1,3 @@
 {
 	"extends": "./tsconfig.json",
-	"compilerOptions": {
-		"paths": {
-			"@prozilla-os/core": ["packages/core/dist/main"],
-			"@prozilla-os/shared": ["packages/shared/dist/main"],
-			"@prozilla-os/skins": ["packages/skins/dist/main"]
-		}
-	}
 }

packages/apps/terminal/tsconfig.json

@@ -13,6 +13,6 @@
 			"@prozilla-os/skins": ["./node_modules/@prozilla-os/skins/src/main"]
 		}
 	},
-	"include": ["src", "vite.config.ts", "../../core/src/features/shell/_utils"],
-	"exclude": ["node_modules"],
+	"include": ["src", "vite.config.ts"],
+	"exclude": ["node_modules"]
 }

packages/core/src/features/shell/executableResolver.ts

@@ -32,7 +32,6 @@ export class ExecutableResolver {
 	}
 
 	private static resolvePath(path: string, workingDirectory: VirtualFolder): ExecutableResolutionResult {
-		console.log(workingDirectory.path, path);
 		const target = workingDirectory.navigate(path);
 		if (!target)
 			return { executable: null, error: this.NOT_FOUND_ERROR };