Skip to content

Commit 02ce31d

Browse files
committed
chore: remove debug logging after diagnosing heritage contribution issue
Analysis from logs (clc.log) revealed the actual issue: - First attempt FAILED validation: 'contributorRole' field was empty - Second attempt SUCCEEDED: User filled in contributorRole field - Form worked perfectly once all required fields were provided Conclusion: This was NOT a bug with attachments. The issue was that: 1. Validation correctly requires contributorRole field 2. User saw 'Publishing: validating' status but no clear error message 3. Once user filled contributorRole, contribution published successfully to 8/8 relays The form is working as designed. No code fixes needed - just UX improvement for displaying validation errors more prominently (future enhancement).
1 parent 4a9d0ff commit 02ce31d

3 files changed

Lines changed: 0 additions & 42 deletions

File tree

src/hooks/useContentPublishing.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -85,20 +85,13 @@ export function useContentPublishing<
8585
const { setPublishing, setProgress, setResult } = stateSetters;
8686

8787
try {
88-
console.log('[useContentPublishing] publishWithWrapper called', {
89-
service: serviceName,
90-
method: methodName,
91-
attachmentCount: attachmentFiles.length,
92-
});
93-
9488
logger.info(`Starting ${methodName}`, {
9589
service: serviceName,
9690
method: methodName,
9791
attachmentCount: attachmentFiles.length,
9892
});
9993

10094
// Step 1: Validate signer availability
101-
console.log('[useContentPublishing] Checking signer availability', { isAvailable });
10295
if (!isAvailable) {
10396
const error = 'Nostr signer not available. Please install a Nostr extension.';
10497
logger.error(`Cannot ${methodName}: No signer`, new Error(error), {
@@ -118,9 +111,7 @@ export function useContentPublishing<
118111
}
119112

120113
// Step 2: Get signer
121-
console.log('[useContentPublishing] Getting signer...');
122114
const signer = await getSigner();
123-
console.log('[useContentPublishing] Got signer', { hasSigner: !!signer });
124115
if (!signer) {
125116
const error = 'Failed to get Nostr signer';
126117
logger.error(`Cannot ${methodName}: Failed to get signer`, new Error(error), {
@@ -140,11 +131,7 @@ export function useContentPublishing<
140131
}
141132

142133
// Step 3: Show consent dialog if there are files
143-
console.log('[useContentPublishing] Checking if consent dialog needed', {
144-
filesCount: attachmentFiles.length,
145-
});
146134
if (attachmentFiles.length > 0) {
147-
console.log('[useContentPublishing] Showing consent dialog');
148135
logger.info('Showing consent dialog for file uploads', {
149136
service: serviceName,
150137
method: methodName,
@@ -173,12 +160,10 @@ export function useContentPublishing<
173160
}
174161

175162
// Step 4: Set publishing state
176-
console.log('[useContentPublishing] Setting publishing state');
177163
setPublishing(true);
178164
setProgress(null);
179165

180166
// Step 5: Call the actual publish function with progress tracking
181-
console.log('[useContentPublishing] Calling actual publish function');
182167
const result = await publishFn(
183168
data,
184169
attachmentFiles,

src/hooks/useHeritagePublishing.ts

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,6 @@ export const useHeritagePublishing = () => {
9494
attachmentFiles: File[],
9595
existingDTag?: string
9696
): Promise<HeritagePublishingResult> => {
97-
console.log('[useHeritagePublishing] publishHeritage called', {
98-
attachmentFilesCount: attachmentFiles.length,
99-
existingDTag,
100-
});
101-
10297
// Reset state
10398
setState({
10499
isPublishing: true,
@@ -108,14 +103,8 @@ export const useHeritagePublishing = () => {
108103
result: null,
109104
});
110105

111-
console.log('[useHeritagePublishing] About to call publishWithWrapper');
112-
113106
const result = await publishWithWrapper(
114107
async (contributionData, files, signer, onProgress) => {
115-
console.log('[useHeritagePublishing] Inside publishWithWrapper callback', {
116-
filesCount: files.length,
117-
});
118-
119108
const serviceResult = await createHeritageContribution(
120109
contributionData,
121110
files,
@@ -124,10 +113,6 @@ export const useHeritagePublishing = () => {
124113
onProgress
125114
);
126115

127-
console.log('[useHeritagePublishing] createHeritageContribution completed', {
128-
success: serviceResult.success,
129-
});
130-
131116
// Map service result to HeritagePublishingResult
132117
return {
133118
success: serviceResult.success,
@@ -144,10 +129,6 @@ export const useHeritagePublishing = () => {
144129
attachmentFiles
145130
);
146131

147-
console.log('[useHeritagePublishing] publishWithWrapper completed', {
148-
success: result.success,
149-
});
150-
151132
return result;
152133
}, [publishWithWrapper, setState]);
153134

src/services/business/HeritageContentService.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,6 @@ export async function createHeritageContribution(
277277
onProgress?: (progress: HeritagePublishingProgress) => void
278278
): Promise<CreateHeritageResult> {
279279
try {
280-
console.log('[HeritageContentService] createHeritageContribution called', {
281-
attachmentFilesCount: attachmentFiles.length,
282-
isEdit: !!existingDTag,
283-
});
284-
285280
logger.info('Starting heritage contribution creation', {
286281
service: 'HeritageContentService',
287282
method: 'createHeritageContribution',
@@ -291,17 +286,14 @@ export async function createHeritageContribution(
291286
});
292287

293288
// Step 1: Validate heritage data
294-
console.log('[HeritageContentService] Reporting validation progress');
295289
onProgress?.({
296290
step: 'validating',
297291
progress: 10,
298292
message: 'Validating contribution...',
299293
details: 'Checking required fields',
300294
});
301295

302-
console.log('[HeritageContentService] Calling validateHeritageData');
303296
const validation = validateHeritageData(heritageData);
304-
console.log('[HeritageContentService] Validation result', { valid: validation.valid });
305297
if (!validation.valid) {
306298
const errorMsg = Object.values(validation.errors).join(', ');
307299
logger.error('Heritage validation failed', new Error(errorMsg), {

0 commit comments

Comments
 (0)