fix: a fixed-size heap buffer of conntrackinfo_memsi... in...#27
Open
orbisai0security wants to merge 1 commit into
Open
fix: a fixed-size heap buffer of conntrackinfo_memsi... in...#27orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
A fixed-size heap buffer of CONNTRACKINFO_MEMSIZE bytes is allocated at natflow_conntrack
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
natflow_conntrack.c.Vulnerability
V-001natflow_conntrack.c:271Description: A fixed-size heap buffer of CONNTRACKINFO_MEMSIZE bytes is allocated at natflow_conntrack.c:271. At lines 291-340, at least 10 sequential sprintf() calls accumulate formatted connection tracking data (IPv4/IPv6 addresses, ports, TCP state names, protocol fields) into this buffer without any bounds checking. If the cumulative formatted output exceeds CONNTRACKINFO_MEMSIZE, subsequent sprintf() calls write beyond the allocated heap region, corrupting adjacent kernel heap objects. IPv6 addresses alone can consume up to 39 characters each, and multiple fields per conntrack entry can easily exceed a typical fixed buffer size.
Changes
natflow_conntrack.cVerification
Automated security fix by OrbisAI Security