Fix syntax error in job pre-condition (#149)

build(workflow): fix syntax error in job pre-condition

build(workflow): improve tests and validation workflows

Author: parfeon

.github/workflows/commands-handler.yml

@@ -3,28 +3,41 @@ name: Commands processor
 on:
   issue_comment:
     types: [created]
-
+defaults:
+  run:
+    shell: bash
 
 jobs:
   process:
     name: Process command
-    if: ${{ github.event.issue.pull_request && endsWith(github.repository, '-private') != true && startsWith(github.event.comment.body, '@client-engineering-bot ') }}
+    if: github.event.issue.pull_request && endsWith(github.repository, '-private') != true
     runs-on: ubuntu-latest
     steps:
+      - name: Check referred user
+        id: user-check
+        env: 
+          CLEN_BOT: ${{ secrets.CLEN_BOT }}
+        run: echo "expected-user=${{ startsWith(github.event.comment.body, format('@{0} ', env.CLEN_BOT)) }}" >> $GITHUB_OUTPUT
+      - name: Regular comment
+        if: steps.user-check.outputs.expected-user != 'true'
+        run: echo -e "\033[38;2;19;181;255mThis is regular commit which should be ignored.\033[0m"
       - name: Checkout repository
+        if: steps.user-check.outputs.expected-user == 'true'
         uses: actions/checkout@v3
         with:
-          token: ${{ secrets.GH_TOKEN }}
+           token: ${{ secrets.GH_TOKEN }}
       - name: Checkout release actions
+        if: steps.user-check.outputs.expected-user == 'true'
         uses: actions/checkout@v3
         with:
           repository: pubnub/client-engineering-deployment-tools
           ref: v1
           token: ${{ secrets.GH_TOKEN }}
           path: .github/.release/actions
       - name: Process changelog entries
+        if: steps.user-check.outputs.expected-user == 'true'
         uses: ./.github/.release/actions/actions/commands
         with:
           token: ${{ secrets.GH_TOKEN }}
-          jira-api-key: ${{ secrets.JIRA_API_KEY }}
-          listener: client-engineering-bot
+          listener: ${{ secrets.CLEN_BOT }}
+          jira-api-key: ${{ secrets.JIRA_API_KEY }}

.github/workflows/release.yml

@@ -10,7 +10,7 @@ jobs:
   check-release:
     name: Check release required
     runs-on: ubuntu-latest
-    if: ${{ github.event.pull_request.merged && endsWith(github.repository, '-private') != true }}
+    if: github.event.pull_request.merged && endsWith(github.repository, '-private') != true
     outputs:
       release: ${{ steps.check.outputs.ready }}
     steps:
@@ -30,7 +30,7 @@ jobs:
     name: Publish package
     runs-on: ubuntu-latest
     needs: check-release
-    if: ${{ needs.check-release.outputs.release == 'true' }}
+    if: needs.check-release.outputs.release == 'true'
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3

.github/workflows/run-tests.yml

@@ -3,50 +3,45 @@ name: Tests
 on:
   push:
   workflow_dispatch:
-
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+defaults:
+  run:
+    shell: bash
 
 jobs:
   tests:
     name: Integration and Unit tests
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+      matrix:
+        python: [3.7.13, 3.8.13, 3.9.13, 3.10-dev]
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
         with:
           token: ${{ secrets.GH_TOKEN }}
-      - name: Setup Python 3.7
-        uses: actions/setup-python@v4
-        with:
-          python-version: '3.7.13'
-      - name: Build and run tests for Python 3.7
-        run: |
-          ./scripts/install.sh
-          python scripts/run-tests.py
-      - name: Setup Python 3.8
-        uses: actions/setup-python@v4
-        with:
-          python-version: '3.8.13'
-      - name: Build and run tests for Python 3.8
-        run: |
-          ./scripts/install.sh
-          python scripts/run-tests.py
-      - name: Setup Python 3.9
-        uses: actions/setup-python@v4
+      - name: Checkout actions
+        uses: actions/checkout@v3
         with:
-          python-version: '3.9.13'
-      - name: Build and run tests for Python 3.9
-        run: |
-          ./scripts/install.sh
-          python scripts/run-tests.py
-      - name: Setup Python 3.10
+          repository: pubnub/client-engineering-deployment-tools
+          ref: v1
+          token: ${{ secrets.GH_TOKEN }}
+          path: .github/.release/actions
+      - name: Setup Python ${{ matrix.python }}
         uses: actions/setup-python@v4
         with:
-          python-version: '3.10-dev'
-      - name: Build and run tests for Python 3.10
+          python-version: ${{ matrix.python }}
+      - name: Build and run tests for Python ${{ matrix.python }}
         run: |
           ./scripts/install.sh
           python scripts/run-tests.py
-  acceptance:
+      - name: Cancel workflow runs for commit on error
+        if: failure()
+        uses: ./.github/.release/actions/actions/utils/fast-jobs-failure
+  acceptance-tests:
     name: Acceptance tests
     runs-on: ubuntu-latest
     steps:
@@ -82,3 +77,13 @@ jobs:
           name: acceptance-test-reports
           path: ./reports
           retention-days: 7
+      - name: Cancel workflow runs for commit on error
+        if: failure()
+        uses: ./.github/.release/actions/actions/utils/fast-jobs-failure
+  all-tests:
+    name: Tests
+    runs-on: ubuntu-latest
+    needs: [tests, acceptance-tests]
+    steps:
+      - name: Tests summary
+        run: echo -e "\033[38;2;95;215;0m\033[1mAll tests successfully passed"

.github/workflows/run-validations.yml

@@ -3,20 +3,30 @@ name: Validations
 on: [push]
 
 jobs:
-  validators:
-      name: "Validate .pubnub.yml"
-      runs-on: ubuntu-latest
-      steps:
-        - name: Checkout project
-          uses: actions/checkout@v3
-        - name: Checkout validator action
-          uses: actions/checkout@v3
-          with:
-            repository: pubnub/client-engineering-deployment-tools
-            ref: v1
-            token: ${{ secrets.GH_TOKEN }}
-            path: .github/.release/actions
-        - name: "Run '.pubnub.yml' file validation"
-          uses: ./.github/.release/actions/actions/validators/pubnub-yml
-          with:
-            token: ${{ secrets.GH_TOKEN }}
+  pubnub-yml:
+    name: "Validate .pubnub.yml"
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout project
+        uses: actions/checkout@v3
+      - name: Checkout validator action
+        uses: actions/checkout@v3
+        with:
+          repository: pubnub/client-engineering-deployment-tools
+          ref: v1
+          token: ${{ secrets.GH_TOKEN }}
+          path: .github/.release/actions
+      - name: "Run '.pubnub.yml' file validation"
+        uses: ./.github/.release/actions/actions/validators/pubnub-yml
+        with:
+          token: ${{ secrets.GH_TOKEN }}
+      - name: Cancel workflow runs for commit on error
+        if: failure()
+        uses: ./.github/.release/actions/actions/utils/fast-jobs-failure
+  all-validations:
+    name: Validations
+    runs-on: ubuntu-latest
+    needs: [pubnub-yml]
+    steps:
+      - name: Validations summary
+        run: echo -e "\033[38;2;95;215;0m\033[1mAll validations passed"