bender-slang: Clippy fixes and clean up

Author: fischeti

crates/bender-slang/build.rs

@@ -27,7 +27,7 @@ fn main() {
     ];
 
     // Add debug define if in debug build
-    if build_profile == "debug" && !(target_env == "msvc") {
+    if build_profile == "debug" && (target_env != "msvc") {
         common_cxx_defines.push(("SLANG_DEBUG", "1"));
         common_cxx_defines.push(("SLANG_ASSERT_ENABLED", "1"));
     };

crates/bender-slang/src/lib.rs

@@ -203,6 +203,12 @@ impl SyntaxTrees {
     }
 }
 
+impl Default for SyntaxTrees {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl SlangContext {
     /// Creates a new Slang session.
     pub fn new() -> Self {
@@ -248,7 +254,8 @@ impl SlangContext {
     }
 }
 
-/// Creates a new Slang session
-pub fn new_session() -> SlangContext {
-    SlangContext::new()
+impl Default for SlangContext {
+    fn default() -> Self {
+        Self::new()
+    }
 }

src/cmd/pickle.rs

@@ -19,7 +19,7 @@ use crate::sess::{Session, SessionIo};
 use crate::src::{SourceFile, SourceGroup, SourceType};
 use crate::target::TargetSet;
 
-use bender_slang::SlangPrintOpts;
+use bender_slang::{SlangContext, SlangPrintOpts, SyntaxTrees};
 
 /// Pickle files
 #[derive(Args, Debug)]
@@ -179,8 +179,8 @@ pub fn run(sess: &Session, args: PickleArgs) -> Result<()> {
         write!(writer, "[")?;
     }
 
-    let mut parsed_trees = bender_slang::SyntaxTrees::new();
-    let mut slang = bender_slang::new_session();
+    let mut parsed_trees = SyntaxTrees::new();
+    let mut slang = SlangContext::new();
     for src_group in srcs {
         // Collect include directories and defines from the source group and command line arguments.
         let include_dirs: Vec<String> = src_group