Skip to content

Commit e1a65e1

Browse files
committed
update and refactor test workflow, add comments
1 parent 54dffca commit e1a65e1

1 file changed

Lines changed: 17 additions & 9 deletions

File tree

.github/workflows/test.yaml

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,44 @@
1-
name: ci-workflow
2-
# run workflow for these events
1+
name: test-workflow
32
on:
3+
# when any branch in the repository is pushed
44
push:
5+
# when a pull request is created
56
pull_request:
7+
# when manually triggered to run
68
workflow_dispatch:
9+
# when scheduled
710
schedule:
811
- cron: '0 0 * * 0' # weekly
912

1013
jobs:
11-
build:
14+
# run tests
15+
test:
1216
strategy:
1317
matrix:
1418
python-version: ['3.6', '3.7', '3.8', '3.9']
1519
os: ['ubuntu-20.04', 'macos-10.15', 'windows-2019']
20+
# do not cancel any jobs when a single job fails
1621
fail-fast: false
1722
name: Python ${{ matrix.python-version }} on ${{ matrix.os }}
1823
runs-on: ${{ matrix.os }}
1924
steps:
2025
- name: Checkout code
2126
uses: actions/checkout@v2
27+
2228
- name: Setup python
2329
uses: actions/setup-python@v2
2430
with:
2531
python-version: ${{ matrix.python-version }}
32+
2633
- name: Install dependencies
27-
run: pip install -r requirements-dev.txt
28-
- name: Check linting
29-
run: make check-lint
30-
- name: Lint code
31-
run: make lint
34+
run: pip install --requirement requirements-dev.txt
35+
36+
- name: Run code linting checks
37+
run: make ci-lint
38+
3239
- name: Run tests with code coverage
3340
run: make coverage
41+
3442
- name: Upload coverage data to coveralls.io
3543
run: coveralls --service=github
3644
env:
@@ -39,7 +47,7 @@ jobs:
3947
COVERALLS_PARALLEL: true
4048

4149
coveralls:
42-
name: Indicate completion to coveralls.io
50+
name: Indicate completion to coveralls.io when all parallel jobs finished
4351
needs: build
4452
runs-on: ubuntu-latest
4553
container: python:3-slim

0 commit comments

Comments
 (0)