Skip to content

Commit 4e8a613

Browse files
authored
Fix media delete (#848)
* Fix media delete * Update media delete test
1 parent 01131c9 commit 4e8a613

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

plexapi/media.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,16 @@ def _loadData(self, data):
7979
self.make = data.attrib.get('make')
8080
self.model = data.attrib.get('model')
8181

82+
parent = self._parent()
83+
self._parentKey = parent.key
84+
8285
@property
8386
def isOptimizedVersion(self):
8487
""" Returns True if the media is a Plex optimized version. """
8588
return self.proxyType == utils.SEARCHTYPES['optimizedVersion']
8689

8790
def delete(self):
88-
part = self._initpath + '/media/%s' % self.id
91+
part = '%s/media/%s' % (self._parentKey, self.id)
8992
try:
9093
return self._server.query(part, method=self._server._session.delete)
9194
except BadRequest:

tests/test_video.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,13 +129,9 @@ def test_video_Movie_isPartialObject(movie):
129129
assert movie.isPartialObject()
130130

131131

132-
def test_video_Movie_delete_part(movie, mocker):
133-
# we need to reload this as there is a bug in part.delete
134-
# See https://github.com/pkkid/python-plexapi/issues/201
135-
m = movie.reload()
136-
for media in m.media:
137-
with utils.callable_http_patch():
138-
media.delete()
132+
def test_video_Movie_media_delete(movie, patched_http_call):
133+
for media in movie.media:
134+
media.delete()
139135

140136

141137
def test_video_Movie_iterParts(movie):

0 commit comments

Comments
 (0)