test: Use system temp directory rather than a custom one

Author: pvdlg

.eslintignore

@@ -1,2 +1 @@
 lib/**
-test/fixtures/.tmp/**

.gitignore

@@ -129,5 +129,4 @@ $RECYCLE.BIN/
 
 yarn.lock
 package-lock.json
-test/fixtures/.tmp
 lib

package.json

@@ -64,7 +64,7 @@
     "sinon": "^3.0.0",
     "sr-commit-analyzer": "^2.0.2",
     "sr-release-notes-generator": "^1.1.2",
-    "uuid": "^3.1.0"
+    "tempy": "^0.1.0"
   },
   "engines": {
     "node": ">=4"
@@ -119,7 +119,7 @@
     "url": "git+https://github.com/vanduynslagerp/karma-postcss-preprocessor.git"
   },
   "scripts": {
-    "clean": "rimraf test/fixtures/.tmp && rimraf coverage && rimraf .nyc_output",
+    "clean": "rimraf rimraf coverage && rimraf .nyc_output",
     "cm": "git-cz",
     "codecov": "codecov",
     "commitmsg": "commitlint -e",

test/helpers/karma.js

@@ -12,10 +12,10 @@ const KARMA_CONFIG = {
   basePath: '',
   frameworks: ['jasmine-jquery'],
   preprocessors: {
-    'test/fixtures/**/!(*custom).+(css|txt)': ['postcss'],
-    'test/fixtures/**/basic': ['postcss'],
-    'test/fixtures/**/*custom.+(css|txt)': ['custom_postcss'],
-    'test/fixtures/**/*.test.js': ['babel'],
+    '/**/!(*custom).+(css|txt)': ['postcss'],
+    '/**/basic': ['postcss'],
+    '/**/*custom.+(css|txt)': ['custom_postcss'],
+    '/**/*.test.js': ['babel'],
   },
   babelPreprocessor: {options: {babelrc: false, presets: ['es2015'], sourceMap: 'inline'}},
   colors: true,

test/helpers/utils.js

@@ -1,20 +1,9 @@
 import path from 'path';
 import {readFile} from 'fs-extra';
-import uuid from 'uuid';
 import pEvent from 'p-event';
 import sourceMappingURL from 'source-map-url';
 import postcss from 'postcss';
 
-/**
- * Generate a unique temporary file/directory path.
- *
- * @param {String} filename file/directory name to create under 'test/fixtures/.tmp'.
- * @return {String} the path of the unique temporary file/directory.
- */
-export function tmp(filename) {
-  return path.join('test/fixtures/.tmp', uuid(), filename || '');
-}
-
 /* eslint-disable no-magic-numbers */
 /**
  * Return a Promise that resolve when an event is emitted and reject after a timeout expire if the event is not emitted.

test/integration.test.js

@@ -1,13 +1,13 @@
 import path from 'path';
 import {copy} from 'fs-extra';
 import test from 'ava';
+import {stub} from 'sinon';
+import tempy from 'tempy';
 import cssnano from 'cssnano';
 import mixins from 'postcss-mixins';
 import simpleVars from 'postcss-simple-vars';
 import atImport from 'postcss-import';
-import {stub} from 'sinon';
 import {run, watch, waitForRunComplete} from './helpers/karma';
-import {tmp} from './helpers/utils';
 
 let stubWrite;
 
@@ -56,7 +56,7 @@ test('Log error on invalid css file', async t => {
 });
 
 test('Re-compile css file when dependency is modified', async t => {
-  const dir = path.resolve(tmp());
+  const dir = tempy.directory();
   const fixture = path.join(dir, 'with-partial.css');
   const includePath = path.join(dir, 'partials');
   const partial = path.join(includePath, 'partial.css');
@@ -68,6 +68,7 @@ test('Re-compile css file when dependency is modified', async t => {
     copy('test/fixtures/with-partial.css', fixture),
   ]);
 
+  console.log(fixture.replace('fixtures', '*').replace('with', '+(with|nomatch)'), 'test/fixtures/styles.test.js');
   const {server, watcher} = await watch(
     [fixture.replace('fixtures', '*').replace('with', '+(with|nomatch)'), 'test/fixtures/styles.test.js'],
     {options: {plugins: [atImport({path: [includePath]}), mixins, simpleVars, cssnano]}}

test/unit.test.js

@@ -2,11 +2,12 @@ import path from 'path';
 import {readFile, copy, outputFile, remove} from 'fs-extra';
 import test from 'ava';
 import {spy, match} from 'sinon';
+import tempy from 'tempy';
 import cssnano from 'cssnano';
 import mixins from 'postcss-mixins';
 import simpleVars from 'postcss-simple-vars';
 import atImport from 'postcss-import';
-import {tmp, waitFor, compile} from './helpers/utils';
+import {waitFor, compile} from './helpers/utils';
 import {mockPreprocessor} from './helpers/mock';
 
 test('Compile css file', async t => {
@@ -227,7 +228,7 @@ test('Do not add dependency to watcher if parent is not watched', async t => {
 });
 
 test('Add dependency to watcher only once, even when its referenced multiple times', async t => {
-  const dir = path.resolve(tmp());
+  const dir = tempy.directory();
   const fixture = path.join(dir, 'with-partial.css');
   const otherFixture = path.join(dir, 'other-with-partial.css');
   const includePath = path.join(dir, 'partials');
@@ -286,7 +287,7 @@ test('Add dependency to watcher only once if file is overwritten', async t => {
 });
 
 test('Remove dependency from watcher if not referenced anymore', async t => {
-  const dir = path.resolve(tmp());
+  const dir = tempy.directory();
   const fixture = path.join(dir, 'with-partial.css');
   const includePath = path.join(dir, 'partials');
   const partial = path.join(includePath, 'partial.css');
@@ -322,7 +323,7 @@ test('Remove dependency from watcher if not referenced anymore', async t => {
 });
 
 test('Do not remove dependency from watcher when unreferenced, if another file still depends on it', async t => {
-  const dir = path.resolve(tmp());
+  const dir = tempy.directory();
   const fixture = path.join(dir, 'with-partial.css');
   const otherFixture = path.join(dir, 'other-with-partial.css');
   const includePath = path.join(dir, 'partials');
@@ -363,7 +364,7 @@ test('Do not remove dependency from watcher when unreferenced, if another file s
 });
 
 test('Do not remove dependency from watcher when different files have differents childs', async t => {
-  const dir = path.resolve(tmp());
+  const dir = tempy.directory();
   const fixture = path.join(dir, 'with-partial.css');
   const otherFixture = path.join(dir, 'other-with-partial.css');
   const includePath = path.join(dir, 'partials');
@@ -403,7 +404,7 @@ test('Do not remove dependency from watcher when different files have differents
 });
 
 test('Call refreshFiles when dependency is modified', async t => {
-  const dir = path.resolve(tmp());
+  const dir = tempy.directory();
   const fixture = path.join(dir, 'with-partial.css');
   const includePath = path.join(dir, 'partials');
   const partial = path.join(includePath, 'partial.css');
@@ -431,7 +432,7 @@ test('Call refreshFiles when dependency is modified', async t => {
 });
 
 test('Call refreshFiles when dependency is deleted and added', async t => {
-  const dir = path.resolve(tmp());
+  const dir = tempy.directory();
   const fixture = path.join(dir, 'with-partial.css');
   const includePath = path.join(dir, 'partials');
   const partial = path.join(includePath, 'partial.css');