Skip to content

Commit 08f2c27

Browse files
jason-curtisRDaxinicwhanse
authored
Apply suggestions from code review
* update links for redirects * roll back some NLR -> NREL for publisher reference * fix various typos and EOF removal Co-authored-by: Rajiv Daxini <143435106+RDaxini@users.noreply.github.com> Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
1 parent 4902b20 commit 08f2c27

14 files changed

Lines changed: 22 additions & 22 deletions

File tree

docs/examples/irradiance-decomposition/plot_diffuse_fraction.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,5 +216,5 @@
216216
# correlations, which include additional variables such as airmass. These
217217
# methods seem to reduce DNI spikes over 1000 [W/m^2].
218218
#
219-
# .. _TMY3: https://www.nlr.gov/docs/fy08osti/43156.pdf
220-
# .. _NSRDB: https://www.nlr.gov/docs/fy12osti/54824.pdf
219+
# .. _TMY3: https://docs.nlr.gov/docs/fy08osti/43156.pdf
220+
# .. _NSRDB: https://docs.nlr.gov/docs/fy12osti/54824.pdf

docs/examples/spectrum/average_photon_energy.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,5 +194,5 @@
194194
# for the solar spectral influence on photovoltaic device performance."
195195
# Energy 286 :doi:`10.1016/j.energy.2023.129461`
196196
# .. [4] Bird Simple Spectral Model: spectrl2_2.c
197-
# https://www.nlr.gov/grid/solar-resource/spectral.html
198-
# (Last accessed: 18/09/2024)
197+
# https://www.nlr.gov/grid/solar-resource/spectral
198+
# (Last accessed: 03/03/2026)

docs/examples/spectrum/plot_spectrl2_fig51A.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22
Modeling Spectral Irradiance
33
============================
44
5-
Recreating Figure 5-1A from the SPECTRL2 NLR Technical Report.
5+
Recreating Figure 5-1A from the SPECTRL2 NREL Technical Report.
66
"""
77

88
# %%
99
# This example shows how to model the spectral distribution of irradiance
1010
# based on atmospheric conditions. The spectral distribution of irradiance is
1111
# the power content at each wavelength band in the solar spectrum and is
1212
# affected by various scattering and absorption mechanisms in the atmosphere.
13-
# This example recreates an example figure from the SPECTRL2 NLR Technical
13+
# This example recreates an example figure from the SPECTRL2 NREL Technical
1414
# Report [1]_. The figure shows modeled spectra at hourly intervals across
1515
# a single morning.
1616

@@ -95,5 +95,5 @@
9595
# ----------
9696
# .. [1] Bird, R, and Riordan, C., 1984, "Simple solar spectral model for
9797
# direct and diffuse irradiance on horizontal and tilted planes at the
98-
# earth's surface for cloudless atmospheres", NLR Technical Report
98+
# earth's surface for cloudless atmospheres", NREL Technical Report
9999
# TR-215-2436 :doi:`10.2172/5986936`

docs/sphinx/source/whatsnew/v0.15.1.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ Maintenance
5959
* Update all NREL references to NLR (National Laboratory of the Rockies)
6060
following the laboratory rename and domain migration from ``nrel.gov``
6161
to ``nlr.gov``. Add ``NLR_API_KEY`` environment variable support with
62-
``NREL_API_KEY`` fallback. (:issue:`2701`)
62+
``NREL_API_KEY`` fallback. (:issue:`2701`, :pull:`2705`)
6363

6464

6565
Contributors

docs/tutorials/tmy_to_power.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1657,4 +1657,4 @@
16571657
},
16581658
"nbformat": 4,
16591659
"nbformat_minor": 4
1660-
}
1660+
}

pvlib/clearsky.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1001,7 +1001,7 @@ def bird(zenith, airmass_relative, aod380, aod500, precipitable_water,
10011001
.. [2] Daryl R. Myers, "Solar Radiation: Practical Modeling for Renewable
10021002
Energy Applications", pp. 46-51 CRC Press (2013)
10031003
1004-
.. [3] `NLR Bird Clear Sky Model <http://www.nlr.gov/grid/solar-resource/
1004+
.. [3] `Bird Clear Sky Model <http://www.nlr.gov/grid/solar-resource/
10051005
clearsky.html>`_
10061006
10071007
.. [4] `SERI/TR-642-761 <https://www.nlr.gov/docs/legosti/old/761.pdf>`_

pvlib/irradiance.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def get_extra_radiation(datetime_or_doy, solar_constant=1366.1,
8989
Engineers, 2005. :doi:`10.1061/9780784408056`
9090
9191
.. [6] I. Reda, A. Andreas, "Solar position algorithm for solar
92-
radiation applications" NLR Golden, USA. NREL/TP-560-34302,
92+
radiation applications" NLR Golden, CO, USA. NREL/TP-560-34302,
9393
Revised 2008. :doi:`10.2172/15003974`
9494
"""
9595

pvlib/pvsystem.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2963,7 +2963,7 @@ def pvwatts_dc(effective_irradiance, temp_cell, pdc0, gamma_pdc, temp_ref=25.,
29632963
Module Performance," In Proc. 33rd IEEE Photovoltaic Specialists
29642964
Conference (PVSC), San Diego, CA, USA, 2008, pp. 1-6,
29652965
:doi:`10.1109/PVSC.2008.4922586`.
2966-
Pre-print: https://www.nlr.gov/docs/fy08osti/42511.pdf
2966+
Pre-print: https://docs.nlr.gov/docs/fy08osti/42511.pdf
29672967
""" # noqa: E501
29682968

29692969
pdc = (effective_irradiance * 0.001 * pdc0 *

pvlib/shading.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def masking_angle(surface_tilt, gcr, slant_height):
8787
panels", Solar Cells, Volume 11, Pages 281-291. 1984.
8888
:doi:`10.1016/0379-6787(84)90017-6`
8989
.. [2] Gilman, P. et al., (2018). "SAM Photovoltaic Model Technical
90-
Reference Update", NLR Technical Report NREL/TP-6A20-67399.
90+
Reference Update", NREL Technical Report NREL/TP-6A20-67399.
9191
Available at https://www.nlr.gov/docs/fy18osti/67399.pdf
9292
"""
9393
# The original equation (8 in [1]) requires pitch and collector width,
@@ -228,7 +228,7 @@ def sky_diffuse_passias(masking_angle):
228228
panels", Solar Cells, Volume 11, Pages 281-291. 1984.
229229
:doi:`10.1016/0379-6787(84)90017-6`
230230
.. [2] Gilman, P. et al., (2018). "SAM Photovoltaic Model Technical
231-
Reference Update", NLR Technical Report NREL/TP-6A20-67399.
231+
Reference Update", NREL Technical Report NREL/TP-6A20-67399.
232232
Available at https://www.nlr.gov/docs/fy18osti/67399.pdf
233233
"""
234234
return 1 - cosd(masking_angle/2)**2

pvlib/snow.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def fully_covered_nrel(snowfall, snow_depth=None, threshold_snowfall=1.,
5151
"Measured and modeled photovoltaic system energy losses from snow for
5252
Colorado and Wisconsin locations." Solar Energy 97; pp.112-121.
5353
.. [2] Ryberg, D; Freeman, J. "Integration, Validation, and Application
54-
of a PV Snow Coverage Model in SAM" (2017) NLR Technical Report
54+
of a PV Snow Coverage Model in SAM" (2017) NREL Technical Report
5555
NREL/TP-6A20-68705
5656
'''
5757
timestep = _time_delta_in_hours(snowfall.index)
@@ -134,7 +134,7 @@ def coverage_nrel(snowfall, poa_irradiance, temp_air, surface_tilt,
134134
"Measured and modeled photovoltaic system energy losses from snow for
135135
Colorado and Wisconsin locations." Solar Energy 97; pp.112-121.
136136
.. [2] Ryberg, D; Freeman, J. (2017). "Integration, Validation, and
137-
Application of a PV Snow Coverage Model in SAM" NLR Technical Report
137+
Application of a PV Snow Coverage Model in SAM" NREL Technical Report
138138
NREL/TP-6A20-68705
139139
'''
140140

@@ -210,7 +210,7 @@ def dc_loss_nrel(snow_coverage, num_strings):
210210
References
211211
----------
212212
.. [1] Gilman, P. et al., (2018). "SAM Photovoltaic Model Technical
213-
Reference Update", NLR Technical Report NREL/TP-6A20-67399.
213+
Reference Update", NREL Technical Report NREL/TP-6A20-67399.
214214
Available at https://www.nlr.gov/docs/fy18osti/67399.pdf
215215
'''
216216
return np.ceil(snow_coverage * num_strings) / num_strings

0 commit comments

Comments
 (0)