Apply suggestions from code review

* update links for redirects
* roll back some NLR -> NREL for publisher reference
* fix various typos and EOF removal

Co-authored-by: Rajiv Daxini <143435106+RDaxini@users.noreply.github.com>
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

Author: 3 people

docs/examples/irradiance-decomposition/plot_diffuse_fraction.py

@@ -216,5 +216,5 @@
 # correlations, which include additional variables such as airmass. These
 # methods seem to reduce DNI spikes over 1000 [W/m^2].
 #
-# .. _TMY3: https://www.nlr.gov/docs/fy08osti/43156.pdf
-# .. _NSRDB: https://www.nlr.gov/docs/fy12osti/54824.pdf
+# .. _TMY3: https://docs.nlr.gov/docs/fy08osti/43156.pdf
+# .. _NSRDB: https://docs.nlr.gov/docs/fy12osti/54824.pdf

docs/examples/spectrum/average_photon_energy.py

@@ -194,5 +194,5 @@
 #        for the solar spectral influence on photovoltaic device performance."
 #        Energy 286 :doi:`10.1016/j.energy.2023.129461`
 # .. [4] Bird Simple Spectral Model: spectrl2_2.c
-#        https://www.nlr.gov/grid/solar-resource/spectral.html
-#        (Last accessed: 18/09/2024)
+#        https://www.nlr.gov/grid/solar-resource/spectral
+#        (Last accessed: 03/03/2026)

docs/examples/spectrum/plot_spectrl2_fig51A.py

@@ -2,15 +2,15 @@
 Modeling Spectral Irradiance
 ============================
 
-Recreating Figure 5-1A from the SPECTRL2 NLR Technical Report.
+Recreating Figure 5-1A from the SPECTRL2 NREL Technical Report.
 """
 
 # %%
 # This example shows how to model the spectral distribution of irradiance
 # based on atmospheric conditions. The spectral distribution of irradiance is
 # the power content at each wavelength band in the solar spectrum and is
 # affected by various scattering and absorption mechanisms in the atmosphere.
-# This example recreates an example figure from the SPECTRL2 NLR Technical
+# This example recreates an example figure from the SPECTRL2 NREL Technical
 # Report [1]_. The figure shows modeled spectra at hourly intervals across
 # a single morning.
 
@@ -95,5 +95,5 @@
 # ----------
 # .. [1] Bird, R, and Riordan, C., 1984, "Simple solar spectral model for
 #    direct and diffuse irradiance on horizontal and tilted planes at the
-#    earth's surface for cloudless atmospheres", NLR Technical Report
+#    earth's surface for cloudless atmospheres", NREL Technical Report
 #    TR-215-2436 :doi:`10.2172/5986936`

docs/sphinx/source/whatsnew/v0.15.1.rst

@@ -59,7 +59,7 @@ Maintenance
 * Update all NREL references to NLR (National Laboratory of the Rockies)
   following the laboratory rename and domain migration from ``nrel.gov``
   to ``nlr.gov``. Add ``NLR_API_KEY`` environment variable support with
-  ``NREL_API_KEY`` fallback. (:issue:`2701`)
+  ``NREL_API_KEY`` fallback. (:issue:`2701`, :pull:`2705`)
 
 
 Contributors

docs/tutorials/tmy_to_power.ipynb

@@ -1657,4 +1657,4 @@
  },
  "nbformat": 4,
  "nbformat_minor": 4
-}
+}

pvlib/clearsky.py

@@ -1001,7 +1001,7 @@ def bird(zenith, airmass_relative, aod380, aod500, precipitable_water,
     .. [2] Daryl R. Myers, "Solar Radiation: Practical Modeling for Renewable
        Energy Applications", pp. 46-51 CRC Press (2013)
 
-    .. [3] `NLR Bird Clear Sky Model <http://www.nlr.gov/grid/solar-resource/
+    .. [3] `Bird Clear Sky Model <http://www.nlr.gov/grid/solar-resource/
        clearsky.html>`_
 
     .. [4] `SERI/TR-642-761 <https://www.nlr.gov/docs/legosti/old/761.pdf>`_

pvlib/irradiance.py

@@ -89,7 +89,7 @@ def get_extra_radiation(datetime_or_doy, solar_constant=1366.1,
        Engineers, 2005. :doi:`10.1061/9780784408056`
 
     .. [6] I. Reda, A. Andreas, "Solar position algorithm for solar
-       radiation applications" NLR Golden, USA. NREL/TP-560-34302,
+       radiation applications" NLR Golden, CO, USA. NREL/TP-560-34302,
        Revised 2008. :doi:`10.2172/15003974`
     """
 

pvlib/pvsystem.py

@@ -2963,7 +2963,7 @@ def pvwatts_dc(effective_irradiance, temp_cell, pdc0, gamma_pdc, temp_ref=25.,
        Module Performance," In Proc. 33rd IEEE Photovoltaic Specialists
        Conference (PVSC), San Diego, CA, USA, 2008, pp. 1-6,
        :doi:`10.1109/PVSC.2008.4922586`.
-       Pre-print: https://www.nlr.gov/docs/fy08osti/42511.pdf
+       Pre-print: https://docs.nlr.gov/docs/fy08osti/42511.pdf
     """  # noqa: E501
 
     pdc = (effective_irradiance * 0.001 * pdc0 *

pvlib/shading.py

@@ -87,7 +87,7 @@ def masking_angle(surface_tilt, gcr, slant_height):
        panels", Solar Cells, Volume 11, Pages 281-291.  1984.
        :doi:`10.1016/0379-6787(84)90017-6`
     .. [2] Gilman, P. et al., (2018). "SAM Photovoltaic Model Technical
-       Reference Update", NLR Technical Report NREL/TP-6A20-67399.
+       Reference Update", NREL Technical Report NREL/TP-6A20-67399.
        Available at https://www.nlr.gov/docs/fy18osti/67399.pdf
     """
     # The original equation (8 in [1]) requires pitch and collector width,
@@ -228,7 +228,7 @@ def sky_diffuse_passias(masking_angle):
        panels", Solar Cells, Volume 11, Pages 281-291.  1984.
        :doi:`10.1016/0379-6787(84)90017-6`
     .. [2] Gilman, P. et al., (2018). "SAM Photovoltaic Model Technical
-       Reference Update", NLR Technical Report NREL/TP-6A20-67399.
+       Reference Update", NREL Technical Report NREL/TP-6A20-67399.
        Available at https://www.nlr.gov/docs/fy18osti/67399.pdf
     """
     return 1 - cosd(masking_angle/2)**2

pvlib/snow.py

@@ -51,7 +51,7 @@ def fully_covered_nrel(snowfall, snow_depth=None, threshold_snowfall=1.,
        "Measured and modeled photovoltaic system energy losses from snow for
        Colorado and Wisconsin locations." Solar Energy 97; pp.112-121.
     .. [2] Ryberg, D; Freeman, J. "Integration, Validation, and Application
-       of a PV Snow Coverage Model in SAM" (2017) NLR Technical Report
+       of a PV Snow Coverage Model in SAM" (2017) NREL Technical Report
        NREL/TP-6A20-68705
     '''
     timestep = _time_delta_in_hours(snowfall.index)
@@ -134,7 +134,7 @@ def coverage_nrel(snowfall, poa_irradiance, temp_air, surface_tilt,
        "Measured and modeled photovoltaic system energy losses from snow for
        Colorado and Wisconsin locations." Solar Energy 97; pp.112-121.
     .. [2] Ryberg, D; Freeman, J. (2017). "Integration, Validation, and
-       Application of a PV Snow Coverage Model in SAM" NLR Technical Report
+       Application of a PV Snow Coverage Model in SAM" NREL Technical Report
        NREL/TP-6A20-68705
     '''
 
@@ -210,7 +210,7 @@ def dc_loss_nrel(snow_coverage, num_strings):
     References
     ----------
     .. [1] Gilman, P. et al., (2018). "SAM Photovoltaic Model Technical
-       Reference Update", NLR Technical Report NREL/TP-6A20-67399.
+       Reference Update", NREL Technical Report NREL/TP-6A20-67399.
        Available at https://www.nlr.gov/docs/fy18osti/67399.pdf
     '''
     return np.ceil(snow_coverage * num_strings) / num_strings