Apply suggestions from @AdamRJensen CR

jason-curtis · AdamRJensen · web-flow · commit 1820fdd3c083 · 2026-03-04T09:42:17.000-08:00
Co-authored-by: Adam R. Jensen &lt;39184289+AdamRJensen@users.noreply.github.com&gt;
diff --git a/docs/examples/irradiance-decomposition/plot_diffuse_fraction.py b/docs/examples/irradiance-decomposition/plot_diffuse_fraction.py
@@ -216,5 +216,5 @@
 # correlations, which include additional variables such as airmass. These
 # methods seem to reduce DNI spikes over 1000 [W/m^2].
 #
-# .. _TMY3: https://docs.nlr.gov/docs/fy08osti/43156.pdf
-# .. _NSRDB: https://docs.nlr.gov/docs/fy12osti/54824.pdf
+# .. _TMY3: https://doi.org/10.2172/928611
+# .. _NSRDB: https://doi.org/10.2172/1054832
diff --git a/docs/examples/spectrum/average_photon_energy.py b/docs/examples/spectrum/average_photon_energy.py
@@ -34,7 +34,7 @@
 from scipy.integrate import trapezoid
 from pvlib import spectrum, solarposition, irradiance, atmosphere
 
-lat, lon = 39.742, -105.18  # NLR SRRL location
+lat, lon = 39.742, -105.18  # SRRL location
 surface_tilt = 25
 surface_azimuth = 180  # south-facing system
 pressure = 81190  # at 1828 metres AMSL, roughly
diff --git a/docs/tutorials/tmy_to_power.ipynb b/docs/tutorials/tmy_to_power.ipynb
@@ -1511,7 +1511,7 @@
   {
    "cell_type": "markdown",
    "metadata": {},
-   "source": "Next, we will assume that the SAPM model is representative of the real world performance so that we can use scipy's optimization routine to derive simulated PVUSA coefficients. You will need to install scipy to run these functions.\n\nHere's one PVUSA reference:\n\nhttps://docs.nlr.gov/docs/fy09osti/45376.pdf\n"
+   "source": "Next, we will assume that the SAPM model is representative of the real world performance so that we can use scipy's optimization routine to derive simulated PVUSA coefficients. You will need to install scipy to run these functions.\n\nHere's one PVUSA reference:\n\nhttps://www.osti.gov/biblio/951223\n"
   },
   {
    "cell_type": "code",
diff --git a/pvlib/bifacial/infinite_sheds.py b/pvlib/bifacial/infinite_sheds.py
@@ -166,7 +166,7 @@ def _shaded_fraction(solar_zenith, solar_azimuth, surface_tilt,
        :doi:`10.1109/PVSC40753.2019.8980572`.
     .. [2] Kevin Anderson and Mark Mikofski, "Slope-Aware Backtracking for
        Single-Axis Trackers", Technical Report NREL/TP-5K00-76626, July 2020.
-       https://www.nlr.gov/docs/fy20osti/76626.pdf
+       :doi:`10.2172/1660126`
     """
     tan_phi = utils._solar_projection_tangent(
         solar_zenith, solar_azimuth, surface_azimuth)
diff --git a/pvlib/clearsky.py b/pvlib/clearsky.py
@@ -1004,7 +1004,7 @@ def bird(zenith, airmass_relative, aod380, aod500, precipitable_water,
     .. [3] `Bird Clear Sky Model <http://www.nlr.gov/grid/solar-resource/
        clearsky.html>`_
 
-    .. [4] `SERI/TR-642-761 <https://www.nlr.gov/docs/legosti/old/761.pdf>`_
+    .. [4] SERI/TR-642-761 :doi:`10.2172/6510849`
 
     .. [5] `Error Reports <http://www.nlr.gov/grid/solar-resource/
        clearsky-error-reports.html>`_
diff --git a/pvlib/inverter.py b/pvlib/inverter.py
@@ -388,7 +388,7 @@ def pvwatts(pdc, pdc0, eta_inv_nom=0.96, eta_inv_ref=0.9637):
 
     References
     ----------
-    .. [1] A. P. Dobos, "PVWatts Version 5 Manual", NLR, Golden, CO, USA,
+    .. [1] A. P. Dobos, "PVWatts Version 5 Manual", NREL, Golden, CO, USA,
        Technical Report NREL/TP-6A20-62641, 2014, :doi:`10.2172/1158421`.
     """
 
diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py
@@ -89,7 +89,7 @@ def get_extra_radiation(datetime_or_doy, solar_constant=1366.1,
        Engineers, 2005. :doi:`10.1061/9780784408056`
 
     .. [6] I. Reda, A. Andreas, "Solar position algorithm for solar
-       radiation applications" NLR Golden, CO, USA. NREL/TP-560-34302,
+       radiation applications" NREL Golden, CO, USA. NREL/TP-560-34302,
        Revised 2008. :doi:`10.2172/15003974`
     """
 
diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py
@@ -2963,7 +2963,7 @@ def pvwatts_dc(effective_irradiance, temp_cell, pdc0, gamma_pdc, temp_ref=25.,
        Module Performance," In Proc. 33rd IEEE Photovoltaic Specialists
        Conference (PVSC), San Diego, CA, USA, 2008, pp. 1-6,
        :doi:`10.1109/PVSC.2008.4922586`.
-       https://docs.nlr.gov/docs/fy08osti/42511.pdf
+       Pre-print: :doi:`10.1109/PVSC.2008.4922586`
     """  # noqa: E501
 
     pdc = (effective_irradiance * 0.001 * pdc0 *
diff --git a/pvlib/shading.py b/pvlib/shading.py
@@ -88,7 +88,7 @@ def masking_angle(surface_tilt, gcr, slant_height):
        :doi:`10.1016/0379-6787(84)90017-6`
     .. [2] Gilman, P. et al., (2018). "SAM Photovoltaic Model Technical
        Reference Update", NREL Technical Report NREL/TP-6A20-67399.
-       Available at https://www.nlr.gov/docs/fy18osti/67399.pdf
+       :doi:`10.2172/1429291`
     """
     # The original equation (8 in [1]) requires pitch and collector width,
     # but it's easy to non-dimensionalize it to make it a function of GCR
@@ -229,7 +229,7 @@ def sky_diffuse_passias(masking_angle):
        :doi:`10.1016/0379-6787(84)90017-6`
     .. [2] Gilman, P. et al., (2018). "SAM Photovoltaic Model Technical
        Reference Update", NREL Technical Report NREL/TP-6A20-67399.
-       Available at https://www.nlr.gov/docs/fy18osti/67399.pdf
+       :doi:`10.2172/1429291`
     """
     return 1 - cosd(masking_angle/2)**2
 
@@ -304,7 +304,7 @@ def projected_solar_zenith_angle(solar_zenith, solar_azimuth,
     References
     ----------
     .. [1] K. Anderson and M. Mikofski, 'Slope-Aware Backtracking for
-       Single-Axis Trackers', National Laboratory of the Rockies (NLR), Golden,
+       Single-Axis Trackers', National Renewable Energy Lab. (NREL), Golden,
        CO (United States);
        NREL/TP-5K00-76626, Jul. 2020. :doi:`10.2172/1660126`.
 
diff --git a/pvlib/snow.py b/pvlib/snow.py
@@ -320,7 +320,7 @@ def loss_townsend(snow_total, snow_events, surface_tilt, relative_humidity,
         Uses of the Townsend Snow Model. In "Photovoltaic Reliability
         Workshop (PVRW) 2023 Proceedings: Posters.", ed. Silverman,
         T. J. Dec. 2023. NREL/CP-5900-87918.
-        Available at: https://www.nlr.gov/docs/fy25osti/90585.pdf
+        :doi:`10.2172/1429291`
     .. [3] Townsend, T. (2013). Predicting PV Energy Loss Caused by Snow.
         Solar Power International, Chicago IL.
         :doi:`10.13140/RG.2.2.14299.68647`
diff --git a/pvlib/spa_c_files/README.md b/pvlib/spa_c_files/README.md
@@ -2,7 +2,7 @@ README
 ------
 
 NLR provides a C implementation of the solar position algorithm described in
-[Reda, I.; Andreas, A. (2003). Solar Position Algorithm for Solar Radiation Applications. 55 pp.; NREL Report No. TP-560-34302](http://www.nlr.gov/docs/fy08osti/34302.pdf).
+Reda, I.; Andreas, A. (2003). Solar Position Algorithm for Solar Radiation Applications. 55 pp.; NREL Report No. TP-560-34302. :doi:`10.2172/15003974`
 
 This folder contains the files required to make SPA C code accessible
 to the `pvlib-python` package. We use the Cython package to wrap the NLR SPA
diff --git a/pvlib/spectrum/mismatch.py b/pvlib/spectrum/mismatch.py
@@ -231,7 +231,7 @@ def spectral_factor_firstsolar(precipitable_water, airmass_absolute,
        Water." IEEE Photovoltaic Specialists Conference, Portland, 2016
     .. [3] Marion, William F., et al. User's Manual for Data for Validating
        Models for PV Module Performance. National Renewable Energy
-       Laboratory, 2014. http://www.nlr.gov/docs/fy14osti/61610.pdf
+       Laboratory, 2014. :doi:`10.2172/1130632`
     .. [4] Schweiger, M. and Hermann, W, Influence of Spectral Effects
        on Energy Yield of Different PV Modules: Comparison of Pwat and
        MMF Approach, TUV Rheinland Energy GmbH report 21237296.003,
diff --git a/pvlib/tracking.py b/pvlib/tracking.py
@@ -114,7 +114,7 @@ def singleaxis(apparent_zenith, solar_azimuth,
     ----------
     .. [1] Anderson, K., and Mikofski, M., "Slope-Aware Backtracking for
        Single-Axis Trackers", Technical Report NREL/TP-5K00-76626, July 2020.
-       https://www.nlr.gov/docs/fy20osti/76626.pdf
+       :doi:`10.2172/1660126`
     .. [2] Lorenzo, E., Narvarte, L., and Muñoz, J. (2011). Tracking and
        back-tracking 19(6), 747–753. :doi:`10.1002/pip.1085`
     """
@@ -299,7 +299,7 @@ def calc_axis_tilt(slope_azimuth, slope_tilt, axis_azimuth):
     ----------
     .. [1] Kevin Anderson and Mark Mikofski, "Slope-Aware Backtracking for
        Single-Axis Trackers", Technical Report NREL/TP-5K00-76626, July 2020.
-       https://www.nlr.gov/docs/fy20osti/76626.pdf
+       :doi:`10.2172/1660126`
     """
     delta_gamma = axis_azimuth - slope_azimuth
     # equations 18-19
@@ -408,7 +408,7 @@ def calc_cross_axis_tilt(
     ----------
     .. [1] Kevin Anderson and Mark Mikofski, "Slope-Aware Backtracking for
        Single-Axis Trackers", Technical Report NREL/TP-5K00-76626, July 2020.
-       https://www.nlr.gov/docs/fy20osti/76626.pdf
+       :doi:`10.2172/1660126`
     """
     # delta-gamma, difference between axis and slope azimuths
     delta_gamma = axis_azimuth - slope_azimuth
diff --git a/tests/test_tracking.py b/tests/test_tracking.py
@@ -345,7 +345,7 @@ def test_calc_axis_tilt():
 
 def test_slope_aware_backtracking():
     """
-    Test validation data set from https://www.nlr.gov/docs/fy20osti/76626.pdf
+    Test validation data set from https://doi.org/10.2172/1660126
     """
     index = pd.date_range('2019-01-01T08:00', '2019-01-01T17:00', freq='h')
     index = index.tz_localize('Etc/GMT+5')

Original file line number	Diff line number	Diff line change
`@@ -216,5 +216,5 @@`
`216`	`216`	`# correlations, which include additional variables such as airmass. These`
`217`	`217`	`# methods seem to reduce DNI spikes over 1000 [W/m^2].`
`218`	`218`	`#`
`219`		`-# .. _TMY3: https://docs.nlr.gov/docs/fy08osti/43156.pdf`
`220`		`-# .. _NSRDB: https://docs.nlr.gov/docs/fy12osti/54824.pdf`
	`219`	`+# .. _TMY3: https://doi.org/10.2172/928611`
	`220`	`+# .. _NSRDB: https://doi.org/10.2172/1054832`
Original file line number	Diff line number	Diff line change
`@@ -1511,7 +1511,7 @@`
`1511`	`1511`	`{`
`1512`	`1512`	`"cell_type": "markdown",`
`1513`	`1513`	`"metadata": {},`
`1514`		`- "source": "Next, we will assume that the SAPM model is representative of the real world performance so that we can use scipy's optimization routine to derive simulated PVUSA coefficients. You will need to install scipy to run these functions.\n\nHere's one PVUSA reference:\n\nhttps://docs.nlr.gov/docs/fy09osti/45376.pdf\n"`
	`1514`	`+ "source": "Next, we will assume that the SAPM model is representative of the real world performance so that we can use scipy's optimization routine to derive simulated PVUSA coefficients. You will need to install scipy to run these functions.\n\nHere's one PVUSA reference:\n\nhttps://www.osti.gov/biblio/951223\n"`
`1515`	`1515`	`},`
`1516`	`1516`	`{`
`1517`	`1517`	`"cell_type": "code",`