[Issue-1961]: Handle clippy::explicit_iter_loop (tensorzero#2813)

* [Issue-1961]: Handle clippy::explicit_iter_loop

* Remove cfg of e2e test field

Author: michaldorsett

Cargo.toml

@@ -74,6 +74,7 @@ unsafe_code = "forbid"
 allow_attributes = "deny"
 dbg_macro = "deny"
 expect_used = "deny"
+explicit_iter_loop = "deny"
 if_not_else = "deny"
 ignored_unit_patterns = "deny"
 manual_string_new = "deny"

evaluations/src/helpers.rs

@@ -27,7 +27,7 @@ pub async fn get_tool_params_args(
         FunctionConfig::Chat(function_config) => {
             let mut additional_tools = Vec::new();
             let mut allowed_tools = Vec::new();
-            for tool in tool_params.tools_available.iter() {
+            for tool in &tool_params.tools_available {
                 if function_config.tools.contains(&tool.name) {
                     allowed_tools.push(tool.name.clone());
                 } else {

evaluations/src/stats.rs

@@ -77,8 +77,8 @@ impl EvaluationStats {
         debug!(evaluators = ?evaluators.keys().collect::<Vec<_>>(), "Initialized data collectors for evaluators");
         // Collect evaluation inference data into vectors by evaluation (all as floats)
         debug!("Processing evaluation results into statistics");
-        for evaluation_info in self.evaluation_infos.iter() {
-            for (evaluation_name, evaluation_result) in evaluation_info.evaluations.iter() {
+        for evaluation_info in &self.evaluation_infos {
+            for (evaluation_name, evaluation_result) in &evaluation_info.evaluations {
                 match evaluation_result {
                     Some(Value::Number(n)) => {
                         if let Some(data_vec) = data.get_mut(evaluation_name) {

examples/integrations/cursor/feedback/src/ted/mod.rs

@@ -202,7 +202,7 @@ impl<'tree, L: Eq> Tree<'tree, L> {
     ) -> Self {
         let key_roots = Self::compute_key_roots(left_most_leaf_descendant_root, parent_offset);
         debug_assert!(!key_roots.is_empty(), "key_roots must have ≥1 node");
-        for root in key_roots.iter() {
+        for root in &key_roots {
             debug_assert!(*root < post.len(), "key_root must be within bounds");
         }
         debug_assert_eq!(

internal/tensorzero-derive/src/lib.rs

@@ -119,9 +119,9 @@ pub fn tensorzero_derive(input: TokenStream) -> TokenStream {
     // other derive macros (e.g. `#[strum]`0. We're not applying any derive macros
     // to our new enum, so we need to avoid copying over other attributes to prevent errors.
     let mut stripped_variants = data.variants.clone();
-    for variant in stripped_variants.iter_mut() {
+    for variant in &mut stripped_variants {
         variant.attrs.retain(|attr| attr.path().is_ident("serde"));
-        for field in variant.fields.iter_mut() {
+        for field in &mut variant.fields {
             field.attrs.retain(|attr| attr.path().is_ident("serde"));
         }
     }

tensorzero-core/src/clickhouse/mod.rs

@@ -659,7 +659,7 @@ fn set_clickhouse_format_settings(database_url: &mut Url) {
         }
     }
 
-    for setting in OVERRIDDEN_SETTINGS.iter() {
+    for setting in &OVERRIDDEN_SETTINGS {
         database_url.query_pairs_mut().append_pair(setting, "0");
     }
     database_url.query_pairs_mut().finish();

tensorzero-core/src/config_parser/mod.rs

@@ -977,7 +977,7 @@ impl UninitializedFunctionConfig {
                     .into_iter()
                     .map(|(name, variant)| variant.load().map(|v| (name, Arc::new(v))))
                     .collect::<Result<HashMap<_, _>, Error>>()?;
-                for (name, variant) in variants.iter() {
+                for (name, variant) in &variants {
                     if let VariantConfig::ChatCompletion(chat_config) = &variant.inner {
                         if chat_config.json_mode.is_some() {
                             return Err(ErrorDetails::Config {
@@ -1025,7 +1025,7 @@ impl UninitializedFunctionConfig {
                     .map(|(name, variant)| variant.load().map(|v| (name, Arc::new(v))))
                     .collect::<Result<HashMap<_, _>, Error>>()?;
 
-                for (name, variant) in variants.iter() {
+                for (name, variant) in &variants {
                     let mut warn_variant = None;
                     match &variant.inner {
                         VariantConfig::ChatCompletion(chat_config) => {

tensorzero-core/src/endpoints/dynamic_evaluation_run.rs

@@ -141,7 +141,7 @@ pub fn validate_variant_pins(
     variant_pins: &HashMap<String, String>,
     config: &Config,
 ) -> Result<(), Error> {
-    for (function_name, variant_name) in variant_pins.iter() {
+    for (function_name, variant_name) in variant_pins {
         let function_config = config.get_function(function_name)?;
         function_config
             .variants()

tensorzero-core/src/function.rs

@@ -477,7 +477,7 @@ impl FunctionConfig {
         }
         match self {
             FunctionConfig::Chat(params) => {
-                for tool in params.tools.iter() {
+                for tool in &params.tools {
                     static_tools.get(tool).ok_or_else(|| Error::new(ErrorDetails::Config {
                         message: format!("`functions.{function_name}.tools`: tool `{tool}` is not present in the config"),
                     }))?;
@@ -546,7 +546,7 @@ fn validate_all_text_input(
     }?;
     for (index, message) in input.messages.iter().enumerate() {
         // Only for Text blocks, not RawText blocks since we don't validate those
-        for block in message.content.iter() {
+        for block in &message.content {
             if let InputMessageContent::Text(kind) = block {
                 let content = match kind {
                     TextKind::Arguments { arguments } => {

tensorzero-core/src/providers/aws_http_client.rs

@@ -153,7 +153,7 @@ impl HttpConnector for ReqwestConnector {
             );
             // Copy the header, body, and timeout.
             let parts = request.into_parts();
-            for (name, value) in parts.headers.iter() {
+            for (name, value) in &parts.headers {
                 let name = name.to_owned();
                 let value = value.as_bytes().to_owned();
                 req_builder = req_builder.header(name, value);