Clean up handling of strings vs bytes a little bit.

Author: dan-blanchard

drmaa/helpers.py

@@ -45,11 +45,6 @@
                             drmaa_set_attribute, drmaa_set_vector_attribute,
                             drmaa_version, STRING)
 
-# Python 3 compatability help
-if sys.version_info < (3, 0):
-    bytes = str
-    str = unicode
-
 
 _BUFLEN = ATTR_BUFFER
 
@@ -59,10 +54,10 @@ class BoolConverter(object):
     """Helper class to convert to/from bool attributes."""
 
     def __init__(self, true=b'y', false=b'n'):
-        if isinstance(true, str):
+        if not isinstance(true, bytes):
             true = true.encode()
         self.true = true
-        if isinstance(false, str):
+        if not isinstance(false, bytes):
             false = false.encode()
         self.false = false
 
@@ -137,15 +132,15 @@ def __init__(self, name, type_converter=None):
            a converter to translate attribute values to/from the underlying
            implementation. See BoolConverter for an example.
         """
-        if isinstance(name, str):
+        if not isinstance(name, bytes):
             name = name.encode()
         self.name = name
         self.converter = type_converter
 
     def __set__(self, instance, value):
         if self.converter:
             v = self.converter.to_drmaa(value)
-        elif isinstance(value, str):
+        elif not isinstance(value, bytes):
             v = value.encode()
         else:
             v = value
@@ -172,7 +167,7 @@ class VectorAttribute(object):
     """
 
     def __init__(self, name):
-        if isinstance(name, str):
+        if not isinstance(name, bytes):
             name = name.encode()
         self.name = name
 
@@ -193,7 +188,7 @@ class DictAttribute(object):
     """
 
     def __init__(self, name):
-        if isinstance(name, str):
+        if not isinstance(name, bytes):
             name = name.encode()
         self.name = name
 

drmaa/session.py

@@ -55,12 +55,6 @@
                         wasAborted exitStatus resourceUsage""")
 
 
-# Python 3 compatability help
-if sys.version_info < (3, 0):
-    bytes = str
-    str = unicode
-
-
 class JobTemplate(object):
 
     """A job to be submitted to the DRM."""
@@ -374,7 +368,7 @@ def control(jobId, operation):
         jobs submitted by other DRMAA session in other DRMAA implementations
         or jobs submitted via native utilities.
         """
-        if isinstance(jobId, str):
+        if not isinstance(jobId, bytes):
             jobId = jobId.encode()        
         c(drmaa_control, jobId, string_to_control_action(operation))
 
@@ -459,7 +453,7 @@ def wait(jobId, timeout=-1):
         stat = c_int()
         jid_out = create_string_buffer(128)
         rusage = pointer(POINTER(drmaa_attr_values_t)())
-        if isinstance(jobId, str):
+        if not isinstance(jobId, bytes):
             jobId = jobId.encode()                
         c(drmaa_wait, jobId, jid_out, sizeof(jid_out), byref(stat), timeout, 
           rusage)
@@ -507,7 +501,7 @@ def jobStatus(jobId):
         jobs return a FAILED status.
         """
         status = c_int()
-        if isinstance(jobId, str):
+        if not isinstance(jobId, bytes):
             jobId = jobId.encode()        
         c(drmaa_job_ps, jobId, byref(status))
         return status_to_string(status.value)