Skip to content

Commit 7f435cc

Browse files
committed
Fix option parsing issues in function
1 parent 752d647 commit 7f435cc

2 files changed

Lines changed: 15 additions & 2 deletions

File tree

cmake/FindSphinx.cmake

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,15 @@ if (Sphinx_FOUND AND NOT TARGET Sphinx::Build)
5454
cmake_parse_arguments(
5555
PARSE_ARGV 1 ""
5656
"ALL;SHOW_TRACEBACK;WRITE_ALL;FRESH_ENV;ISOLATED"
57-
"BUILDER;CONFIG_DIRECTORY;SOURCE_DIRECTORY;OUTPUT_DIRECTORY"
57+
"COMMENT;BUILDER;CONFIG_DIRECTORY;SOURCE_DIRECTORY;OUTPUT_DIRECTORY"
5858
"DEFINE;DEPENDS")
5959

6060
# Ensure that target should be added to the default build target,
6161
# if required.
6262
if(_ALL)
63-
set(_ALL ALL)
63+
set(_ALL "ALL")
64+
else()
65+
set(_ALL "")
6466
endif()
6567

6668
# Default working directory to current source path if none is provided.

doc/release/release_notes.rst

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,17 @@
44
Release Notes
55
*************
66

7+
.. release:: Upcoming
8+
9+
.. change:: fixed
10+
11+
Fixed the :func:`sphinx_add_docs` to prevent setting incorrect
12+
attribute when the "ALL" option is not set.
13+
14+
.. change:: fixed
15+
16+
Fixed the :func:`sphinx_add_docs` to add missing "COMMENT" option.
17+
718
.. release:: 0.2.0
819
:date: 2024-08-09
920

0 commit comments

Comments
 (0)