Merge pull request #163 from python-cmd2/refactor_shell

Refactor shell command

Author: tleonhardt

CHANGES.md

@@ -22,6 +22,7 @@ News
     * ``load`` command has better error checking and reporting
     * Clipboard copy and paste functionality is now handled by the **pyperclip** module
         * NOTE: This adds an additional required 3rd-party dependency
+    * ``shell`` command now supports redirection and piping of output
     * Added a lot of unit tests
 
 0.7.3

cmd2.py

@@ -479,9 +479,7 @@ def __init__(self, completekey='tab', stdin=None, stdout=None, use_ipython=False
         self.initial_stdout = sys.stdout
         self.history = History()
         self.pystate = {}
-        # noinspection PyUnresolvedReferences
-        self.keywords = self.reserved_words + [fname[3:] for fname in dir(self)
-                                               if fname.startswith('do_')]
+        self.keywords = self.reserved_words + [fname[3:] for fname in dir(self) if fname.startswith('do_')]
         self.parser_manager = ParserManager(redirector=self.redirector, terminators=self.terminators,
                                             multilineCommands=self.multilineCommands,
                                             legalChars=self.legalChars, commentGrammars=self.commentGrammars,
@@ -1138,12 +1136,12 @@ def do_pause(self, text):
     Usage:  pause [text]"""
         sm.input(text + '\n')
 
-    # noinspection PyMethodMayBeStatic
     def do_shell(self, command):
         """Execute a command as if at the OS prompt.
 
     Usage:  shell <command> [arguments]"""
-        os.system(command)
+        proc = subprocess.Popen(command, stdout=self.stdout, stderr=sys.stderr, shell=True)
+        proc.communicate()
 
     def path_complete(self, text, line, begidx, endidx, dir_exe_only=False, dir_only=False):
         """Method called to complete an input line by local file system path completion.

tests/test_cmd2.py

@@ -103,12 +103,10 @@ def test_base_set_not_supported(base_app, capsys):
 
 def test_base_shell(base_app, monkeypatch):
     m = mock.Mock()
-    monkeypatch.setattr("os.system", m)
+    monkeypatch.setattr("subprocess.Popen", m)
     out = run_cmd(base_app, 'shell echo a')
     assert out == []
     assert m.called
-    m.assert_called_with('echo a')
-
 
 def test_base_py(base_app, capsys):
     run_cmd(base_app, 'py qqq=3')