rename a parameter and a function

Author: why-arong

pymysqlreplication/binlogstream.py

@@ -143,7 +143,7 @@ def __init__(self, connection_settings, server_id,
                  is_mariadb=False,
                  annotate_rows_event=False,
                  ignore_decode_errors=False,
-                 use_crc32=False,):
+                 verify_checksum=False,):
         """
         Attributes:
             ctl_connection_settings: Connection settings for cluster holding
@@ -185,7 +185,7 @@ def __init__(self, connection_settings, server_id,
                     used with 'is_mariadb'
             ignore_decode_errors: If true, any decode errors encountered 
                                   when reading column data will be ignored.
-            use_crc32: If true, use CRC32 4-byte for events validation, ensuring data integrity.
+            verify_checksum: If true, verify events read from the binary log by examining checksums.
         """
 
         self.__connection_settings = connection_settings
@@ -208,7 +208,7 @@ def __init__(self, connection_settings, server_id,
             only_events, ignored_events, filter_non_implemented_events)
         self.__fail_on_table_metadata_unavailable = fail_on_table_metadata_unavailable
         self.__ignore_decode_errors = ignore_decode_errors
-        self.__use_crc32 = use_crc32
+        self.__verify_checksum = verify_checksum
 
         # We can't filter on packet level TABLE_MAP and rotate event because
         # we need them for handling other operations
@@ -539,7 +539,7 @@ def fetchone(self):
                                                self.__freeze_schema,
                                                self.__fail_on_table_metadata_unavailable,
                                                self.__ignore_decode_errors,
-                                               self.__use_crc32,)
+                                               self.__verify_checksum,)
 
             if binlog_event.event_type == ROTATE_EVENT:
                 self.log_pos = binlog_event.event.position

pymysqlreplication/event.py

@@ -18,7 +18,7 @@ def __init__(self, from_packet, event_size, table_map, ctl_connection,
                  freeze_schema=False,
                  fail_on_table_metadata_unavailable=False,
                  ignore_decode_errors=False,
-                 use_crc32=False,):
+                 verify_checksum=False,):
         self.packet = from_packet
         self.table_map = table_map
         self.event_type = self.packet.event_type
@@ -28,22 +28,22 @@ def __init__(self, from_packet, event_size, table_map, ctl_connection,
         self.mysql_version = mysql_version
         self._fail_on_table_metadata_unavailable = fail_on_table_metadata_unavailable
         self._ignore_decode_errors = ignore_decode_errors
-        self._use_crc32 = use_crc32
+        self._verify_checksum = verify_checksum
         self._is_event_valid = None
         # The event have been fully processed, if processed is false
         # the event will be skipped
         self._processed = True
         self.complete = True
-        self._validate_event()
+        self._verify_event()
 
     def _read_table_id(self):
         # Table ID is 6 byte
         # pad little-endian number
         table_id = self.packet.read(6) + b"\x00\x00"
         return struct.unpack('<Q', table_id)[0]
 
-    def _validate_event(self):
-        if not self._use_crc32:
+    def _verify_event(self):
+        if not self._verify_checksum:
             return
 
         self.packet.rewind(1)

pymysqlreplication/packet.py

@@ -106,7 +106,7 @@ def __init__(self, from_packet, table_map,
                  freeze_schema,
                  fail_on_table_metadata_unavailable,
                  ignore_decode_errors,
-                 use_crc32,):
+                 verify_checksum,):
         # -1 because we ignore the ok byte
         self.read_bytes = 0
         # Used when we want to override a value in the data buffer
@@ -136,7 +136,7 @@ def __init__(self, from_packet, table_map,
         if use_checksum:
             event_size_without_header = self.event_size - 23
         else:
-            use_crc32 = False
+            verify_checksum = False
             event_size_without_header = self.event_size - 19
 
         self.event = None
@@ -154,7 +154,7 @@ def __init__(self, from_packet, table_map,
                                  freeze_schema=freeze_schema,
                                  fail_on_table_metadata_unavailable=fail_on_table_metadata_unavailable,
                                  ignore_decode_errors=ignore_decode_errors,
-                                 use_crc32=use_crc32)
+                                 verify_checksum=verify_checksum)
         if self.event._processed == False:
             self.event = None
 

pymysqlreplication/tests/test_basic.py

@@ -539,13 +539,13 @@ def create_binlog_packet_wrapper(pkt):
                                        self.stream._BinLogStreamReader__freeze_schema,
                                        self.stream._BinLogStreamReader__fail_on_table_metadata_unavailable,
                                        self.stream._BinLogStreamReader__ignore_decode_errors,
-                                       self.stream._BinLogStreamReader__use_crc32,)
+                                       self.stream._BinLogStreamReader__verify_checksum,)
         self.stream.close()
         self.stream = BinLogStreamReader(
             self.database,
             server_id=1024,
             blocking=False,
-            use_crc32=True
+            verify_checksum=True
         )
         # For event data, refer to the official document example data of mariaDB.
         # https://mariadb.com/kb/en/query_event/#example-with-crc32