Added a comment on the timeout in test_client_certificate.

sasozivanovic · sasozivanovic · commit 1356ae51c71a · 2026-03-29T07:28:30.000+02:00
diff --git a/src/trio/_tests/test_ssl.py b/src/trio/_tests/test_ssl.py
@@ -587,6 +587,8 @@ def client() -> None:
         # thread therefore finishes, setting client_done.  With the old
         # _ssl.py, the thread hangs and will be abandoned after the timeout,
         # leaving client_done unset and thereby triggering the assertion error.
+        # (The general timeout imposed on tests is not only too long for this,
+        # but it also doesn't work, because the thread is not abandoned.)
         #
         # Potential problem: determinism.  It is highly unlikely but I guess it
         # could happen that the client thread doesn't get from .recv to

Original file line number	Diff line number	Diff line change
`@@ -587,6 +587,8 @@ def client() -> None:`
`587`	`587`	`# thread therefore finishes, setting client_done. With the old`
`588`	`588`	`# _ssl.py, the thread hangs and will be abandoned after the timeout,`
`589`	`589`	`# leaving client_done unset and thereby triggering the assertion error.`
	`590`	`+ # (The general timeout imposed on tests is not only too long for this,`
	`591`	`+ # but it also doesn't work, because the thread is not abandoned.)`
`590`	`592`	`#`
`591`	`593`	`# Potential problem: determinism. It is highly unlikely but I guess it`
`592`	`594`	`# could happen that the client thread doesn't get from .recv to`