make log files group writable; resolves #62

Author: dhellmann

docs/en/history.rst

@@ -11,6 +11,8 @@ dev
     but I no longer have a development environment set up for testing
     them, so I do not officially support them.
   - Shortcut initialization if it has run before.
+  - Set hook log file permissions to be group-writable. (:bbissue:`62`
+    reported by :bbuser:`hedgeddown`)
 
 2.10.1
 

tests/test_log_dir.sh

@@ -17,6 +17,15 @@ test_set_by_user() {
     assertTrue "Log file was not created" "[ -f $WORKON_HOME/logs/hook.log ]"
 }
 
+test_file_permissions() {
+    export VIRTUALENVWRAPPER_LOG_DIR="$WORKON_HOME/logs"
+    mkdir -p "$VIRTUALENVWRAPPER_LOG_DIR"
+    source "$test_dir/../virtualenvwrapper.sh"
+    perms=$(ls -l "$WORKON_HOME/logs/hook.log" | cut -f1 -d' ')
+    #echo $perms
+    assertTrue "Log file permissions are wrong: $perms" "echo $perms | grep '^-rw-rw'"
+}
+
 test_not_set_by_user() {
     unset WORKON_HOME
     unset VIRTUALENVWRAPPER_LOG_DIR

virtualenvwrapper/hook_loader.py

@@ -15,6 +15,15 @@
 
 import pkg_resources
 
+class GroupWriteRotatingFileHandler(logging.handlers.RotatingFileHandler):
+    """Taken from http://stackoverflow.com/questions/1407474/does-python-logging-handlers-rotatingfilehandler-allow-creation-of-a-group-writa
+    """
+    def _open(self):
+        prevumask = os.umask(0o002)
+        rtv = logging.handlers.RotatingFileHandler._open(self)
+        os.umask(prevumask)
+        return rtv
+
 def main():
     parser = optparse.OptionParser(
         usage='usage: %prog [options] <hook> [<arguments>]',
@@ -66,7 +75,7 @@ def main():
 
     # Set up logging to a file
     root_logger.setLevel(logging.DEBUG)
-    file_handler = logging.handlers.RotatingFileHandler(
+    file_handler = GroupWriteRotatingFileHandler(
         os.path.expandvars(os.path.join('$VIRTUALENVWRAPPER_LOG_DIR', 'hook.log')),
         maxBytes=10240,
         backupCount=1,