Skip to content

gh-149981: Test lazy import corner cases with module-level __getattr__#149982

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-149981
May 21, 2026
Merged

gh-149981: Test lazy import corner cases with module-level __getattr__#149982
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-149981

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented May 18, 2026

Copy link
Copy Markdown
Contributor

@DinoV DinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of feel like the warning case is unnecessary - really it's just making sure the code is running as nothing special happens w/ warnings at the boundary. But I don't have a strong objection to it.

@sobolevn
Copy link
Copy Markdown
Member Author

I think that warnings are special and common enough to have a separate test case for them :)

@sobolevn sobolevn merged commit 6dbf4ba into python:main May 21, 2026
59 checks passed
@miss-islington-app
Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6dbf4ba403cd38d0219d3c7514f61c2ac8f6a74f 3.15

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 21, 2026

GH-150185 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 21, 2026
sobolevn added a commit that referenced this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants