Skip to content

Commit 241bfa7

Browse files
Daniel SperberDaraan
authored andcommitted
refinement
1 parent 2bc51ed commit 241bfa7

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

peps/pep-0821.rst

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ callback protocol whose ``__call__`` method is defined as
139139
``def __call__(self, **kwargs: Unpack[TD]) -> R: ...``.
140140
All rules — handling of required and optional keys, ``extra_items``,
141141
``closed``, assignment compatibility — follow from this equivalence per
142-
:pep:`692`, :pep:`728`, and other existing typing specifications related to
142+
:pep:`692`, :pep:`728`, and other existing typing specifications related to
143143
``Protocol`` and ``**kwargs`` unpacking through ``TypedDict``.
144144
When positional parameters precede ``Unpack[TD]``, as in
145145
``Callable[[int, str, Unpack[TD]], R]``, the same equivalence applies with
@@ -267,7 +267,7 @@ Rejected Ideas
267267
class TD1(TypedDict):
268268
a: int
269269
b: int
270-
270+
271271
class TD2(TypedDict):
272272
b: str
273273

@@ -309,8 +309,7 @@ Open Questions
309309
:pep:`692` did not address generic ``TypedDict`` in ``**kwargs``, and
310310
the rules remain an open ambiguity in the typing spec. If the equivalence
311311
principle applies, the rules should follow from the callback protocol
312-
equivalent — but it is unclear whether type checkers can currently reason
313-
about this correctly.
312+
equivalent.
314313

315314

316315
Acknowledgements
@@ -319,9 +318,9 @@ Acknowledgements
319318
Thanks to Jelle Zijlstra for sponsoring this PEP and his valuable review
320319
feedback.
321320

322-
Hugo van Kemenade, for helpful feedback on the draft and PR of this PEP.
321+
Eric Traut, for careful review, detailed feedback, and valuable input.
323322

324-
Eric Traut, for feedback on the initial idea and discussions.
323+
Hugo van Kemenade, for helpful feedback on the draft and PR of this PEP.
325324

326325

327326
References

0 commit comments

Comments
 (0)