From bd767d217060fe1f9076bab073f2f1e2ee291dd8 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Wed, 21 Oct 2026 12:12:15 +0200 Subject: [PATCH 1/3] Remove socket.makefile fallback overload --- stdlib/socket.pyi | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/stdlib/socket.pyi b/stdlib/socket.pyi index 4731aeab82c1..7bfbf45001a4 100644 --- a/stdlib/socket.pyi +++ b/stdlib/socket.pyi @@ -1499,16 +1499,6 @@ class socket(_socket.socket): newline: str | None = None, ) -> BufferedWriter: ... @overload - def makefile( - self, - mode: Literal["b", "rb", "br", "wb", "bw", "rwb", "rbw", "wrb", "wbr", "brw", "bwr"], - buffering: int, - *, - encoding: str | None = None, - errors: str | None = None, - newline: str | None = None, - ) -> IOBase: ... - @overload def makefile( self, mode: Literal["r", "w", "rw", "wr", ""] = "r", From 94969912efc632ae486bf346e51c41b6133057f7 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Wed, 21 Oct 2026 12:14:36 +0200 Subject: [PATCH 2/3] Remove unnecessary import --- stdlib/socket.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stdlib/socket.pyi b/stdlib/socket.pyi index 7bfbf45001a4..c61021aa4066 100644 --- a/stdlib/socket.pyi +++ b/stdlib/socket.pyi @@ -136,7 +136,7 @@ from _socket import ( from _typeshed import ReadableBuffer, Unused, WriteableBuffer from collections.abc import Iterable from enum import IntEnum, IntFlag -from io import BufferedReader, BufferedRWPair, BufferedWriter, IOBase, RawIOBase, TextIOWrapper +from io import BufferedReader, BufferedRWPair, BufferedWriter, RawIOBase, TextIOWrapper from typing import Any, Final, Literal, Protocol, SupportsIndex, TypeAlias, overload, type_check_only from typing_extensions import Self From 54a5e50628a65ae06106312b1bd6fcdce5018d18 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Wed, 21 Oct 2026 12:25:48 +0200 Subject: [PATCH 3/3] Restore overload, but return union --- stdlib/socket.pyi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/stdlib/socket.pyi b/stdlib/socket.pyi index c61021aa4066..e8d8f1a0d424 100644 --- a/stdlib/socket.pyi +++ b/stdlib/socket.pyi @@ -1499,6 +1499,16 @@ class socket(_socket.socket): newline: str | None = None, ) -> BufferedWriter: ... @overload + def makefile( + self, + mode: Literal["b", "rb", "br", "wb", "bw", "rwb", "rbw", "wrb", "wbr", "brw", "bwr"], + buffering: int, + *, + encoding: str | None = None, + errors: str | None = None, + newline: str | None = None, + ) -> SocketIO | BufferedRWPair | BufferedReader | BufferedWriter: ... + @overload def makefile( self, mode: Literal["r", "w", "rw", "wr", ""] = "r",