Fix SpriteList.pop exception type on empty (#2103)

* Use IndexError instead of ValueError on empty SpriteList

* Docstring update for SpriteList.pop

* Add tests for pop exceptions

* Fix doc build

* Fix typos and use inv file inspection target

* Use python -m sphinx.ext.intersphinx to discover the pop doc's actual target (Python, why?)

* Fix various typos and style issues

Author: pushfoo

arcade/sprite_list/sprite_list.py

@@ -589,13 +589,20 @@ def clear(self, deep: bool = True) -> None:
             self._init_deferred()
 
     def pop(self, index: int = -1) -> SpriteType:
-        """
-        Pop off the last sprite, or the given index, from the list
+        """Attempt to pop a sprite from the list.
+
+        This works like :external:ref:`popping from <tut-morelists>` a
+        standard Python :py:class:`list`:
+
+        #. If the list is empty, raise an :py:class:`IndexError`
+        #. If no ``index`` is passed, try to pop the last
+           :py:class:`Sprite` in the list
 
-        :param index: Index of sprite to remove, defaults to -1 for the last item.
+        :param index: Index of sprite to remove (defaults to ``-1`` for
+            the last item)
         """
         if len(self.sprite_list) == 0:
-            raise (ValueError("pop from empty list"))
+            raise IndexError("pop from empty list")
 
         sprite = self.sprite_list[index]
         self.remove(sprite)

tests/unit/spritelist/test_spritelist.py

@@ -113,6 +113,22 @@ def test_it_can_pop_at_a_given_index():
     assert [spritelist.sprite_slot[s] for s in spritelist] == [0, 2]
 
 
+def test_it_raises_indexerror_when_popping_from_empty_spritelist():
+    spritelist = make_named_sprites(0)
+
+    # With default index
+    with pytest.raises(IndexError):
+        spritelist.pop()
+
+    # With positional argument
+    with pytest.raises(IndexError):
+        spritelist.pop(0)
+
+    # With keyword argument
+    with pytest.raises(IndexError):
+        spritelist.pop(index=1)
+
+
 def test_setitem(ctx):
     """Testing __setitem__"""
     num_sprites = 10