fix: resolve comprehensive codebase review findings

- docs: update CONTRIBUTING.md lint task descriptions
- build: fix pyproject.toml per-file-ignores glob for tests
- ui: replace duplicate error-msg IDs with form-error-text class
- core: use exact line matching for duplicate author check
- core: add exponential backoff for pygit2.clone_repository
- i18n: fix Italian translation for 'Quit'
- core: add dict type guard for markdown yaml metadata
- ui: sanitize authentication error messages in LoadingScreen
- ui: add XOR validation for social platform/URL entries
- ui: restore focus indicator for Select widget in styles
- ui: sort markdown files for deterministic order in member list
- refactor: add explicit type annotations to MemberApp variables
- test: fix various unit and E2E test failures and edge cases

Author: zodiacfireworks

CONTRIBUTING.md

@@ -29,7 +29,7 @@ This document explains how to contribute to the edit-python.pe project, the comm
 
 We use `poethepoet` (poe) as our task runner. Run the following commands as needed during development:
 
-- `uv run poe lint`: Runs the `ruff` linter (and checks types using `ty`).
+- `uv run poe lint`: Runs the `ruff` linter.
 - `uv run poe lint:format`: Formats the code using `ruff format`.
 - `uv run poe lint:types`: Checks types using `ty check`.
 - `uv run poe lint:docs`: Lints Markdown files using `markdownlint` (excludes `CHANGELOG.md`).

pyproject.toml

@@ -141,7 +141,7 @@ ignore = [
 ]
 
 [tool.ruff.lint.per-file-ignores]
-"tests/*" = [
+"tests/**/*.py" = [
   "S101",  # Use of assert detected
   "S105",  # Use of hardcoded password string
   "S106",  # Use of hardcoded password function args

src/edit_python_pe/app.py

@@ -1,3 +1,4 @@
+from github.Repository import Repository
 from textual.app import App
 
 from .screens.language import LanguageScreen
@@ -8,10 +9,10 @@ class MemberApp(App):
 
     def __init__(self) -> None:
         super().__init__()
-        self.original_repo = None
-        self.forked_repo = None
-        self.token = ""
-        self.repo_path = ""
+        self.original_repo: Repository | None = None
+        self.forked_repo: Repository | None = None
+        self.token: str | None = ""
+        self.repo_path: str | None = ""
 
     def on_mount(self) -> None:
         self.push_screen(LanguageScreen())

src/edit_python_pe/components/form_control.py

@@ -26,21 +26,21 @@ def compose(self) -> ComposeResult:
         if self.help_text_content:
             yield Static(self.help_text_content, classes="form-help-text")
 
-        yield Static("", classes="form-error-text", id="error-msg")
+        yield Static("", classes="form-error-text")
 
     def on_mount(self) -> None:
-        self.query_one("#error-msg", Static).display = False
+        self.query_one(".form-error-text", Static).display = False
 
     def show_error(self, message: str) -> None:
-        error_static = self.query_one("#error-msg", Static)
+        error_static = self.query_one(".form-error-text", Static)
         error_static.update(message)
         error_static.display = True
 
         # Apply has-error class to self
         self.add_class("has-error")
 
     def clear_error(self) -> None:
-        error_static = self.query_one("#error-msg", Static)
+        error_static = self.query_one(".form-error-text", Static)
         error_static.update("")
         error_static.display = False
 

src/edit_python_pe/file_io.py

@@ -34,6 +34,7 @@ def _write_authors_file(
         contents = ""
 
     alias = aliases[0] if aliases else name
-    file_content = f"\n{name}({alias}) <{email}>"
-    if file_content.strip() not in contents:
-        _append_file(file_content, file_path)
+    candidate = f"{name}({alias}) <{email}>"
+    normalized_lines = [line.strip() for line in contents.splitlines()]
+    if candidate not in normalized_lines:
+        _append_file(f"\n{candidate}", file_path)

src/edit_python_pe/github_client.py

@@ -1,4 +1,6 @@
+import logging
 import os
+import random
 import shutil
 from time import sleep
 
@@ -13,6 +15,8 @@
 from .markdown_builder import _create_member_file
 from .strings import _
 
+logger = logging.getLogger(__name__)
+
 
 def get_repo(token: str) -> tuple[str, Repository]:
     auth = Auth.Token(token)
@@ -41,8 +45,27 @@ def fork_repo(token: str, original_repo: Repository) -> tuple[str, Repository]:
     callbacks = pygit2.callbacks.RemoteCallbacks(
         credentials=pygit2.UserPass(token, "x-oauth-basic")
     )
-    sleep(3)
-    pygit2.clone_repository(forked_repo_url, repo_path, callbacks=callbacks)
+
+    max_retries = 5
+    for attempt in range(max_retries):
+        try:
+            pygit2.clone_repository(forked_repo_url, repo_path, callbacks=callbacks)
+            break
+        except Exception as e:
+            if attempt == max_retries - 1:
+                logger.error(
+                    "Failed to clone forked repository after %d attempts", max_retries
+                )
+                raise
+            sleep_time = 2**attempt + random.uniform(0, 1)  # noqa: S311
+            logger.warning(
+                "Attempt %d to clone repository failed: %s. Retrying in %.2fs...",
+                attempt + 1,
+                e,
+                sleep_time,
+            )
+            sleep(sleep_time)
+
     return repo_path, forked_repo
 
 
@@ -57,7 +80,7 @@ def create_pr(
     name: str,
     email: str,
 ) -> tuple[str, str | None]:
-    name_file, file_path = _create_member_file(
+    name_file, _unused_file_path = _create_member_file(
         file_content,
         current_file,
         repo_path,

src/edit_python_pe/locale/it/LC_MESSAGES/messages.mo

@@ -94,7 +94,7 @@ msgstr "Indietro"
 #: src/edit_python_pe/screens/member_list.py:30
 #: src/edit_python_pe/screens/save_loading.py:53
 msgid "Quit"
-msgstr "Esentato"
+msgstr "Esci"
 
 #: src/edit_python_pe/screens/dashboard.py:20
 msgid "Add New Member"

src/edit_python_pe/locale/it/LC_MESSAGES/messages.po

@@ -84,6 +84,9 @@ def load_file_into_form(
         except Exception:
             yaml_data = {}
 
+        if not isinstance(yaml_data, dict):
+            yaml_data = {}
+
     screen.name_input.value = yaml_data.get("author", "")
     screen.city_input.value = yaml_data.get("location", "")
 

src/edit_python_pe/markdown_builder.py

@@ -1,3 +1,4 @@
+import logging
 from typing import TYPE_CHECKING, cast
 
 from textual import work
@@ -15,6 +16,8 @@
 from .dashboard import DashboardScreen
 from .quit_confirm import QuitConfirmScreen
 
+logger = logging.getLogger(__name__)
+
 
 class LoadingScreen(Screen):
     def __init__(self, token: str, **kwargs) -> None:
@@ -58,7 +61,7 @@ def check_quit(quit_app: bool | None) -> None:
     @work(thread=True, exclusive=True)
     def authenticate_and_clone(self) -> None:
         try:
-            _, original_repo = get_repo(self.token)
+            _token, original_repo = get_repo(self.token)
             repo_path, forked_repo = fork_repo(self.token, original_repo)
 
             app = cast("MemberApp", self.app)
@@ -69,8 +72,12 @@ def authenticate_and_clone(self) -> None:
             app.token = self.token
 
             self.app.call_from_thread(self.show_success)
-        except Exception as e:
-            error_message = str(e)
+        except Exception:
+            logger.error("Error during authentication and cloning", exc_info=True)
+            error_message = _(
+                "An unexpected error occurred while loading. "
+                "Please try again or contact support."
+            )
             self.app.call_from_thread(self.show_error, error_message)
 
     def show_success(self) -> None: