test: fix assertion lengths, redundant query checks, and mocks

Author: zodiacfireworks

tests/unit/components/test_layout.py

@@ -15,7 +15,5 @@ class TestLayout:
     async def test_layout_rendering(self):
         app = ComponentTestApp()
         async with app.run_test():
-            header = app.query_one(AppHeader)
-            footer = app.query_one(AppFooter)
-            assert header is not None
-            assert footer is not None
+            app.query_one(AppHeader)
+            app.query_one(AppFooter)

tests/unit/test_github_client.py

@@ -38,7 +38,7 @@ def test_get_repo_github_exception(self, mock_github):
         "edit_python_pe.github_client.user_data_dir",
         return_value="/tmp/testrepo",
     )
-    @patch("edit_python_pe.markdown_builder.os.path.exists", return_value=False)
+    @patch("edit_python_pe.github_client.os.path.exists", return_value=False)
     @patch("edit_python_pe.github_client.shutil.rmtree")
     @patch("edit_python_pe.github_client.pygit2.clone_repository")
     @patch("edit_python_pe.github_client.sleep", return_value=None)
@@ -68,7 +68,7 @@ def test_fork_repo_no_remove_if_not_exists(
         "edit_python_pe.github_client.user_data_dir",
         return_value="/tmp/testrepo",
     )
-    @patch("edit_python_pe.markdown_builder.os.path.exists", return_value=True)
+    @patch("edit_python_pe.github_client.os.path.exists", return_value=True)
     @patch("edit_python_pe.github_client.shutil.rmtree")
     @patch("edit_python_pe.github_client.pygit2.clone_repository")
     @patch("edit_python_pe.github_client.sleep", return_value=None)

tests/unit/test_github_client_more.py

@@ -96,7 +96,7 @@ def test_save_member_with_current_file_no_existing_pr(
         mock_pr.html_url = "http://fake-pr-url-new"
         mock_original_repo.create_pull.return_value = mock_pr
 
-        msg, url = create_pr(
+        _, url = create_pr(
             file_content="test",
             current_file="test.md",
             repo_path="/fake/repo",

tests/unit/test_strings.py

@@ -2,7 +2,11 @@
 
 
 class TestStrings:
-    def test_strings_set_language(self):
-        set_language("es")
-        assert isinstance(_("Hello"), str)
-        set_language("en")
+    def test_strings_set_language(self, monkeypatch):
+        # Undo the autouse fixture from conftest.py that mocks gettext
+        monkeypatch.undo()
+        try:
+            set_language("es")
+            assert _("Quit") == "Abandonar"
+        finally:
+            set_language("en")