Merge pull request #911 from pupi1985/patch-146

svivian · web-flow · commit 5813139a0fa7 · 2023-05-22T13:43:31.000+01:00
Fix #898: error while adding categories in PHP 8
diff --git a/qa-include/pages/admin/admin-categories.php b/qa-include/pages/admin/admin-categories.php
@@ -480,7 +480,8 @@
 
 		else {
 			$positionvalue = isset($previous) ? qa_lang_html_sub('admin/after_x', qa_html($previous['title'])) : qa_lang_html('admin/first');
-			$positionoptions[1 + @max(array_keys($positionoptions))] = $positionvalue;
+			$index = empty($positionoptions) ? 0 : max(array_keys($positionoptions));
+			$positionoptions[1 + $index] = $positionvalue;
 		}
 
 		$qa_content['form']['fields']['position'] = array(

Original file line number	Diff line number	Diff line change
`@@ -480,7 +480,8 @@`
`480`	`480`
`481`	`481`	`else {`
`482`	`482`	`$positionvalue = isset($previous) ? qa_lang_html_sub('admin/after_x', qa_html($previous['title'])) : qa_lang_html('admin/first');`
`483`		`- $positionoptions[1 + @max(array_keys($positionoptions))] = $positionvalue;`
	`483`	`+ $index = empty($positionoptions) ? 0 : max(array_keys($positionoptions));`
	`484`	`+ $positionoptions[1 + $index] = $positionvalue;`
`484`	`485`	`}`
`485`	`486`
`486`	`487`	`$qa_content['form']['fields']['position'] = array(`