Merge pull request #948 from pupi1985/patch-153

Fix many string management functions in PHP 8.1

Author: svivian

qa-include/Q2A/Plugin/PluginManager.php

@@ -49,11 +49,11 @@ public function readAllPluginMetadatas()
 			}
 
 			// skip plugin which requires a later version of Q2A
-			if (isset($metadata['min_q2a']) && qa_qa_version_below($metadata['min_q2a'])) {
+			if (qa_qa_version_below($metadata['min_q2a'] ?? '')) {
 				continue;
 			}
 			// skip plugin which requires a later version of PHP
-			if (isset($metadata['min_php']) && qa_php_version_below($metadata['min_php'])) {
+			if (qa_php_version_below($metadata['min_php'] ?? '')) {
 				continue;
 			}
 

qa-include/ajax/asktitle.php

@@ -27,7 +27,7 @@
 
 // Collect the information we need from the database
 
-$intitle = qa_post_text('title');
+$intitle = (string)qa_post_text('title');
 $doaskcheck = qa_opt('do_ask_check_qs');
 $doexampletags = qa_using_tags() && qa_opt('do_example_tags');
 

qa-include/ajax/category.php

@@ -23,7 +23,7 @@
 
 
 $categoryid = qa_post_text('categoryid');
-if (!strlen($categoryid))
+if (!strlen((string)$categoryid))
 	$categoryid = null;
 
 list($fullcategory, $categories) = qa_db_select_with_pending(
@@ -33,7 +33,7 @@
 
 echo "QA_AJAX_RESPONSE\n1\n";
 
-echo qa_html(strtr(@$fullcategory['content'], "\r\n", '  ')); // category description
+echo qa_html(strtr($fullcategory['content'] ?? '', "\r\n", '  ')); // category description
 
 foreach ($categories as $category) {
 	// subcategory information

qa-include/ajax/version.php

@@ -50,22 +50,22 @@
 	$metadataUtil = new Q2A_Util_Metadata();
 	$metadata = $metadataUtil->fetchFromUrl($uri);
 
-	if (strlen(@$metadata['version']) > 0) {
+	if (strlen($metadata['version'] ?? '') > 0) {
 		if (version_compare($currentVersion, $metadata['version']) < 0) {
-			if (qa_qa_version_below(@$metadata['min_q2a'])) {
+			if (qa_qa_version_below($metadata['min_q2a'] ?? '')) {
 				$response = strtr(qa_lang_html('admin/version_requires_q2a'), array(
 					'^1' => qa_html('v' . $metadata['version']),
 					'^2' => qa_html($metadata['min_q2a']),
 				));
-			} elseif (qa_php_version_below(@$metadata['min_php'])) {
+			} elseif (qa_php_version_below($metadata['min_php'] ?? '')) {
 				$response = strtr(qa_lang_html('admin/version_requires_php'), array(
 					'^1' => qa_html('v' . $metadata['version']),
 					'^2' => qa_html($metadata['min_php']),
 				));
 			} else {
 				$response = qa_lang_html_sub('admin/version_get_x', qa_html('v' . $metadata['version']));
 
-				if (strlen(@$metadata['uri'])) {
+				if (strlen($metadata['uri'] ?? '')) {
 					$response = '<a href="' . qa_html($metadata['uri']) . '" style="color:#d00;">' . $response . '</a>';
 				}
 			}

qa-include/ajax/wallpost.php

@@ -34,7 +34,7 @@
 
 $errorhtml = qa_wall_error_html($loginuserid, $touseraccount['userid'], $touseraccount['flags']);
 
-if ($errorhtml || !strlen($message) || !qa_check_form_security_code('wall-' . $tohandle, qa_post_text('code'))) {
+if ($errorhtml || !strlen((string)$message) || !qa_check_form_security_code('wall-' . $tohandle, qa_post_text('code'))) {
 	echo "QA_AJAX_RESPONSE\n0"; // if there's an error, process in non-Ajax way
 } else {
 	$messageid = qa_wall_add_post($loginuserid, qa_get_logged_in_handle(), qa_cookie_get(),

qa-include/app/blobs.php

@@ -114,7 +114,7 @@ function qa_write_blob_file($blobid, $content, $format)
 
 		$file = fopen($filename, 'xb');
 		if (is_resource($file)) {
-			if (fwrite($file, $content) >= strlen($content))
+			if (fwrite($file, $content) >= strlen((string)$content))
 				$written = true;
 
 			fclose($file);

qa-include/app/emails.php

@@ -133,10 +133,11 @@ function qa_send_email($params)
 
 	// @error_log(print_r($params, true));
 
-	require_once QA_INCLUDE_DIR . 'vendor/PHPMailer/PHPMailerAutoload.php';
+	require_once QA_INCLUDE_DIR . 'vendor/PHPMailer6/PHPMailer.php';
+	require_once QA_INCLUDE_DIR . 'vendor/PHPMailer6/Exception.php';
 
-	PHPMailer::$validator = 'php';
-	$mailer = new PHPMailer();
+	\PHPMailer\PHPMailer\PHPMailer::$validator = 'php';
+	$mailer = new \PHPMailer\PHPMailer\PHPMailer();
 	$mailer->CharSet = 'utf-8';
 
 	$mailer->From = $params['fromemail'];
@@ -153,6 +154,8 @@ function qa_send_email($params)
 		$mailer->isHTML(true);
 
 	if (qa_opt('smtp_active')) {
+		require_once QA_INCLUDE_DIR . 'vendor/PHPMailer6/SMTP.php';
+
 		$mailer->isSMTP();
 		$mailer->Host = qa_opt('smtp_address');
 		$mailer->Port = qa_opt('smtp_port');

qa-include/app/favorites.php

@@ -197,7 +197,7 @@ function qa_favorite_categories_view($categories)
 		$cat_anchor = $category['qcount'] == 1
 			? qa_lang_html_sub('main/1_question', '1', '1')
 			: qa_lang_html_sub('main/x_questions', qa_format_number($category['qcount'], 0, true));
-		$cat_descr = strlen($category['content']) ? qa_html(' - ' . $category['content']) : '';
+		$cat_descr = strlen((string)$category['content']) ? qa_html(' - ' . $category['content']) : '';
 
 		$nav_list_categories['nav'][$category['categoryid']] = array(
 			'label' => qa_html($category['title']),

qa-include/app/format.php

@@ -83,7 +83,7 @@ function qa_post_is_by_user($post, $userid, $cookieid)
 	if (@$post['userid'] || $userid)
 		return @$post['userid'] == $userid;
 	elseif (@$post['cookieid'])
-		return strcmp($post['cookieid'], $cookieid) == 0;
+		return $post['cookieid'] === $cookieid;
 
 	return false;
 }
@@ -209,6 +209,10 @@ function qa_tag_html($tag, $microdata = false, $favorited = false)
  */
 function qa_category_path($navcategories, $categoryid)
 {
+	if ($categoryid === null) {
+		return array();
+	}
+
 	$upcategories = array();
 
 	for ($upcategory = @$navcategories[$categoryid]; isset($upcategory); $upcategory = @$navcategories[$upcategory['parentid']])
@@ -266,7 +270,7 @@ function qa_ip_anchor_html($ip, $anchorhtml = null)
 {
 	if (qa_to_override(__FUNCTION__)) { $args=func_get_args(); return qa_call_override(__FUNCTION__, $args); }
 
-	if (!strlen($anchorhtml))
+	if (!strlen((string)$anchorhtml))
 		$anchorhtml = qa_html($ip);
 
 	return '<a href="' . qa_path_html('ip/' . $ip) . '" title="' . qa_lang_html_sub('main/ip_address_x', qa_html($ip)) . '" class="qa-ip-link">' . $anchorhtml . '</a>';
@@ -432,7 +436,7 @@ function qa_post_html_fields($post, $userid, $cookieid, $usershtml, $dummy, $opt
 	// Voting stuff
 
 	if (@$options['voteview']) {
-		$voteview = $options['voteview'];
+		$voteview = (string)$options['voteview'];
 
 		// Calculate raw values and pass through
 
@@ -573,7 +577,7 @@ function qa_post_html_fields($post, $userid, $cookieid, $usershtml, $dummy, $opt
 	if (@$options['whatview']) {
 		$fields['what'] = qa_lang_html($isquestion ? 'main/asked' : ($isanswer ? 'main/answered' : 'main/commented'));
 
-		if (@$options['whatlink'] && strlen(@$options['q_request'])) {
+		if (@$options['whatlink'] && strlen($options['q_request'] ?? '')) {
 			$fields['what_url'] = $post['basetype'] == 'Q'
 				? qa_path_html($options['q_request'])
 				: qa_path_html($options['q_request'], array('show' => $postid), null, null, qa_anchor($post['basetype'], $postid));
@@ -754,7 +758,7 @@ function qa_who_to_html($isbyuser, $postuserid, $usershtml, $ip = null, $microda
 	if (isset($postuserid) && isset($usershtml[$postuserid])) {
 		$whohtml = $usershtml[$postuserid];
 	} else {
-		if (strlen($name))
+		if (strlen((string)$name))
 			$whohtml = qa_html($name);
 		elseif ($isbyuser)
 			$whohtml = qa_lang_html('main/me');
@@ -1293,7 +1297,7 @@ function qa_html_suggest_qs_tags($usingtags = false, $categoryrequest = null)
 {
 	if (qa_to_override(__FUNCTION__)) { $args=func_get_args(); return qa_call_override(__FUNCTION__, $args); }
 
-	$hascategory = strlen($categoryrequest);
+	$hascategory = strlen((string)$categoryrequest);
 
 	$htmlmessage = $hascategory ? qa_lang_html('main/suggest_category_qs') :
 		($usingtags ? qa_lang_html('main/suggest_qs_tags') : qa_lang_html('main/suggest_qs'));
@@ -1326,7 +1330,7 @@ function qa_html_suggest_ask($categoryid = null)
 		$htmlmessage,
 
 		array(
-			'^1' => '<a href="' . qa_path_html('ask', strlen($categoryid) ? array('cat' => $categoryid) : null) . '">',
+			'^1' => '<a href="' . qa_path_html('ask', strlen((string)$categoryid) ? array('cat' => $categoryid) : null) . '">',
 			'^2' => '</a>',
 		)
 	);
@@ -1723,7 +1727,7 @@ function qa_get_tags_field_value($fieldname)
 {
 	require_once QA_INCLUDE_DIR . 'util/string.php';
 
-	$text = qa_remove_utf8mb4(qa_post_text($fieldname));
+	$text = qa_remove_utf8mb4((string)qa_post_text($fieldname));
 
 	if (qa_opt('tag_separator_comma'))
 		return array_unique(preg_split('/\s*,\s*/', trim(qa_strtolower(strtr($text, '/', ' '))), -1, PREG_SPLIT_NO_EMPTY));
@@ -1796,21 +1800,21 @@ function qa_set_up_category_field(&$qa_content, &$field, $fieldname, $navcategor
 			$depth++; // to count category itself
 
 			foreach ($navcategories as $navcategory) // now get siblings and self
-				if (!strcmp($navcategory['parentid'], $category['parentid']))
+				if (!strcmp($navcategory['parentid'] ?? '', $category['parentid'] ?? ''))
 					$keycategoryids[$navcategory['categoryid']] = true;
 		}
 
 		if ($depth < $maxdepth)
 			foreach ($navcategories as $navcategory) // now get children, if not too deep
-				if (!strcmp($navcategory['parentid'], $categoryid))
+				if (!strcmp($navcategory['parentid'] ?? '', $categoryid ?? ''))
 					$keycategoryids[$navcategory['categoryid']] = true;
 
 	} else {
 		$haschildren = false;
 
 		foreach ($navcategories as $navcategory) {
 			// check if it has any children
-			if (!strcmp($navcategory['parentid'], $categoryid)) {
+			if (!strcmp($navcategory['parentid'] ?? '', $categoryid ?? '')) {
 				$haschildren = true;
 				break;
 			}
@@ -1821,7 +1825,7 @@ function qa_set_up_category_field(&$qa_content, &$field, $fieldname, $navcategor
 	}
 
 	foreach ($keycategoryids as $keycategoryid => $dummy)
-		if (strcmp($keycategoryid, $excludecategoryid))
+		if (strcmp($keycategoryid, $excludecategoryid ?? ''))
 			$field['options'][$keycategoryid] = qa_category_path_html($navcategories, $keycategoryid);
 
 	$field['value'] = @$field['options'][$categoryid];
@@ -1841,13 +1845,13 @@ function qa_get_category_field_value($fieldname)
 {
 	for ($level = QA_CATEGORY_DEPTH; $level >= 1; $level--) {
 		$levelid = qa_post_text($fieldname . '_' . $level);
-		if (strlen($levelid))
+		if (strlen((string)$levelid))
 			return $levelid;
 	}
 
 	if (!isset($levelid)) { // no Javascript-generated menu was present so take original menu
 		$levelid = qa_post_text($fieldname . '_0');
-		if (strlen($levelid))
+		if (strlen((string)$levelid))
 			return $levelid;
 	}
 
@@ -2008,7 +2012,7 @@ function qa_load_theme_class($theme, $template, $content, $request)
 
 	foreach ($loadlayers as $layer) {
 		$filename = $layer['directory'] . $layer['include'];
-		$layerphp = file_get_contents($filename);
+		$layerphp = (string)file_get_contents($filename);
 
 		if (strlen($layerphp)) {
 			// include file name in layer class name to make debugging easier if there is an error
@@ -2185,7 +2189,7 @@ function qa_get_post_title($fieldname)
 {
 	require_once QA_INCLUDE_DIR . 'util/string.php';
 
-	return qa_remove_utf8mb4(qa_post_text($fieldname));
+	return qa_remove_utf8mb4((string)qa_post_text($fieldname));
 }
 
 /**
@@ -2247,7 +2251,7 @@ function qa_get_avatar_blob_html($blobId, $width, $height, $size, $padding = fal
 	require_once QA_INCLUDE_DIR . 'util/image.php';
 	require_once QA_INCLUDE_DIR . 'app/users.php';
 
-	if (strlen($blobId) == 0 || (int)$size <= 0) {
+	if (strlen((string)$blobId) == 0 || (int)$size <= 0) {
 		return null;
 	}
 

qa-include/app/limits.php

@@ -151,10 +151,14 @@ function qa_is_ip_blocked()
 	if (isset($qa_curr_ip_blocked))
 		return $qa_curr_ip_blocked;
 
-	$qa_curr_ip_blocked = false;
-	$blockipclauses = qa_block_ips_explode(qa_opt('block_ips_write'));
 	$ip = qa_remote_ip_address();
 
+	$qa_curr_ip_blocked = false;
+	if ($ip === null) {
+		return false;
+	}
+
+	$blockipclauses = qa_block_ips_explode(qa_opt('block_ips_write'));
 	foreach ($blockipclauses as $blockipclause) {
 		if (qa_block_ip_match($ip, $blockipclause)) {
 			$qa_curr_ip_blocked = true;
@@ -172,7 +176,7 @@ function qa_is_ip_blocked()
  */
 function qa_block_ips_explode($blockipstring)
 {
-	$blockipstring = preg_replace('/\s*\-\s*/', '-', $blockipstring); // special case for 'x.x.x.x - x.x.x.x'
+	$blockipstring = preg_replace('/\s*\-\s*/', '-', (string)$blockipstring); // special case for 'x.x.x.x - x.x.x.x'
 
 	return preg_split('/[^0-9A-Fa-f\.:\-\*]/', $blockipstring, -1, PREG_SPLIT_NO_EMPTY);
 }
@@ -248,7 +252,6 @@ function qa_ip_between($ip, $startip, $endip)
 function qa_ipv6_expand($ip)
 {
 	$ipv6_wildcard = false;
-	$wildcards = '';
 	$wildcards_matched = array();
 	if (strpos($ip, "*") !== false) {
 		$ipv6_wildcard = true;